test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] bugfix: Fixed a timeout with mlx5_core on ARM
@ 2021-02-11 21:44 ohilyard
  2021-02-19  6:58 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: ohilyard @ 2021-02-11 21:44 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, Owen Hilyard

From: Owen Hilyard <ohilyard@iol.unh.edu>

The time to unbind this driver has been increasing with DPDK releases, to
the point that it is now about 14 seconds. This means that, with the
default timeout of 15 seconds, there isn't much room for any kind of
disruption during testing. DTS throwing a timeout error here is not
indicative of an acutal problem, and as such I have increased the timeout
to allow continued stable functioning. The new 30 second timeout should
have minimal affect on the detection speed of any real error.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index bef0d15f..21f72e98 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -447,7 +447,7 @@ class Dut(Crb):
                 port = GetNicObj(self, domain_id, bus_id, devfun_id)
 
                 self.send_expect('echo %s > /sys/bus/pci/devices/%s\:%s\:%s/driver/unbind'
-                                 % (pci_bus, domain_id, bus_id, devfun_id), '# ')
+                                 % (pci_bus, domain_id, bus_id, devfun_id), '# ', timeout=30)
                 # bind to linux kernel driver
                 self.send_expect('modprobe %s' % driver, '# ')
                 self.send_expect('echo %s > /sys/bus/pci/drivers/%s/bind'
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-19  6:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 21:44 [dts] [PATCH] bugfix: Fixed a timeout with mlx5_core on ARM ohilyard
2021-02-19  6:58 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).