* [PATCH] net/nfp: fix return path in TSO processing function
@ 2022-11-18 16:23 Niklas Söderlund
2022-11-22 2:02 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2022-11-18 16:23 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, Fei Qin, stable, Niklas Söderlund, Chaoyong He
From: Fei Qin <fei.qin@corigine.com>
When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx
descriptor. However, the return path for TSO is lost and the LSO related
fields of Tx descriptor is filled with zeros which prevents packets from
being sent.
This patch fixes the return path in TSO processing function to make sure
TSO works fine.
Fixes: c73dced48c8c ("net/nfp: add NFDk Tx")
Cc: stable@dpdk.org
Signed-off-by: Fei Qin <fei.qin@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
drivers/net/nfp/nfp_rxtx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 38377ca2182e..01cffdfde0b4 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -1135,6 +1135,8 @@ nfp_net_nfdk_tx_tso(struct nfp_net_txq *txq, struct rte_mbuf *mb)
txd.lso_hdrlen = mb->l2_len + mb->l3_len + mb->l4_len;
txd.lso_totsegs = (mb->pkt_len + mb->tso_segsz) / mb->tso_segsz;
+ return txd.raw;
+
clean_txd:
txd.l3_offset = 0;
txd.l4_offset = 0;
--
2.38.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/nfp: fix return path in TSO processing function
2022-11-18 16:23 [PATCH] net/nfp: fix return path in TSO processing function Niklas Söderlund
@ 2022-11-22 2:02 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2022-11-22 2:02 UTC (permalink / raw)
To: Niklas Söderlund, dev; +Cc: oss-drivers, Fei Qin, stable, Chaoyong He
On 11/18/2022 4:23 PM, Niklas Söderlund wrote:
> From: Fei Qin <fei.qin@corigine.com>
>
> When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx
> descriptor. However, the return path for TSO is lost and the LSO related
> fields of Tx descriptor is filled with zeros which prevents packets from
> being sent.
>
> This patch fixes the return path in TSO processing function to make sure
> TSO works fine.
>
> Fixes: c73dced48c8c ("net/nfp: add NFDk Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fei Qin <fei.qin@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-22 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 16:23 [PATCH] net/nfp: fix return path in TSO processing function Niklas Söderlund
2022-11-22 2:02 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).