From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: dev <dev@dpdk.org>, Paolo Valerio <pvalerio@redhat.com>,
Aaron Conole <aconole@redhat.com>,
"Rong, Leyi" <leyi.rong@intel.com>,
"Tu, Lijuan" <lijuan.tu@intel.com>,
"Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>,
Feifei Wang <Feifei.Wang2@arm.com>, dpdk stable <stable@dpdk.org>,
"Guo, Jia" <jia.guo@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3] net/ixgbe: fix UDP zero checksum error
Date: Thu, 8 Apr 2021 01:12:39 +0000 [thread overview]
Message-ID: <BN8PR11MB379556D02AEB5667BD37FA76F7749@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yBNOHuBgSAm+6JNqY_0dN4THyr75JC-q1UJVmAZWokdw@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, April 7, 2021 19:54
> To: Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev <dev@dpdk.org>; Paolo Valerio <pvalerio@redhat.com>; Aaron Conole <aconole@redhat.com>; Rong,
> Leyi <leyi.rong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>; Ruifeng Wang (Arm Technology China)
> <Ruifeng.Wang@arm.com>; Feifei Wang <Feifei.Wang2@arm.com>; dpdk stable <stable@dpdk.org>; Guo, Jia
> <jia.guo@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-stable] [PATCH v3] net/ixgbe: fix UDP zero checksum error
>
> On Thu, Feb 25, 2021 at 11:54 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Hello Haiyue,
> >
> > On Thu, Feb 4, 2021 at 3:56 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
> > >
> > > There is an 82599 errata that UDP frames with a zero checksum are
> > > incorrectly marked as checksum invalid by the hardware. This was
> > > leading to misleading PKT_RX_L4_CKSUM_BAD flag.
> > >
> > > This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN,
> > > so the software application will then have to recompute the checksum
> > > itself if needed.
> > >
> > > Bugzilla ID: 629
> > > Fixes: af75078fece3 ("first public release")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: Paolo Valerio <pvalerio@redhat.com>
> > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >
> > There was a previous mention of this issue in the past and it resulted
> > in dropping part of the hw statistics.
> > https://git.dpdk.org/dpdk/commit/?id=256ff05a9cae7484e2197cde4401dfa1f21d5a6f
> >
> > Does it make sense to restrict this "fix" to 82599 only?
Make sense.
>
> ping.
>
>
> --
> David Marchand
prev parent reply other threads:[~2021-04-08 1:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 7:06 [dpdk-stable] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum Haiyue Wang
2021-02-02 9:45 ` David Marchand
2021-02-02 12:42 ` Wang, Haiyue
2021-02-02 12:53 ` David Marchand
2021-02-02 12:56 ` Wang, Haiyue
2021-02-02 14:28 ` Wang, Haiyue
2021-02-02 17:42 ` Paolo Valerio
2021-02-02 12:54 ` Wang, Haiyue
2021-02-03 2:19 ` [dpdk-stable] [PATCH v2] net/ixgbe: fix UDP zero checksum error Haiyue Wang
2021-02-03 8:07 ` Zhang, Qi Z
2021-02-03 8:32 ` David Marchand
2021-02-04 7:45 ` Zhang, Qi Z
2021-02-04 14:39 ` [dpdk-stable] [PATCH v3] " Haiyue Wang
2021-02-05 17:50 ` Paolo Valerio
2021-02-07 18:40 ` Paolo Valerio
2021-02-08 13:48 ` Ananyev, Konstantin
2021-02-09 1:23 ` Zhang, Qi Z
2021-02-25 10:54 ` David Marchand
2021-04-07 11:53 ` David Marchand
2021-04-08 1:12 ` Wang, Haiyue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB379556D02AEB5667BD37FA76F7749@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=Feifei.Wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=leyi.rong@intel.com \
--cc=lijuan.tu@intel.com \
--cc=pvalerio@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).