From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: "Xueming(Steven) Li" <xuemingl@nvidia.com>
Cc: dpdk stable <stable@dpdk.org>, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] Should we backport or skip e132ee86 "devargs: fix memory leak on parsing failure"
Date: Tue, 1 Jun 2021 09:45:17 +0200 [thread overview]
Message-ID: <CAATJJ0K+Ak=iKdWC_CyaoyBxwpCFqfpU8kfyz9hECXoA6EQiSQ@mail.gmail.com> (raw)
In-Reply-To: <DM4PR12MB53738D36F8DA383BE6B66B97A13E9@DM4PR12MB5373.namprd12.prod.outlook.com>
On Tue, Jun 1, 2021 at 9:01 AM Xueming(Steven) Li <xuemingl@nvidia.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Sent: Tuesday, June 1, 2021 2:07 PM
> > To: dpdk stable <stable@dpdk.org>; Xueming(Steven) Li <xuemingl@nvidia.com>
> > Cc: Luca Boccassi <bluca@debian.org>
> > Subject: Should we backport or skip e132ee86 "devargs: fix memory leak on parsing failure"
> >
> > Hi Xueming,
> >
> > I wanted to let you know that while backporting:
> > Commit e132ee8690474fa985e26f1d4db75823024748c8
> > Author: Xueming Li <xuemingl@nvidia.com>
> > Date: Tue Apr 13 03:14:09 2021 +0000
> > devargs: fix memory leak on parsing failure
> >
> > I've found
> >
> > [ 288s] ../lib/librte_eal/common/eal_common_devargs.c:171:16: error:
> > passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> > [ 288s] 171 | free(devargs->data);
> > [ 288s] | ~~~~~~~^~~~~~
> > [ 288s] In file included from ../lib/librte_eal/common/include/rte_common.h:20,
> > [ 288s] from ../lib/librte_eal/common/include/rte_log.h:25,
> > [ 288s] from ../lib/librte_eal/common/include/rte_bus.h:24,
> > [ 288s] from ../lib/librte_eal/common/eal_common_devargs.c:13:
> > [ 288s] /usr/include/stdlib.h:565:25: note: expected ‘void *’ but argument is of type ‘const char *’
> > [ 288s] 565 | extern void free (void *__ptr) __THROW;
> > [ 288s] | ~~~~~~^~~~~
> >
> > I've seen that to make it work it would require some more from the same series, but that was not targeted at dpgk-stable
> >
> > Commit 64051bb1f144c418f3fc76e6d0973337b05d5886
> > Author: Xueming Li <xuemingl@nvidia.com>
> > Date: Tue Apr 13 03:14:08 2021 +0000
> > devargs: unify scratch buffer storage
> >
> > Then I've checked and seen that it is also not present in lib/librte_eal/common/eal_common_devargs.c of 20.11.2 that you are
> > preparing so I have also dropped it from 19.11.9 as well for now.
> >
> > Do you think you'd want to create backports of this for 19.11/20.11 or is it not important enough to bother about it?
>
> Yes, need another patch to make this one work. But I don't think it important enough to have it.
Great, that is all I needed to know to "let it go" mentally :-)
Thanks!
> > --
> > Christian Ehrhardt
> > Staff Engineer, Ubuntu Server
> > Canonical Ltd
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2021-06-01 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 6:07 Christian Ehrhardt
2021-06-01 7:01 ` Xueming(Steven) Li
2021-06-01 7:45 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0K+Ak=iKdWC_CyaoyBxwpCFqfpU8kfyz9hECXoA6EQiSQ@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=bluca@debian.org \
--cc=stable@dpdk.org \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).