patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/mlx5: fix Tx queue completions on stop
@ 2020-11-06 16:58 Viacheslav Ovsiienko
  2020-11-09 10:30 ` Matan Azrad
  2020-11-09 15:37 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Viacheslav Ovsiienko @ 2020-11-06 16:58 UTC (permalink / raw)
  To: dev; +Cc: rasland, akozyrev, matan, stable

The Tx queue completion production index was not reset
on Tx queue stop and there were completions remaining
from the previous queue run. This caused the wrong
completion queue operating and overall Tx queue malfunction
on queue restart.

Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_txq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index faf4e45..d96abef 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -154,6 +154,7 @@
 	/* Resync CQE and WQE (WQ in reset state). */
 	rte_io_wmb();
 	*txq->cq_db = rte_cpu_to_be_32(txq->cq_ci);
+	txq->cq_pi = txq->cq_ci;
 	rte_io_wmb();
 }
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx5: fix Tx queue completions on stop
  2020-11-06 16:58 [dpdk-stable] [PATCH] net/mlx5: fix Tx queue completions on stop Viacheslav Ovsiienko
@ 2020-11-09 10:30 ` Matan Azrad
  2020-11-09 15:37 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2020-11-09 10:30 UTC (permalink / raw)
  To: Slava Ovsiienko, dev; +Cc: Raslan Darawsheh, Alexander Kozyrev, stable



From: Viacheslav Ovsiienko
> The Tx queue completion production index was not reset on Tx queue stop and
> there were completions remaining from the previous queue run. This caused
> the wrong completion queue operating and overall Tx queue malfunction on
> queue restart.
> 
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx5: fix Tx queue completions on stop
  2020-11-06 16:58 [dpdk-stable] [PATCH] net/mlx5: fix Tx queue completions on stop Viacheslav Ovsiienko
  2020-11-09 10:30 ` Matan Azrad
@ 2020-11-09 15:37 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-11-09 15:37 UTC (permalink / raw)
  To: Slava Ovsiienko, dev; +Cc: Alexander Kozyrev, Matan Azrad, stable

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Friday, November 6, 2020 6:58 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix Tx queue completions on stop
> 
> The Tx queue completion production index was not reset
> on Tx queue stop and there were completions remaining
> from the previous queue run. This caused the wrong
> completion queue operating and overall Tx queue malfunction
> on queue restart.
> 
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_txq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-09 15:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 16:58 [dpdk-stable] [PATCH] net/mlx5: fix Tx queue completions on stop Viacheslav Ovsiienko
2020-11-09 10:30 ` Matan Azrad
2020-11-09 15:37 ` Raslan Darawsheh

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git