patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Vipul Ashri <vipul.ashri@oracle.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "edwin.leung@oracle.com" <edwin.leung@oracle.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Wang, Zhihong" <zhihong.wang@intel.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-stable] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro
Date: Thu, 13 Aug 2020 07:35:18 +0000
Message-ID: <MN2PR11MB4063FA510C2EDCBC5EEBF8229C430@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200813072837.1468-1-vipul.ashri@oracle.com>

> -----Original Message-----
> From: Vipul Ashri <vipul.ashri@oracle.com>
> Sent: Thursday, August 13, 2020 3:29 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; vipul.ashri@oracle.com;
> edwin.leung@oracle.com; stable@dpdk.org
> Subject: [PATCH v3] net/virtio: fix wrong variable assignment in helper
> macro
> 
> Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always
> failing as assignment done using var_ having local scope only.
> This leads to TX packets not going out and found broken due to cleanup
> malfunctioning. This patch fixes the wrong variable assignment.
> 
> Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
> ---
>  drivers/net/virtio/virtqueue.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtqueue.h
> b/drivers/net/virtio/virtqueue.h
> index 105a9c00c..20c95471e 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)
> 
>  /* avoid write operation when necessary, to lessen cache issues */
>  #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
> -	typeof(var) var_ = (var);		\
> -	typeof(val) val_ = (val);		\
> -	if ((var_) != (val_))			\
> -		(var_) = (val_);		\
> +	if ((var) != (val))			\
> +		(var) = (val);			\
>  } while (0)
> 
>  #define virtqueue_clear_net_hdr(hdr) do {		\
> --
> 2.28.0.windows.1

Thanks for the fix!

But please remember to cc all maintainers next time you send a patch.
I add them this time.

For this patch:

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>




       reply	other threads:[~2020-08-13  7:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200812092306.1345-1-vipul.ashri@oracle.com>
     [not found] ` <20200813072837.1468-1-vipul.ashri@oracle.com>
2020-08-13  7:35   ` Xia, Chenbo [this message]
2020-08-19  1:25   ` Xia, Chenbo
2020-09-16  5:57   ` [dpdk-stable] [PATCH v4] " Vipul Ashri
2020-09-17 15:54     ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2020-09-18  9:55   ` [dpdk-stable] [PATCH v5] " Vipul Ashri
2020-09-18 12:22     ` Maxime Coquelin
2020-09-18 12:30     ` Maxime Coquelin
     [not found] <20200807125731.1287-1-vipul.ashri@oracle.com>
     [not found] ` <20200813162222.1635-1-vipul.ashri@oracle.com>
2020-08-14  1:25   ` [dpdk-stable] [PATCH v3] " Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4063FA510C2EDCBC5EEBF8229C430@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=edwin.leung@oracle.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=vipul.ashri@oracle.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git