* [dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x
@ 2021-06-01 8:05 Christian Ehrhardt
2021-06-01 9:19 ` Min Hu (Connor)
0 siblings, 1 reply; 2+ messages in thread
From: Christian Ehrhardt @ 2021-06-01 8:05 UTC (permalink / raw)
To: dpdk stable, Min Hu (Connor), Yisen Zhuang, Lijun Ou
Hi,
this was targeted for dpdk stable releases.
commit b6579e3db794be36637a66e009199a1e7451e995
Author: Huisong Li <lihuisong@huawei.com>
Date: Tue Mar 23 21:45:51 2021 +0800
net/hns3: fix reporting undefined speed
It introduced
[ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:
In function 'hns3_dev_link_update':
[ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:2618:26:
error: 'ETH_SPEED_NUM_UNKNOWN' undeclared (first use in this function)
[ 403s] new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
[ 403s] ^
But that requires this change from 20.11:
commit 810b17d116f03783843d23ac900a3794675f6616
Author: Thomas Monjalon <thomas@monjalon.net>
Date: Tue Aug 11 11:52:20 2020 +0300
ethdev: allow unknown link speed
I'm unsure if introducing ETH_SPEED_NUM_UNKNOWN in 19.11 might break
other bits not aware of it so for now I have removed that formerly
queued patch from 19.11.9.
If you want it applied to 19.11.9 or later please have a look and
consider providing a backport for it - or alternatively if you think it
is not important for 19.11.x let me know about that.
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x
2021-06-01 8:05 [dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x Christian Ehrhardt
@ 2021-06-01 9:19 ` Min Hu (Connor)
0 siblings, 0 replies; 2+ messages in thread
From: Min Hu (Connor) @ 2021-06-01 9:19 UTC (permalink / raw)
To: Christian Ehrhardt, dpdk stable, Yisen Zhuang, Lijun Ou
Hi，Christian,
Agreed, this patch can be abandoned in 19.11x， It can backport
to 20.11.x.
在 2021/6/1 16:05, Christian Ehrhardt 写道:
> Hi,
> this was targeted for dpdk stable releases.
>
> commit b6579e3db794be36637a66e009199a1e7451e995
> Author: Huisong Li <lihuisong@huawei.com>
> Date: Tue Mar 23 21:45:51 2021 +0800
>
> net/hns3: fix reporting undefined speed
>
> It introduced
>
> [ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:
> In function 'hns3_dev_link_update':
> [ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:2618:26:
> error: 'ETH_SPEED_NUM_UNKNOWN' undeclared (first use in this function)
> [ 403s] new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
> [ 403s] ^
>
> But that requires this change from 20.11:
>
> commit 810b17d116f03783843d23ac900a3794675f6616
> Author: Thomas Monjalon <thomas@monjalon.net>
> Date: Tue Aug 11 11:52:20 2020 +0300
>
> ethdev: allow unknown link speed
>
> I'm unsure if introducing ETH_SPEED_NUM_UNKNOWN in 19.11 might break
> other bits not aware of it so for now I have removed that formerly
> queued patch from 19.11.9.
>
> If you want it applied to 19.11.9 or later please have a look and
> consider providing a backport for it - or alternatively if you think it
> is not important for 19.11.x let me know about that.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 8:05 [dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x Christian Ehrhardt
2021-06-01 9:19 ` Min Hu (Connor)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).