patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect
       [not found] <20200515014056.44949-1-yong.liu@intel.com>
@ 2020-05-15  2:35 ` Marvin Liu
  2020-05-15  2:46   ` Wang, Xiao W
                     ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Marvin Liu @ 2020-05-15  2:35 UTC (permalink / raw)
  To: maxime.coquelin, xiaolong.ye, zhihong.wang, xiao.w.wang
  Cc: dev, Marvin Liu, stable

Event notification should be disabled after virtqueue initialization and
enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user
device reconnecting to vhost, virtqueue_disable_intr should be called to
disable event notification.

Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
Cc: stable@dpdk.org

Signed-off-by: Marvin Liu <yong.liu@intel.com>
---
v2: commit log update and cc stable

diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
index 0b4e3bf3e..02c8b9fc5 100644
--- a/drivers/net/virtio/virtqueue.c
+++ b/drivers/net/virtio/virtqueue.c
@@ -174,6 +174,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq)
 
 	vring_desc_init_packed(vq, size);
 
+	virtqueue_disable_intr(vq);
 	return 0;
 }
 
@@ -210,5 +211,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
 
 	vring_desc_init_packed(vq, size);
 
+	virtqueue_disable_intr(vq);
 	return 0;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect
  2020-05-15  2:35 ` [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect Marvin Liu
@ 2020-05-15  2:46   ` Wang, Xiao W
  2020-05-15  7:51   ` Maxime Coquelin
  2020-05-15  8:37   ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Wang, Xiao W @ 2020-05-15  2:46 UTC (permalink / raw)
  To: Liu, Yong, maxime.coquelin, Ye, Xiaolong, Wang, Zhihong; +Cc: dev, stable

Hi,

Best Regards,
Xiao

> -----Original Message-----
> From: Liu, Yong <yong.liu@intel.com>
> Sent: Friday, May 15, 2020 10:35 AM
> To: maxime.coquelin@redhat.com; Ye, Xiaolong <xiaolong.ye@intel.com>;
> Wang, Zhihong <zhihong.wang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; Liu, Yong <yong.liu@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/virtio: fix unexpected event after reconnect
> 
> Event notification should be disabled after virtqueue initialization and
> enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user
> device reconnecting to vhost, virtqueue_disable_intr should be called to
> disable event notification.
> 
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> ---
> v2: commit log update and cc stable
> 
> diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
> index 0b4e3bf3e..02c8b9fc5 100644
> --- a/drivers/net/virtio/virtqueue.c
> +++ b/drivers/net/virtio/virtqueue.c
> @@ -174,6 +174,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq)
> 
>  	vring_desc_init_packed(vq, size);
> 
> +	virtqueue_disable_intr(vq);
>  	return 0;
>  }
> 
> @@ -210,5 +211,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
> 
>  	vring_desc_init_packed(vq, size);
> 
> +	virtqueue_disable_intr(vq);
>  	return 0;
>  }
> --
> 2.17.1

Acked-by: Xiao Wang <xiao.w.wang@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect
  2020-05-15  2:35 ` [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect Marvin Liu
  2020-05-15  2:46   ` Wang, Xiao W
@ 2020-05-15  7:51   ` Maxime Coquelin
  2020-05-15  8:37   ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-05-15  7:51 UTC (permalink / raw)
  To: Marvin Liu, xiaolong.ye, zhihong.wang, xiao.w.wang; +Cc: dev, stable



On 5/15/20 4:35 AM, Marvin Liu wrote:
> Event notification should be disabled after virtqueue initialization and
> enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user
> device reconnecting to vhost, virtqueue_disable_intr should be called to
> disable event notification.
> 
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect
  2020-05-15  2:35 ` [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect Marvin Liu
  2020-05-15  2:46   ` Wang, Xiao W
  2020-05-15  7:51   ` Maxime Coquelin
@ 2020-05-15  8:37   ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-05-15  8:37 UTC (permalink / raw)
  To: Marvin Liu, xiaolong.ye, zhihong.wang, xiao.w.wang; +Cc: dev, stable



On 5/15/20 4:35 AM, Marvin Liu wrote:
> Event notification should be disabled after virtqueue initialization and
> enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user
> device reconnecting to vhost, virtqueue_disable_intr should be called to
> disable event notification.
> 
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> ---
> v2: commit log update and cc stable

Applied to dpdk-next-virtio/master.

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-15  8:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200515014056.44949-1-yong.liu@intel.com>
2020-05-15  2:35 ` [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect Marvin Liu
2020-05-15  2:46   ` Wang, Xiao W
2020-05-15  7:51   ` Maxime Coquelin
2020-05-15  8:37   ` Maxime Coquelin

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git