From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Mohsin Kazmi <mohsin.kazmi14@gmail.com>, <dev@dpdk.org>,
"Konstantin Ananyev" <konstantin.ananyev@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: <stable@dpdk.org>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
"Shai Brandes" <shaibran@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
"Igor Chauskin" <igorch@amazon.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 hdr for checksum
Date: Wed, 15 Sep 2021 11:39:24 +0100 [thread overview]
Message-ID: <c790f00c-3efc-ba0d-3e1f-a0a89593f49e@intel.com> (raw)
In-Reply-To: <20210907104916.27560-1-mohsin.kazmi14@gmail.com>
On 9/7/2021 11:49 AM, Mohsin Kazmi wrote:
> Preparation of the headers for the hardware offload
> misses the outer IPv4 checksum offload.
> It results in bad checksum computed by hardware NIC.
>
> This patch fixes the issue by setting the outer IPv4
> checksum field to 0.
>
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
<...>
> diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h
> index 434435ffa2..42639bc154 100644
> --- a/lib/net/rte_net.h
> +++ b/lib/net/rte_net.h
> @@ -125,11 +125,22 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)
Not directly related with this patch, but is the function
'rte_net_intel_cksum_flags_prepare()' really Intel specific?
I can see sfc & ena are also using this function, should we rename it?
next prev parent reply other threads:[~2021-09-15 10:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 11:04 [dpdk-stable] [PATCH v2] net: prepare the outer ipv4 " Mohsin Kazmi
2021-06-30 14:09 ` Olivier Matz
2021-07-07 9:14 ` Mohsin Kazmi
2021-07-22 19:53 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-08-03 12:29 ` Mohsin Kazmi
2021-07-07 9:40 ` [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare " Mohsin Kazmi
2021-07-22 19:56 ` Thomas Monjalon
2021-07-27 12:52 ` Olivier Matz
2021-07-28 15:46 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-30 11:11 ` Olivier Matz
2021-07-31 12:49 ` Andrew Rybchenko
2021-08-03 12:49 ` Mohsin Kazmi
2021-08-27 13:44 ` Mohsin Kazmi
2021-09-07 10:49 ` [dpdk-stable] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 " Mohsin Kazmi
2021-09-15 10:39 ` Ferruh Yigit [this message]
2021-09-15 11:04 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c790f00c-3efc-ba0d-3e1f-a0a89593f49e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=igorch@amazon.com \
--cc=konstantin.ananyev@intel.com \
--cc=mk@semihalf.com \
--cc=mohsin.kazmi14@gmail.com \
--cc=mw@semihalf.com \
--cc=olivier.matz@6wind.com \
--cc=shaibran@amazon.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).