From: =?gb18030?B?IFNoYW9XZWkgU3Vu?= <1819846787@qq.com>
To: =?gb18030?B?RGF2aWQgTWFyY2hhbmQ=?= <david.marchand@redhat.com>,
=?gb18030?B?Y2lhcmEucG93ZXI=?= <ciara.power@intel.com>
Cc: =?gb18030?B?ZGV2?= <dev@dpdk.org>,
=?gb18030?B?QnJ1Y2UgUmljaGFyZHNvbg==?=
<bruce.richardson@intel.com>,
=?gb18030?B?Q2hlbmd3ZW4gRmVuZw==?= <fengchengwen@huawei.com>
Subject: =?gb18030?B?u9i4tKO6IFtQQVRDSF0gW3YzXWxpYi90ZWxlbWV0cnk6Zml4IHRlbGVtZXRyeSBjb25ucyBsZWFrIGluIGNhc2Ugb2Ygc29ja2V0IHdyaXRlIGZhaWw=?=
Date: Thu, 1 Feb 2024 22:11:20 +0800 [thread overview]
Message-ID: <tencent_45F0E986B8237595E204EAEDD41C09646409@qq.com> (raw)
In-Reply-To: <CAJFAV8xSFh=fO7GtaLJv0ZpT0enzCFOEEzpUYUVhgpWtt8N8HA@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1738 bytes --]
Yes, you are correct, it should be the commit 2a7d0b872f79 that introduced the issue. Thank you for the correction.
1819846787@qq.com
------------------ ÔʼÓʼþ ------------------
·¢¼þÈË: "David Marchand"<david.marchand@redhat.com>;
·¢ËÍʱ¼ä: 2024Äê2ÔÂ1ÈÕ(ÐÇÆÚËÄ) ÍíÉÏ9:14
ÊÕ¼þÈË: " ShaoWei Sun"<1819846787@qq.com>; "ciara.power"<ciara.power@intel.com>;
³ËÍ: "dev"<dev@dpdk.org>; "Bruce Richardson"<bruce.richardson@intel.com>; "Chengwen Feng"<fengchengwen@huawei.com>;
Ö÷Ìâ: Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail
1819846787@qq.com> wrote:
>
> Telemetry can only create 10 conns by default, each of which is processed
> by a thread.
>
> When a thread fails to write using socket, the thread will end directly
> without reducing the total number of conns.
>
> This will result in the machine running for a long time, and if there are
> 10 failures, the telemetry will be unavailable
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
>
> Signed-off-by: Shaowei Sun <1819846787@qq.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Thanks for the fix.
As far as I can see, the limiting of the number of connections (which
here results in a DoS on the telemetry socket) was added in commit
2a7d0b872f79 ("telemetry: add upper limit on connections").
If you confirm this is indeed this commit that introduced the issue, I
will fix the Fixes: tag myself when applying.
--
David Marchand
[-- Attachment #2: Type: text/html, Size: 4599 bytes --]
next prev parent reply other threads:[~2024-02-01 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 11:40 [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail sunshaowei01
2024-01-19 11:54 ` Bruce Richardson
2024-01-19 15:42 ` Power, Ciara
2024-01-19 15:54 ` David Marchand
2024-01-20 4:18 ` =?gb18030?B?u9i4tKO6IFtQQVRDSF0gbGliL3RlbGVtZXRyeTpmaXggdGVsZW1ldHJ5IGNvbm5zIGxlYWsgaW4gY2FzZSBvZiBzb2NrZXQgd3JpdGUgZmFpbA==?= =?gb18030?B?MTgxOTg0Njc4Nw==?=
2024-01-22 9:05 ` 回复： [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail Bruce Richardson
2024-01-20 8:58 ` [PATCH] [v2]lib/telemetry:fix " Shaowei Sun
2024-01-22 7:39 ` fengchengwen
2024-01-30 1:57 ` [PATCH] [v3]lib/telemetry:fix " Shaowei Sun
2024-02-01 13:14 ` David Marchand
2024-02-01 14:11 ` =?gb18030?B?IFNoYW9XZWkgU3Vu?= [this message]
2024-02-01 15:19 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_45F0E986B8237595E204EAEDD41C09646409@qq.com \
--to=1819846787@qq.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).