* [dpdk-test-report] |WARNING| pw59528 [PATCH v2 21/22] net/hns3: add reset related process for hns3 PMD driver
[not found] <1568985955-13548-22-git-send-email-xavier.huwei@huawei.com>
@ 2019-09-20 13:33 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-09-20 13:33 UTC (permalink / raw)
To: test-report; +Cc: Wei Hu (Xavier)
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59528
_coding style issues_
CHECK:BRACES: braces {} should be used on all arms of this statement
#198: FILE: drivers/net/hns3/hns3_ethdev.c:215:
+ if (event_cause == HNS3_VECTOR0_EVENT_ERR) {
[...]
+ } else if (event_cause == HNS3_VECTOR0_EVENT_RST)
[...]
+ else
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#295: FILE: drivers/net/hns3/hns3_ethdev.c:3778:
+ if (!hns3_is_reset_pending(hns)) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#298: FILE: drivers/net/hns3/hns3_ethdev.c:3781:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#319: FILE: drivers/net/hns3/hns3_ethdev.c:4048:
+ if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#322: FILE: drivers/net/hns3/hns3_ethdev.c:4051:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#467: FILE: drivers/net/hns3/hns3_ethdev.c:4388:
+ if (wait_data->result == HNS3_WAIT_SUCCESS)
[...]
+ else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
[...]
+ } else if (wait_data->result == HNS3_WAIT_REQUEST)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#634: FILE: drivers/net/hns3/hns3_ethdev.c:4555:
+ if (hns->hw.adapter_state == HNS3_NIC_STARTED ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#638: FILE: drivers/net/hns3/hns3_ethdev.c:4559:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#698: FILE: drivers/net/hns3/hns3_ethdev.c:4619:
+ if (hns->hw.adapter_state == HNS3_NIC_STARTED) {
[...]
+ } else if (hw->adapter_state == HNS3_NIC_STOPPING)
[...]
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#757: FILE: drivers/net/hns3/hns3_ethdev.c:4678:
+ hns3_err(hw, "%d handle long time delta %" PRIx64
CHECK:BRACES: braces {} should be used on all arms of this statement
#1055: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1132:
+ if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1058: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1135:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1156: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1306:
+ if (wait_data->result == HNS3_WAIT_SUCCESS)
[...]
+ else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
[...]
+ } else if (wait_data->result == HNS3_WAIT_REQUEST)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1205: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1355:
+ if (hw->adapter_state == HNS3_NIC_STARTED ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1209: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1359:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1259: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1409:
+ if (hw->adapter_state == HNS3_NIC_STARTED) {
[...]
+ } else if (hw->adapter_state == HNS3_NIC_STOPPING)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1522: FILE: drivers/net/hns3/hns3_intr.c:732:
+ if (data->check_completion) {
[...]
+ } else
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1528: FILE: drivers/net/hns3/hns3_intr.c:738:
+ if (msec > data->end_ms || is_reset_pending(hns) ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1532: FILE: drivers/net/hns3/hns3_intr.c:742:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#1534: FILE: drivers/net/hns3/hns3_intr.c:744:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1541: FILE: drivers/net/hns3/hns3_intr.c:751:
+ if (done)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1543: FILE: drivers/net/hns3/hns3_intr.c:753:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#1570: FILE: drivers/net/hns3/hns3_intr.c:780:
+ if (hw->reset.wait_data->result == HNS3_WAIT_UNKNOWN) {
[...]
+ } else if (hw->reset.wait_data->result == HNS3_WAIT_REQUEST)
[...]
total: 0 errors, 0 warnings, 23 checks, 1936 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-20 13:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1568985955-13548-22-git-send-email-xavier.huwei@huawei.com>
2019-09-20 13:33 ` [dpdk-test-report] |WARNING| pw59528 [PATCH v2 21/22] net/hns3: add reset related process for hns3 PMD driver checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).