* [dpdk-test-report] |WARNING| pw69975 [PATCH v2 2/2] net/e1000: fix defects of macro in VF
[not found] <20200508044618.70535-3-guinanx.sun@intel.com>
@ 2020-05-08 5:00 ` checkpatch
2020-05-08 10:13 ` [dpdk-test-report] |SUCCESS| pw69975 " 0-day Robot
1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2020-05-08 5:00 UTC (permalink / raw)
To: test-report; +Cc: Guinan Sun
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69975
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects?
#96: FILE: drivers/net/e1000/igb_ethdev.c:266:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ uint64_t latest = E1000_READ_REG(hw, reg); \
+ uint64_t stat = 0; \
+ if (latest >= last) \
+ stat = latest - last; \
+ else \
+ stat = (uint64_t)((latest + \
+ ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\
+ cur += stat & IGB_32_BIT_MASK; \
+ last = latest; \
}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues
#96: FILE: drivers/net/e1000/igb_ethdev.c:266:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ uint64_t latest = E1000_READ_REG(hw, reg); \
+ uint64_t stat = 0; \
+ if (latest >= last) \
+ stat = latest - last; \
+ else \
+ stat = (uint64_t)((latest + \
+ ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\
+ cur += stat & IGB_32_BIT_MASK; \
+ last = latest; \
}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues
#96: FILE: drivers/net/e1000/igb_ethdev.c:266:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ uint64_t latest = E1000_READ_REG(hw, reg); \
+ uint64_t stat = 0; \
+ if (latest >= last) \
+ stat = latest - last; \
+ else \
+ stat = (uint64_t)((latest + \
+ ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\
+ cur += stat & IGB_32_BIT_MASK; \
+ last = latest; \
}
total: 0 errors, 0 warnings, 3 checks, 30 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-test-report] |SUCCESS| pw69975 net/e1000: fix defects of macro in VF
[not found] <20200508044618.70535-3-guinanx.sun@intel.com>
2020-05-08 5:00 ` [dpdk-test-report] |WARNING| pw69975 [PATCH v2 2/2] net/e1000: fix defects of macro in VF checkpatch
@ 2020-05-08 10:13 ` 0-day Robot
1 sibling, 0 replies; 2+ messages in thread
From: 0-day Robot @ 2020-05-08 10:13 UTC (permalink / raw)
To: test-report; +Cc: robot
From: robot@bytheb.org
Test-Label: travis-robot
Test-Status: SUCCESS
http://dpdk.org/patch/69975
_Travis build: passed_
Build URL: https://travis-ci.com/ovsrobot/dpdk/builds/164621079
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-08 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200508044618.70535-3-guinanx.sun@intel.com>
2020-05-08 5:00 ` [dpdk-test-report] |WARNING| pw69975 [PATCH v2 2/2] net/e1000: fix defects of macro in VF checkpatch
2020-05-08 10:13 ` [dpdk-test-report] |SUCCESS| pw69975 " 0-day Robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).