automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw85738 [PATCH] mlx5: split multi-threaded flows per OS
       [not found] <20201226165714.4416-1-talshn@nvidia.com>
@ 2020-12-26 16:58 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-12-26 16:58 UTC (permalink / raw)
  To: test-report; +Cc: Tal Shnaiderman

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85738

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#101: FILE: drivers/net/mlx5/linux/mlx5_flow_os.c:17:
+		return ENOMEM;

CHECK:CAMELCASE: Avoid CamelCase: <WaitForSingleObject>
#286: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:261:
+	DWORD result = WaitForSingleObject(thread_handle, 0);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#288: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:263:
+	if (result == WAIT_OBJECT_0) {
+		return false;
+	}

CHECK:CAMELCASE: Avoid CamelCase: <DuplicateHandle>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+	BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),

CHECK:CAMELCASE: Avoid CamelCase: <GetCurrentProcess>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+	BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),

CHECK:CAMELCASE: Avoid CamelCase: <GetCurrentThread>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+	BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),

CHECK:CAMELCASE: Avoid CamelCase: <CloseHandle>
#333: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:308:
+			CloseHandle(temp->thread_handle);

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#384: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:359:
+		first = curr = temp;

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#386: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:361:
+	}
+	else {

CHECK:BRACES: Unbalanced braces around else statement
#386: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:361:
+	else {

total: 1 errors, 2 warnings, 7 checks, 333 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-26 16:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201226165714.4416-1-talshn@nvidia.com>
2020-12-26 16:58 ` [dpdk-test-report] |WARNING| pw85738 [PATCH] mlx5: split multi-threaded flows per OS checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).