automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw93932 [PATCH v9 06/10] eal: add thread lifetime management
       [not found] <1622850274-6946-7-git-send-email-navasile@linux.microsoft.com>
@ 2021-06-04 23:46 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-06-04 23:46 UTC (permalink / raw)
  To: test-report; +Cc: Narcisa Ana Maria Vasile

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93932

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#60: 
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#172: FILE: lib/eal/common/rte_thread.c:235:
+	void **pres = NULL;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#175: FILE: lib/eal/common/rte_thread.c:238:
+		pres = &res;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#177: FILE: lib/eal/common/rte_thread.c:240:
+	ret = pthread_join(thread_id.opaque_id, pres);

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#183: FILE: lib/eal/common/rte_thread.c:246:
+	if (pres != NULL)

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#184: FILE: lib/eal/common/rte_thread.c:247:
+		*value_ptr = *(int *)(*pres);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#295: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:SPACING: Unnecessary space before function pointer arguments
#295: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void*' should also have an identifier name
#295: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#352: FILE: lib/eal/windows/rte_thread.c:400:
+			ret = rte_convert_cpuset_to_affinity(&thread_attr->cpuset, &thread_affinity);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#460: FILE: lib/eal/windows/rte_thread.c:508:
+	return ENOTSUP;

total: 1 errors, 10 warnings, 369 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-04 23:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1622850274-6946-7-git-send-email-navasile@linux.microsoft.com>
2021-06-04 23:46 ` [dpdk-test-report] |WARNING| pw93932 [PATCH v9 06/10] eal: add thread lifetime management checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).