* |WARNING| pw108316 [PATCH v2 2/2] net/cnxk: align perfetchs to CN10K cache model
[not found] <20220224161013.4566-2-pbhagavatula@marvell.com>
@ 2022-02-24 16:10 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-02-24 16:10 UTC (permalink / raw)
To: test-report; +Cc: pbhagavatula
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108316
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#154: FILE: drivers/net/cnxk/cn10k_rx.h:39:
+#define CQE_PTR_DIFF(b, i, o, f) \
+ (((f) & NIX_RX_VWQE_F) ? \
+ (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) : \
+ (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#154: FILE: drivers/net/cnxk/cn10k_rx.h:39:
+#define CQE_PTR_DIFF(b, i, o, f) \
+ (((f) & NIX_RX_VWQE_F) ? \
+ (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) : \
+ (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'o' - possible side-effects?
#154: FILE: drivers/net/cnxk/cn10k_rx.h:39:
+#define CQE_PTR_DIFF(b, i, o, f) \
+ (((f) & NIX_RX_VWQE_F) ? \
+ (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) : \
+ (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o)))
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#160: FILE: drivers/net/cnxk/cn10k_rx.h:45:
+#define NIX_MBUF_VALIDATE_NEXT(m) \
+ if (m->nb_segs == 1 && mbuf->next) { \
+ rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d", \
+ m->next, m->nb_segs); \
+ }
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects?
#160: FILE: drivers/net/cnxk/cn10k_rx.h:45:
+#define NIX_MBUF_VALIDATE_NEXT(m) \
+ if (m->nb_segs == 1 && mbuf->next) { \
+ rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d", \
+ m->next, m->nb_segs); \
+ }
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'm' may be better as '(m)' to avoid precedence issues
#160: FILE: drivers/net/cnxk/cn10k_rx.h:45:
+#define NIX_MBUF_VALIDATE_NEXT(m) \
+ if (m->nb_segs == 1 && mbuf->next) { \
+ rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d", \
+ m->next, m->nb_segs); \
+ }
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#190: FILE: drivers/net/cnxk/cn10k_rx.h:695:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#192: FILE: drivers/net/cnxk/cn10k_rx.h:697:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#194: FILE: drivers/net/cnxk/cn10k_rx.h:699:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#196: FILE: drivers/net/cnxk/cn10k_rx.h:701:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#200: FILE: drivers/net/cnxk/cn10k_rx.h:705:
+ rte_prefetch1(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#202: FILE: drivers/net/cnxk/cn10k_rx.h:707:
+ rte_prefetch1(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#204: FILE: drivers/net/cnxk/cn10k_rx.h:709:
+ rte_prefetch1(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#206: FILE: drivers/net/cnxk/cn10k_rx.h:711:
+ rte_prefetch1(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#209: FILE: drivers/net/cnxk/cn10k_rx.h:714:
+ rte_prefetch1(CQE_PTR_OFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#211: FILE: drivers/net/cnxk/cn10k_rx.h:716:
+ rte_prefetch1(CQE_PTR_OFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#213: FILE: drivers/net/cnxk/cn10k_rx.h:718:
+ rte_prefetch1(CQE_PTR_OFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#215: FILE: drivers/net/cnxk/cn10k_rx.h:720:
+ rte_prefetch1(CQE_PTR_OFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#220: FILE: drivers/net/cnxk/cn10k_rx.h:725:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#222: FILE: drivers/net/cnxk/cn10k_rx.h:727:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#224: FILE: drivers/net/cnxk/cn10k_rx.h:729:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#226: FILE: drivers/net/cnxk/cn10k_rx.h:731:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#229: FILE: drivers/net/cnxk/cn10k_rx.h:734:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#232: FILE: drivers/net/cnxk/cn10k_rx.h:737:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#235: FILE: drivers/net/cnxk/cn10k_rx.h:740:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#238: FILE: drivers/net/cnxk/cn10k_rx.h:743:
+ rte_prefetch0(CQE_PTR_DIFF(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#245: FILE: drivers/net/cnxk/cn10k_rx.h:750:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#247: FILE: drivers/net/cnxk/cn10k_rx.h:752:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#249: FILE: drivers/net/cnxk/cn10k_rx.h:754:
+ rte_prefetch_non_temporal(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#251: FILE: drivers/net/cnxk/cn10k_rx.h:756:
+ rte_prefetch_non_temporal(
total: 1 errors, 0 warnings, 29 checks, 191 lines checked
Warning in drivers/net/cnxk/cn10k_rx.h:
Using rte_panic/rte_exit
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-24 16:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220224161013.4566-2-pbhagavatula@marvell.com>
2022-02-24 16:10 ` |WARNING| pw108316 [PATCH v2 2/2] net/cnxk: align perfetchs to CN10K cache model checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).