|WARNING| pw108876 [PATCH] net/tap: Fixed RSS algorithm to support fragmented packets

|WARNING| pw108876 [PATCH] net/tap: Fixed RSS algorithm to support fragmented packets

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108876

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#81: 
As per analysis on DPDK Tap PMD, the existing RSS algorithm considering 4-tuple(Src-IP, Dst-IP, Src-port and Dst-port) and identification of fragment packets is not done, thus we are seeing all the fragmented chunks of single packet differs RSS hash value and distributed across multiple queues.

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mf == 0'
#3526: FILE: drivers/net/tap/tap_bpf_program.c:186:
+			if ((mf == 0) && (frag_off == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frag_off == 0'
#3526: FILE: drivers/net/tap/tap_bpf_program.c:186:
+			if ((mf == 0) && (frag_off == 0)) {

WARNING:TYPO_SPELLING: 'heaer' may be misspelled - perhaps 'header'?
#3555: FILE: drivers/net/tap/tap_bpf_program.c:218:
+		/** Fetch the L4 header port-numbers only if next-heaer 

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3555: FILE: drivers/net/tap/tap_bpf_program.c:218:
+^I^I/** Fetch the L4 header port-numbers only if next-heaer $

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3563: FILE: drivers/net/tap/tap_bpf_program.c:226:
+		}
+		else {

CHECK:BRACES: Unbalanced braces around else statement
#3563: FILE: drivers/net/tap/tap_bpf_program.c:226:
+		else {

total: 2 errors, 2 warnings, 3 checks, 3460 lines checked

|SUCCESS| pw108876 [PATCH] net/tap: Fixed RSS algorithm to support fragmented packets

[0-day Robot]

From: robot@bytheb.org

Test-Label: github-robot: build
Test-Status: SUCCESS
http://patchwork.dpdk.org/patch/108876/

_github build: passed_
Build URL: https://github.com/ovsrobot/dpdk/actions/runs/2040851261