* |WARNING| pw119265 [PATCH] Add support for IBM Z s390x
[not found] <20221028215240.103365-1-dmiller423@gmail.com>
@ 2022-10-28 21:54 ` checkpatch
0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2022-10-28 21:54 UTC (permalink / raw)
To: test-report; +Cc: David Miller
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119265
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: app/test-pmd/config.c:248:
+ __uint128_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: app/test-pmd/config.c:249:
+ diff_ns;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: app/test-pmd/config.c:249:
+ diff_ns;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: app/test-pmd/config.c:250:
+ __uint128_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#218: FILE: app/test-pmd/config.c:305:
+ printf(" Rx-pps: %12llu Rx-bps: %12llu
Tx-pps: %12llu Tx-bps: %12llu
",$
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#218: FILE: app/test-pmd/config.c:305:
+ printf(" Rx-pps: %12llu Rx-bps: %12llu
Tx-pps: %12llu Tx-bps: %12llu
",
ERROR:CODE_INDENT: code indent should use tabs where possible
#219: FILE: app/test-pmd/config.c:306:
+ (unsigned long long) mpps_rx, (unsigned long long) mbps_rx * 8,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#219: FILE: app/test-pmd/config.c:306:
+ (unsigned long long) mpps_rx, (unsigned long long) mbps_rx * 8,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#220: FILE: app/test-pmd/config.c:307:
+ (unsigned long long) mpps_tx, (unsigned long long) mbps_tx * 8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: app/test-pmd/config.c:307:
+ (unsigned long long) mpps_tx, (unsigned long long) mbps_tx * 8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#232: FILE: app/test/test_acl.c:354:
+ RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#232: FILE: app/test/test_acl.c:354:
+ RTE_ACL_CLASSIFY_S390X,$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#335: FILE: app/test/test_cmdline_ipaddr.c:25:
+#define IP4(a,b,c,d) {((uint32_t)(((a) & 0xff) << 24) | \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#335: FILE: app/test/test_cmdline_ipaddr.c:25:
+#define IP4(a,b,c,d) {((uint32_t)(((a) & 0xff) << 24) | \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#335: FILE: app/test/test_cmdline_ipaddr.c:25:
+#define IP4(a,b,c,d) {((uint32_t)(((a) & 0xff) << 24) | \
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#363: FILE: app/test/test_cmdline_num.c:443:
+ switch (type) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#363: FILE: app/test/test_cmdline_num.c:443:
+ switch (type) {$
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#363: FILE: app/test/test_cmdline_num.c:443:
+ switch (type) {
+ case RTE_UINT8:
[...]
+ case RTE_UINT16:
[...]
+ case RTE_UINT32:
[...]
+ case RTE_INT8:
[...]
+ case RTE_INT16:
[...]
+ case RTE_INT32:
[...]
+ default:
ERROR:CODE_INDENT: code indent should use tabs where possible
#364: FILE: app/test/test_cmdline_num.c:444:
+ case RTE_UINT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#364: FILE: app/test/test_cmdline_num.c:444:
+ case RTE_UINT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#365: FILE: app/test/test_cmdline_num.c:445:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#365: FILE: app/test/test_cmdline_num.c:445:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#366: FILE: app/test/test_cmdline_num.c:446:
+ uint8_t *temp = (uint8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#366: FILE: app/test/test_cmdline_num.c:446:
+ uint8_t *temp = (uint8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#367: FILE: app/test/test_cmdline_num.c:447:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#367: FILE: app/test/test_cmdline_num.c:447:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#368: FILE: app/test/test_cmdline_num.c:448:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#368: FILE: app/test/test_cmdline_num.c:448:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: app/test/test_cmdline_num.c:449:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: app/test/test_cmdline_num.c:449:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#370: FILE: app/test/test_cmdline_num.c:450:
+ case RTE_UINT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#370: FILE: app/test/test_cmdline_num.c:450:
+ case RTE_UINT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#371: FILE: app/test/test_cmdline_num.c:451:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#371: FILE: app/test/test_cmdline_num.c:451:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#372: FILE: app/test/test_cmdline_num.c:452:
+ uint16_t *temp = (uint16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#372: FILE: app/test/test_cmdline_num.c:452:
+ uint16_t *temp = (uint16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#373: FILE: app/test/test_cmdline_num.c:453:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#373: FILE: app/test/test_cmdline_num.c:453:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#374: FILE: app/test/test_cmdline_num.c:454:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#374: FILE: app/test/test_cmdline_num.c:454:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#375: FILE: app/test/test_cmdline_num.c:455:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#375: FILE: app/test/test_cmdline_num.c:455:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#376: FILE: app/test/test_cmdline_num.c:456:
+ case RTE_UINT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#376: FILE: app/test/test_cmdline_num.c:456:
+ case RTE_UINT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#377: FILE: app/test/test_cmdline_num.c:457:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#377: FILE: app/test/test_cmdline_num.c:457:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#378: FILE: app/test/test_cmdline_num.c:458:
+ uint32_t *temp = (uint32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#378: FILE: app/test/test_cmdline_num.c:458:
+ uint32_t *temp = (uint32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#379: FILE: app/test/test_cmdline_num.c:459:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#379: FILE: app/test/test_cmdline_num.c:459:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#380: FILE: app/test/test_cmdline_num.c:460:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#380: FILE: app/test/test_cmdline_num.c:460:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#381: FILE: app/test/test_cmdline_num.c:461:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#381: FILE: app/test/test_cmdline_num.c:461:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#382: FILE: app/test/test_cmdline_num.c:462:
+ case RTE_INT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#382: FILE: app/test/test_cmdline_num.c:462:
+ case RTE_INT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#383: FILE: app/test/test_cmdline_num.c:463:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#383: FILE: app/test/test_cmdline_num.c:463:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#384: FILE: app/test/test_cmdline_num.c:464:
+ int8_t *temp = (int8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#384: FILE: app/test/test_cmdline_num.c:464:
+ int8_t *temp = (int8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#385: FILE: app/test/test_cmdline_num.c:465:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#385: FILE: app/test/test_cmdline_num.c:465:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#386: FILE: app/test/test_cmdline_num.c:466:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#386: FILE: app/test/test_cmdline_num.c:466:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#387: FILE: app/test/test_cmdline_num.c:467:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#387: FILE: app/test/test_cmdline_num.c:467:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#388: FILE: app/test/test_cmdline_num.c:468:
+ case RTE_INT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#388: FILE: app/test/test_cmdline_num.c:468:
+ case RTE_INT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#389: FILE: app/test/test_cmdline_num.c:469:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#389: FILE: app/test/test_cmdline_num.c:469:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#390: FILE: app/test/test_cmdline_num.c:470:
+ int16_t *temp = (int16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#390: FILE: app/test/test_cmdline_num.c:470:
+ int16_t *temp = (int16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#391: FILE: app/test/test_cmdline_num.c:471:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#391: FILE: app/test/test_cmdline_num.c:471:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#392: FILE: app/test/test_cmdline_num.c:472:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#392: FILE: app/test/test_cmdline_num.c:472:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#393: FILE: app/test/test_cmdline_num.c:473:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#393: FILE: app/test/test_cmdline_num.c:473:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#394: FILE: app/test/test_cmdline_num.c:474:
+ case RTE_INT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#394: FILE: app/test/test_cmdline_num.c:474:
+ case RTE_INT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#395: FILE: app/test/test_cmdline_num.c:475:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#395: FILE: app/test/test_cmdline_num.c:475:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#396: FILE: app/test/test_cmdline_num.c:476:
+ int32_t *temp = (int32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#396: FILE: app/test/test_cmdline_num.c:476:
+ int32_t *temp = (int32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#397: FILE: app/test/test_cmdline_num.c:477:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#397: FILE: app/test/test_cmdline_num.c:477:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#398: FILE: app/test/test_cmdline_num.c:478:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#398: FILE: app/test/test_cmdline_num.c:478:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#399: FILE: app/test/test_cmdline_num.c:479:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: app/test/test_cmdline_num.c:479:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#400: FILE: app/test/test_cmdline_num.c:480:
+ default:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#401: FILE: app/test/test_cmdline_num.c:481:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#401: FILE: app/test/test_cmdline_num.c:481:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#402: FILE: app/test/test_cmdline_num.c:482:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#402: FILE: app/test/test_cmdline_num.c:482:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#420: FILE: app/test/test_cmdline_num.c:528:
+ switch (type) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#420: FILE: app/test/test_cmdline_num.c:528:
+ switch (type) {$
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#420: FILE: app/test/test_cmdline_num.c:528:
+ switch (type) {
+ case RTE_INT8:
[...]
+ case RTE_INT16:
[...]
+ case RTE_INT32:
[...]
+ default:
ERROR:CODE_INDENT: code indent should use tabs where possible
#451: FILE: app/test/test_cmdline_num.c:588:
+ switch (type) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#451: FILE: app/test/test_cmdline_num.c:588:
+ switch (type) {$
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#451: FILE: app/test/test_cmdline_num.c:588:
+ switch (type) {
+ case RTE_UINT8:
[...]
+ case RTE_UINT16:
[...]
+ case RTE_UINT32:
[...]
+ case RTE_INT8:
[...]
+ case RTE_INT16:
[...]
+ case RTE_INT32:
[...]
+ default:
ERROR:CODE_INDENT: code indent should use tabs where possible
#452: FILE: app/test/test_cmdline_num.c:589:
+ case RTE_UINT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#452: FILE: app/test/test_cmdline_num.c:589:
+ case RTE_UINT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#453: FILE: app/test/test_cmdline_num.c:590:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#453: FILE: app/test/test_cmdline_num.c:590:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#454: FILE: app/test/test_cmdline_num.c:591:
+ uint8_t *temp = (uint8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#454: FILE: app/test/test_cmdline_num.c:591:
+ uint8_t *temp = (uint8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#455: FILE: app/test/test_cmdline_num.c:592:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#455: FILE: app/test/test_cmdline_num.c:592:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#456: FILE: app/test/test_cmdline_num.c:593:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#456: FILE: app/test/test_cmdline_num.c:593:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#457: FILE: app/test/test_cmdline_num.c:594:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#457: FILE: app/test/test_cmdline_num.c:594:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#458: FILE: app/test/test_cmdline_num.c:595:
+ case RTE_UINT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#458: FILE: app/test/test_cmdline_num.c:595:
+ case RTE_UINT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#459: FILE: app/test/test_cmdline_num.c:596:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#459: FILE: app/test/test_cmdline_num.c:596:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#460: FILE: app/test/test_cmdline_num.c:597:
+ uint16_t *temp = (uint16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#460: FILE: app/test/test_cmdline_num.c:597:
+ uint16_t *temp = (uint16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#461: FILE: app/test/test_cmdline_num.c:598:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#461: FILE: app/test/test_cmdline_num.c:598:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#462: FILE: app/test/test_cmdline_num.c:599:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#462: FILE: app/test/test_cmdline_num.c:599:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#463: FILE: app/test/test_cmdline_num.c:600:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#463: FILE: app/test/test_cmdline_num.c:600:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#464: FILE: app/test/test_cmdline_num.c:601:
+ case RTE_UINT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#464: FILE: app/test/test_cmdline_num.c:601:
+ case RTE_UINT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#465: FILE: app/test/test_cmdline_num.c:602:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#465: FILE: app/test/test_cmdline_num.c:602:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#466: FILE: app/test/test_cmdline_num.c:603:
+ uint32_t *temp = (uint32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#466: FILE: app/test/test_cmdline_num.c:603:
+ uint32_t *temp = (uint32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#467: FILE: app/test/test_cmdline_num.c:604:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#467: FILE: app/test/test_cmdline_num.c:604:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#468: FILE: app/test/test_cmdline_num.c:605:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#468: FILE: app/test/test_cmdline_num.c:605:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#469: FILE: app/test/test_cmdline_num.c:606:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#469: FILE: app/test/test_cmdline_num.c:606:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#470: FILE: app/test/test_cmdline_num.c:607:
+ case RTE_INT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#470: FILE: app/test/test_cmdline_num.c:607:
+ case RTE_INT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#471: FILE: app/test/test_cmdline_num.c:608:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#471: FILE: app/test/test_cmdline_num.c:608:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#472: FILE: app/test/test_cmdline_num.c:609:
+ int8_t *temp = (int8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#472: FILE: app/test/test_cmdline_num.c:609:
+ int8_t *temp = (int8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#473: FILE: app/test/test_cmdline_num.c:610:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#473: FILE: app/test/test_cmdline_num.c:610:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#474: FILE: app/test/test_cmdline_num.c:611:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#474: FILE: app/test/test_cmdline_num.c:611:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#475: FILE: app/test/test_cmdline_num.c:612:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#475: FILE: app/test/test_cmdline_num.c:612:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#476: FILE: app/test/test_cmdline_num.c:613:
+ case RTE_INT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#476: FILE: app/test/test_cmdline_num.c:613:
+ case RTE_INT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#477: FILE: app/test/test_cmdline_num.c:614:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#477: FILE: app/test/test_cmdline_num.c:614:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#478: FILE: app/test/test_cmdline_num.c:615:
+ int16_t *temp = (int16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#478: FILE: app/test/test_cmdline_num.c:615:
+ int16_t *temp = (int16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#479: FILE: app/test/test_cmdline_num.c:616:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#479: FILE: app/test/test_cmdline_num.c:616:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#480: FILE: app/test/test_cmdline_num.c:617:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#480: FILE: app/test/test_cmdline_num.c:617:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#481: FILE: app/test/test_cmdline_num.c:618:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#481: FILE: app/test/test_cmdline_num.c:618:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#482: FILE: app/test/test_cmdline_num.c:619:
+ case RTE_INT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#482: FILE: app/test/test_cmdline_num.c:619:
+ case RTE_INT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#483: FILE: app/test/test_cmdline_num.c:620:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#483: FILE: app/test/test_cmdline_num.c:620:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#484: FILE: app/test/test_cmdline_num.c:621:
+ int32_t *temp = (int32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#484: FILE: app/test/test_cmdline_num.c:621:
+ int32_t *temp = (int32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#485: FILE: app/test/test_cmdline_num.c:622:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#485: FILE: app/test/test_cmdline_num.c:622:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#486: FILE: app/test/test_cmdline_num.c:623:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#486: FILE: app/test/test_cmdline_num.c:623:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#487: FILE: app/test/test_cmdline_num.c:624:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#487: FILE: app/test/test_cmdline_num.c:624:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#488: FILE: app/test/test_cmdline_num.c:625:
+ default:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#489: FILE: app/test/test_cmdline_num.c:626:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#489: FILE: app/test/test_cmdline_num.c:626:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#490: FILE: app/test/test_cmdline_num.c:627:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#490: FILE: app/test/test_cmdline_num.c:627:
+ }$
WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#533: FILE: app/test/test_hash_functions.c:77:
+ 0x37765e57, 0x6559eb17, 0x49c8a164, 0x18daa0d3,
WARNING:TYPO_SPELLING: 'implemenation' may be misspelled - perhaps 'implementation'?
#712: FILE: drivers/common/mlx5/mlx5_common.h:23:
+/* s390x pci implemenation. */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#727: FILE: drivers/common/mlx5/mlx5_common.h:369:
+ rte_write64_relaxed(val, uar->db);$
WARNING:REPEATED_WORD: Possible repeated word: 'count'
#1155: FILE: drivers/net/i40e/i40e_rxtx_vec_s390x.c:418:
+ /* the staterr values are not in order, as the count
+ * count of dd bits doesn't care. However, for end of
WARNING:TYPO_SPELLING: 'avaialbe' may be misspelled - perhaps 'available'?
#1185: FILE: drivers/net/i40e/i40e_rxtx_vec_s390x.c:448:
+ /* C.4 calc avaialbe number of desc */
ERROR:CODE_INDENT: code indent should use tabs where possible
#1416: FILE: drivers/net/mlx5/mlx5_rx.c:213:
+ snprintf(mode->info, sizeof(mode->info), "%s", "Vector S390X");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1416: FILE: drivers/net/mlx5/mlx5_rx.c:213:
+ snprintf(mode->info, sizeof(mode->info), "%s", "Vector S390X");$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1425: FILE: drivers/net/mlx5/mlx5_rx.c:225:
+ snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector S390X");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1425: FILE: drivers/net/mlx5/mlx5_rx.c:225:
+ snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector S390X");$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1439: FILE: drivers/net/mlx5/mlx5_rx.c:326:
+ * to be converted from LE to BE for the logic to work
+ */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1440: FILE: drivers/net/mlx5/mlx5_rx.c:327:
+ uint16_t cqe_t_le = rte_le_to_cpu_16(cqe->hdr_type_etc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1441: FILE: drivers/net/mlx5/mlx5_rx.c:328:
+ uint16_t mcqe_t_le;$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#1450: FILE: drivers/net/mlx5/mlx5_rx.c:334:
+ else {
+ mcqe_t_le = rte_le_to_cpu_16(mcqe->hdr_type);
CHECK:BRACES: Unbalanced braces around else statement
#1450: FILE: drivers/net/mlx5/mlx5_rx.c:334:
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#1451: FILE: drivers/net/mlx5/mlx5_rx.c:335:
+ mcqe_t_le = rte_le_to_cpu_16(mcqe->hdr_type);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1451: FILE: drivers/net/mlx5/mlx5_rx.c:335:
+ mcqe_t_le = rte_le_to_cpu_16(mcqe->hdr_type);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1453: FILE: drivers/net/mlx5/mlx5_rx.c:337:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1482: FILE: examples/l3fwd-acl/main.c:173:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1483: FILE: examples/l3fwd-acl/main.c:174:
+ .name = "s390x",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1483: FILE: examples/l3fwd-acl/main.c:174:
+ .name = "s390x",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1484: FILE: examples/l3fwd-acl/main.c:175:
+ .alg = RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1484: FILE: examples/l3fwd-acl/main.c:175:
+ .alg = RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1485: FILE: examples/l3fwd-acl/main.c:176:
+ }$
ERROR:C99_COMMENTS: do not use C99 // comments
#1667: FILE: examples/l3fwd/l3fwd_s390x.h:11:
+#define vec_sro(a, b) vec_srb(a, (b) << 64) // Vector Shift Right by Octet
WARNING:TYPO_SPELLING: 'signifcant' may be misspelled - perhaps 'significant'?
#1940: FILE: lib/acl/acl_gen.c:365:
+ * is at least signifcant byte.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1996: FILE: lib/acl/rte_acl.c:159:
+ if (alg == RTE_ACL_CLASSIFY_S390X) {$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) $
ERROR:CODE_INDENT: code indent should use tabs where possible
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) $
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
+ return 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#2001: FILE: lib/acl/rte_acl.c:164:
+ return -ENOTSUP;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2001: FILE: lib/acl/rte_acl.c:164:
+ return -ENOTSUP;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2002: FILE: lib/acl/rte_acl.c:165:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2004: FILE: lib/acl/rte_acl.c:167:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2015: FILE: lib/acl/rte_acl.c:242:
+ case RTE_ACL_CLASSIFY_S390X:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2016: FILE: lib/acl/rte_acl.c:243:
+ return acl_check_alg_s390x(alg);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2016: FILE: lib/acl/rte_acl.c:243:
+ return acl_check_alg_s390x(alg);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2025: FILE: lib/acl/rte_acl.c:273:
+ RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2025: FILE: lib/acl/rte_acl.c:273:
+ RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2039: FILE: lib/acl/rte_acl.h:244:
+ RTE_ACL_CLASSIFY_S390X = 6, /**< requires s390x z13 support. */$
ERROR:C99_COMMENTS: do not use C99 // comments
#2090: FILE: lib/eal/s390x/include/rte_atomic.h:18:
+//#define dsb(opt) asm volatile("" : : : "memory")
ERROR:C99_COMMENTS: do not use C99 // comments
#2091: FILE: lib/eal/s390x/include/rte_atomic.h:19:
+//#define dmb(opt) asm volatile("" : : : "memory")
ERROR:C99_COMMENTS: do not use C99 // comments
#2093: FILE: lib/eal/s390x/include/rte_atomic.h:21:
+#define rte_mb() rte_compiler_barrier() //asm volatile("" : : : "memory")
ERROR:C99_COMMENTS: do not use C99 // comments
#2197: FILE: lib/eal/s390x/include/rte_cpuflags.h:23:
+ RTE_CPUFLAG_HPAGE, //from elf.h
ERROR:C99_COMMENTS: do not use C99 // comments
#2198: FILE: lib/eal/s390x/include/rte_cpuflags.h:24:
+ //RTE_CPUFLAG_EDAT, //from hwcap.h
ERROR:CODE_INDENT: code indent should use tabs where possible
#2304: FILE: lib/eal/s390x/include/rte_io.h:32:
+ union register_pair ioaddr_len =$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2304: FILE: lib/eal/s390x/include/rte_io.h:32:
+ union register_pair ioaddr_len =$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2305: FILE: lib/eal/s390x/include/rte_io.h:33:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2305: FILE: lib/eal/s390x/include/rte_io.h:33:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#2305: FILE: lib/eal/s390x/include/rte_io.h:33:
+ union register_pair ioaddr_len =
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};
ERROR:CODE_INDENT: code indent should use tabs where possible
#2320: FILE: lib/eal/s390x/include/rte_io.h:48:
+ union register_pair ioaddr_len =$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2320: FILE: lib/eal/s390x/include/rte_io.h:48:
+ union register_pair ioaddr_len =$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2321: FILE: lib/eal/s390x/include/rte_io.h:49:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2321: FILE: lib/eal/s390x/include/rte_io.h:49:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#2321: FILE: lib/eal/s390x/include/rte_io.h:49:
+ union register_pair ioaddr_len =
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2442: FILE: lib/eal/s390x/include/rte_io.h:170:
+ rte_write32(value, addr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2640: FILE: lib/eal/s390x/include/rte_prefetch.h:39:
+ RTE_SET_USED(p);$
total: 113 errors, 122 warnings, 2795 lines checked
Warning in drivers/net/i40e/i40e_rxtx_vec_s390x.c:
Using compiler attribute directly
Warning in lib/eal/s390x/include/rte_atomic.h:
Using rte_smp_[r/w]mb
Warning in lib/eal/s390x/include/rte_spinlock.h:
Using __sync_xxx builtins
^ permalink raw reply [flat|nested] 2+ messages in thread
* |WARNING| pw119265 [PATCH] Add support for IBM Z s390x
@ 2022-10-28 22:07 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2022-10-28 22:07 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 12774 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/119265
_apply patch failure_
Submitter: David Miller <dmiller423@gmail.com>
Date: Friday, October 28 2022 21:52:40
Applied on: CommitID:92e9fe0d87b1e27306167b56a0c90c471966c630
Apply patch set 119265 failed:
.git/rebase-apply/patch:1905: trailing whitespace.
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
Checking patch app/test-acl/main.c...
Hunk #1 succeeded at 89 (offset 6 lines).
Checking patch app/test-pmd/config.c...
error: while searching for:
static uint64_t prev_bytes_tx[RTE_MAX_ETHPORTS];
static uint64_t prev_ns[RTE_MAX_ETHPORTS];
struct timespec cur_time;
uint64_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,
diff_ns;
uint64_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;
struct rte_eth_stats stats;
static const char *nic_stats_border = "########################";
error: patch failed: app/test-pmd/config.c:245
Hunk #2 succeeded at 340 (offset 38 lines).
Checking patch app/test/test_acl.c...
Checking patch app/test/test_atomic.c...
Checking patch app/test/test_cmdline.c...
Checking patch app/test/test_cmdline_ipaddr.c...
Checking patch app/test/test_cmdline_num.c...
Checking patch app/test/test_hash_functions.c...
Checking patch app/test/test_xmmt_ops.h...
error: while searching for:
return data;
}
#endif
#endif /* _TEST_XMMT_OPS_H_ */
error: patch failed: app/test/test_xmmt_ops.h:49
Checking patch buildtools/pmdinfogen.py...
Checking patch config/meson.build...
error: while searching for:
cpu_instruction_set = 'generic'
elif host_machine.cpu_family().startswith('ppc')
cpu_instruction_set = 'power8'
endif
endif
error: patch failed: config/meson.build:121
Checking patch config/s390x/meson.build...
.git/rebase-apply/patch:565: new blank line at EOF.
+
Checking patch config/s390x/s390x_linux_clang_ubuntu...
Checking patch doc/guides/nics/features/i40e.ini...
Checking patch drivers/common/mlx5/mlx5_common.h...
Checking patch drivers/net/i40e/i40e_rxtx_vec_s390x.c...
Checking patch drivers/net/i40e/meson.build...
Hunk #1 succeeded at 87 (offset 14 lines).
Checking patch drivers/net/ixgbe/ixgbe_rxtx.c...
error: while searching for:
}
/* Stubs needed for linkage when RTE_ARCH_PPC_64 is set */
#if defined(RTE_ARCH_PPC_64)
int
ixgbe_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)
{
error: patch failed: drivers/net/ixgbe/ixgbe_rxtx.c:5958
Checking patch drivers/net/memif/rte_eth_memif.h...
error: while searching for:
#define __NR_memfd_create 279
#elif defined __powerpc__
#define __NR_memfd_create 360
#elif defined __i386__
#define __NR_memfd_create 356
#else
error: patch failed: drivers/net/memif/rte_eth_memif.h:178
Checking patch drivers/net/mlx5/mlx5_rx.c...
Hunk #1 succeeded at 227 (offset 18 lines).
Hunk #2 succeeded at 239 (offset 18 lines).
Hunk #3 succeeded at 335 (offset 18 lines).
Checking patch drivers/net/octeontx/base/octeontx_pki_var.h...
Checking patch examples/l3fwd-acl/main.c...
error: examples/l3fwd-acl/main.c: does not exist in index
Checking patch examples/l3fwd/l3fwd_em.c...
error: while searching for:
return vec_and(data, mask);
}
#else
#error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain
#endif
error: patch failed: examples/l3fwd/l3fwd_em.c:239
Checking patch examples/l3fwd/l3fwd_lpm_s390x.h...
Checking patch examples/l3fwd/l3fwd_s390x.h...
Checking patch lib/acl/acl_bld.c...
Hunk #1 succeeded at 780 (offset 3 lines).
Checking patch lib/acl/acl_gen.c...
Checking patch lib/acl/acl_run_scalar.c...
Checking patch lib/acl/rte_acl.c...
Checking patch lib/acl/rte_acl.h...
Hunk #1 succeeded at 242 (offset 1 line).
Checking patch lib/eal/s390x/include/meson.build...
Checking patch lib/eal/s390x/include/rte_atomic.h...
Checking patch lib/eal/s390x/include/rte_byteorder.h...
Checking patch lib/eal/s390x/include/rte_cpuflags.h...
Checking patch lib/eal/s390x/include/rte_cycles.h...
Checking patch lib/eal/s390x/include/rte_io.h...
Checking patch lib/eal/s390x/include/rte_mcslock.h...
Checking patch lib/eal/s390x/include/rte_memcpy.h...
Checking patch lib/eal/s390x/include/rte_pause.h...
Checking patch lib/eal/s390x/include/rte_power_intrinsics.h...
Checking patch lib/eal/s390x/include/rte_prefetch.h...
Checking patch lib/eal/s390x/include/rte_rwlock.h...
Checking patch lib/eal/s390x/include/rte_spinlock.h...
Checking patch lib/eal/s390x/include/rte_ticketlock.h...
Checking patch lib/eal/s390x/include/rte_vect.h...
Checking patch lib/eal/s390x/meson.build...
.git/rebase-apply/patch:2779: new blank line at EOF.
+
Checking patch lib/eal/s390x/rte_cpuflags.c...
Checking patch lib/eal/s390x/rte_cycles.c...
Checking patch lib/eal/s390x/rte_hypervisor.c...
Checking patch lib/eal/s390x/rte_power_intrinsics.c...
Checking patch lib/hash/rte_fbk_hash.h...
Checking patch lib/lpm/meson.build...
error: while searching for:
# without worrying about which architecture we actually need
indirect_headers += files(
'rte_lpm_altivec.h',
'rte_lpm_neon.h',
'rte_lpm_sse.h',
'rte_lpm_sve.h',
error: patch failed: lib/lpm/meson.build:13
Checking patch lib/lpm/rte_lpm.h...
error: while searching for:
#endif
#elif defined(RTE_ARCH_PPC_64)
#include "rte_lpm_altivec.h"
#else
#include "rte_lpm_sse.h"
#endif
error: patch failed: lib/lpm/rte_lpm.h:405
Checking patch lib/lpm/rte_lpm6.c...
Checking patch lib/lpm/rte_lpm_s390x.h...
Checking patch meson.build...
error: while searching for:
arch_subdir = 'arm'
elif host_machine.cpu_family().startswith('ppc')
arch_subdir = 'ppc'
endif
# configure the build, and make sure configs here and in config folder are
error: patch failed: meson.build:50
Applied patch app/test-acl/main.c cleanly.
Applying patch app/test-pmd/config.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Applied patch app/test/test_acl.c cleanly.
Applied patch app/test/test_atomic.c cleanly.
Applied patch app/test/test_cmdline.c cleanly.
Applied patch app/test/test_cmdline_ipaddr.c cleanly.
Applied patch app/test/test_cmdline_num.c cleanly.
Applied patch app/test/test_hash_functions.c cleanly.
Applying patch app/test/test_xmmt_ops.h with 1 reject...
Rejected hunk #1.
Applied patch buildtools/pmdinfogen.py cleanly.
Applying patch config/meson.build with 1 reject...
Rejected hunk #1.
Applied patch config/s390x/meson.build cleanly.
Applied patch config/s390x/s390x_linux_clang_ubuntu cleanly.
Applied patch doc/guides/nics/features/i40e.ini cleanly.
Applied patch drivers/common/mlx5/mlx5_common.h cleanly.
Applied patch drivers/net/i40e/i40e_rxtx_vec_s390x.c cleanly.
Applied patch drivers/net/i40e/meson.build cleanly.
Applying patch drivers/net/ixgbe/ixgbe_rxtx.c with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/memif/rte_eth_memif.h with 1 reject...
Rejected hunk #1.
Applied patch drivers/net/mlx5/mlx5_rx.c cleanly.
Applied patch drivers/net/octeontx/base/octeontx_pki_var.h cleanly.
Applying patch examples/l3fwd/l3fwd_em.c with 1 reject...
Rejected hunk #1.
Applied patch examples/l3fwd/l3fwd_lpm_s390x.h cleanly.
Applied patch examples/l3fwd/l3fwd_s390x.h cleanly.
Applied patch lib/acl/acl_bld.c cleanly.
Applied patch lib/acl/acl_gen.c cleanly.
Applied patch lib/acl/acl_run_scalar.c cleanly.
Applied patch lib/acl/rte_acl.c cleanly.
Applied patch lib/acl/rte_acl.h cleanly.
Applied patch lib/eal/s390x/include/meson.build cleanly.
Applied patch lib/eal/s390x/include/rte_atomic.h cleanly.
Applied patch lib/eal/s390x/include/rte_byteorder.h cleanly.
Applied patch lib/eal/s390x/include/rte_cpuflags.h cleanly.
Applied patch lib/eal/s390x/include/rte_cycles.h cleanly.
Applied patch lib/eal/s390x/include/rte_io.h cleanly.
Applied patch lib/eal/s390x/include/rte_mcslock.h cleanly.
Applied patch lib/eal/s390x/include/rte_memcpy.h cleanly.
Applied patch lib/eal/s390x/include/rte_pause.h cleanly.
Applied patch lib/eal/s390x/include/rte_power_intrinsics.h cleanly.
Applied patch lib/eal/s390x/include/rte_prefetch.h cleanly.
Applied patch lib/eal/s390x/include/rte_rwlock.h cleanly.
Applied patch lib/eal/s390x/include/rte_spinlock.h cleanly.
Applied patch lib/eal/s390x/include/rte_ticketlock.h cleanly.
Applied patch lib/eal/s390x/include/rte_vect.h cleanly.
Applied patch lib/eal/s390x/meson.build cleanly.
Applied patch lib/eal/s390x/rte_cpuflags.c cleanly.
Applied patch lib/eal/s390x/rte_cycles.c cleanly.
Applied patch lib/eal/s390x/rte_hypervisor.c cleanly.
Applied patch lib/eal/s390x/rte_power_intrinsics.c cleanly.
Applied patch lib/hash/rte_fbk_hash.h cleanly.
Applying patch lib/lpm/meson.build with 1 reject...
Rejected hunk #1.
Applying patch lib/lpm/rte_lpm.h with 1 reject...
Rejected hunk #1.
Applied patch lib/lpm/rte_lpm6.c cleanly.
Applied patch lib/lpm/rte_lpm_s390x.h cleanly.
Applying patch meson.build with 1 reject...
Rejected hunk #1.
diff a/app/test-pmd/config.c b/app/test-pmd/config.c (rejected hunks)
@@ -245,9 +245,9 @@ nic_stats_display(portid_t port_id)
static uint64_t prev_bytes_tx[RTE_MAX_ETHPORTS];
static uint64_t prev_ns[RTE_MAX_ETHPORTS];
struct timespec cur_time;
- uint64_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,
- diff_ns;
- uint64_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;
+ __uint128_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,
+ diff_ns;
+ __uint128_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;
struct rte_eth_stats stats;
static const char *nic_stats_border = "########################";
diff a/app/test/test_xmmt_ops.h b/app/test/test_xmmt_ops.h (rejected hunks)
@@ -49,6 +49,20 @@ vect_set_epi32(int i3, int i2, int i1, int i0)
return data;
}
+#elif defined(RTE_ARCH_S390X)
+
+/* loads the xmm_t value from address p(does not need to be 16-byte aligned)*/
+#define vect_loadu_sil128(p) vec_xld2(0, (signed int *)p)
+
+/* sets the 4 signed 32-bit integer values and returns the xmm_t variable */
+static __rte_always_inline xmm_t
+vect_set_epi32(int i3, int i2, int i1, int i0)
+{
+ xmm_t data = (xmm_t){i0, i1, i2, i3};
+
+ return data;
+}
+
#endif
#endif /* _TEST_XMMT_OPS_H_ */
diff a/config/meson.build b/config/meson.build (rejected hunks)
@@ -121,6 +121,8 @@ if cpu_instruction_set == 'generic'
cpu_instruction_set = 'generic'
elif host_machine.cpu_family().startswith('ppc')
cpu_instruction_set = 'power8'
+ elif host_machine.cpu_family().startswith('s390x')
+ machine = 'z13'
endif
endif
diff a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c (rejected hunks)
@@ -5958,7 +5958,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,
}
/* Stubs needed for linkage when RTE_ARCH_PPC_64 is set */
-#if defined(RTE_ARCH_PPC_64)
+#if defined(RTE_ARCH_PPC_64) || defined(RTE_ARCH_S390X)
int
ixgbe_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)
{
diff a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h (rejected hunks)
@@ -178,6 +178,8 @@ const char *memif_version(void);
#define __NR_memfd_create 279
#elif defined __powerpc__
#define __NR_memfd_create 360
+#elif defined __s390x__
+#define __NR_memfd_create 350
#elif defined __i386__
#define __NR_memfd_create 356
#else
diff a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c (rejected hunks)
@@ -239,6 +239,14 @@ em_mask_key(void *key, xmm_t mask)
return vec_and(data, mask);
}
+#elif defined(__s390x__)
+static inline xmm_t
+em_mask_key(void *key, xmm_t mask)
+{
+ xmm_t data = (xmm_t) vec_xld2(0, (unsigned int *)(key));
+
+ return data + mask;
+}
#else
#error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain
#endif
diff a/lib/lpm/meson.build b/lib/lpm/meson.build (rejected hunks)
@@ -13,6 +13,7 @@ headers = files('rte_lpm.h', 'rte_lpm6.h')
# without worrying about which architecture we actually need
indirect_headers += files(
'rte_lpm_altivec.h',
+ 'rte_lpm_s390x.h',
'rte_lpm_neon.h',
'rte_lpm_sse.h',
'rte_lpm_sve.h',
diff a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h (rejected hunks)
@@ -405,6 +405,8 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4],
#endif
#elif defined(RTE_ARCH_PPC_64)
#include "rte_lpm_altivec.h"
+#elif defined(RTE_ARCH_S390X)
+#include "rte_lpm_s390x.h"
#else
#include "rte_lpm_sse.h"
#endif
diff a/meson.build b/meson.build (rejected hunks)
@@ -50,6 +50,8 @@ elif host_machine.cpu_family().startswith('arm') or host_machine.cpu_family().st
arch_subdir = 'arm'
elif host_machine.cpu_family().startswith('ppc')
arch_subdir = 'ppc'
+elif host_machine.cpu_family().startswith('s390x')
+ arch_subdir = 's390x'
endif
# configure the build, and make sure configs here and in config folder are
https://lab.dpdk.org/results/dashboard/patchsets/24236/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-28 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221028215240.103365-1-dmiller423@gmail.com>
2022-10-28 21:54 ` |WARNING| pw119265 [PATCH] Add support for IBM Z s390x checkpatch
2022-10-28 22:07 dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).