DPDK CI discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: "jspewock@iol.unh.edu" <jspewock@iol.unh.edu>,
	"ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [PATCH v7 0/4] Add ACVP Tool
Date: Mon, 10 Apr 2023 10:56:03 -0400	[thread overview]
Message-ID: <CAJvnSUAzxF38NO+7iSKq8PNRVjngcKgFM4BKUjLUCD-4U0aeTg@mail.gmail.com> (raw)
In-Reply-To: <CH0PR12MB51564EF19CFF8158C693A42ADA939@CH0PR12MB5156.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2060 bytes --]

Hi Ali,

Is this good to be merged since it's been acked by a maintainer with no
more discussion afterwards? Or is there something more to be done here?

Thanks,
Patrick

On Tue, Apr 4, 2023 at 9:20 AM Ali Alnubani <alialnu@nvidia.com> wrote:

> > -----Original Message-----
> > From: jspewock@iol.unh.edu <jspewock@iol.unh.edu>
> > Sent: Monday, April 3, 2023 9:39 PM
> > To: ci@dpdk.org
> > Cc: Jeremy Spewock <jspewock@iol.unh.edu>
> > Subject: [PATCH v7 0/4] Add ACVP Tool
> >
> > From: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > v1: https://mails.dpdk.org/archives/ci/2022-January/001599.html
> > v2: https://mails.dpdk.org/archives/ci/2022-January/001611.html
> > v3: https://mails.dpdk.org/archives/ci/2022-February/001636.html
> > v4: https://mails.dpdk.org/archives/ci/2022-April/001702.html
> > v5: https://mails.dpdk.org/archives/ci/2023-March/002112.html
> > v6: https://mails.dpdk.org/archives/ci/2023-March/002147.html
> > v7:
> >   * fix commit messages
> >   * fix whitespace errors
> >
> > Brandon Lo (4):
> >   tools: add acvp_tool
> >   tools: add default config file for acvp_tool
> >   tools: add requirements file for acvp_tool
> >   doc: add readme file for acvp_tool
> >
> >  tools/acvp/README           | 118 +++++++++++++
> >  tools/acvp/__init__.py      |   0
> >  tools/acvp/acvp_config.json |  52 ++++++
> >  tools/acvp/acvp_tool.py     | 319
> > ++++++++++++++++++++++++++++++++++++
> >  tools/acvp/requirements.txt |   7 +
> >  5 files changed, 496 insertions(+)
> >  create mode 100644 tools/acvp/README
> >  create mode 100644 tools/acvp/__init__.py
> >  create mode 100644 tools/acvp/acvp_config.json
> >  create mode 100755 tools/acvp/acvp_tool.py
> >  create mode 100644 tools/acvp/requirements.txt
> >
> > --
> > 2.40.0
>
> Thank you for addressing comments.
>
> Acked-by: Ali Alnubani <alialnu@nvidia.com>
>


-- 

Patrick Robb

Technical Service Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu

[-- Attachment #2: Type: text/html, Size: 5541 bytes --]

  reply	other threads:[~2023-04-10 14:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 18:39 jspewock
2023-04-03 18:39 ` [PATCH v7 1/4] tools: add acvp_tool jspewock
2023-04-03 18:39 ` [PATCH v7 2/4] tools: add default config file for acvp_tool jspewock
2023-04-03 18:39 ` [PATCH v7 3/4] tools: add requirements " jspewock
2023-04-03 18:39 ` [PATCH v7 4/4] doc: add readme " jspewock
2023-04-04 13:20 ` [PATCH v7 0/4] Add ACVP Tool Ali Alnubani
2023-04-10 14:56   ` Patrick Robb [this message]
2023-04-10 15:19     ` Ali Alnubani
2023-04-11 21:22       ` Patrick Robb
2023-04-12  8:16         ` Thomas Monjalon
2023-04-12 21:10           ` Jeremy Spewock
2023-04-13 21:20             ` Aaron Conole
2023-04-13 21:20           ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJvnSUAzxF38NO+7iSKq8PNRVjngcKgFM4BKUjLUCD-4U0aeTg@mail.gmail.com \
    --to=probb@iol.unh.edu \
    --cc=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    --cc=jspewock@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).