Re: [PATCH v7 0/4] Add ACVP Tool

[Aaron Conole <aconole@redhat.com>]

Jeremy Spewock <jspewock@iol.unh.edu> writes:

> Hello,
>
> I can see why you would want to squash everything into one patch; I had just thought that the intention with
> maintaining the structure of the old patch series was to preserve Brandon's original commits and comments alongside
> some minor expansion where necessary. If it would be preferred however, I can resubmit with everything squashed into
> a single patch.
>
> Aaron, if you could also review this series and give your thoughts on the matter as well that would be greatly
> appreciated.

After looking at the structure, I agree with Thomas about squashing.
Generally, try to introduce the change as a complete atom.  In this
case, we don't extend anything anywhere else.  If there were other
scripts, etc. then we could do that.

When I see the squashed patch come through, I can apply and push.

Thanks!

> Thanks,
> Jeremy
>
> On Wed, Apr 12, 2023 at 4:16 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
>  Hi,
>
>  Aaron is the maintainer.
>  I can also push the commits.
>
>  I think you should squash all in one patch
>  and provide an explanation in the commit message
>  about what this tool is for exactly.
>
>  11/04/2023 23:22, Patrick Robb:
>  > Hi Ali,
>  > 
>  > Aaron says he is not a maintainer either. Do you know whether there is some
>  > place I can look to see who the current maintainers are? There isn't an
>  > equivalent to the MAINTAINERS file like in the main DPDK repo.
>  > 
>  > Thomas, you might be the only current maintainer on this repo. We'll be
>  > grateful at the lab if you're able to merge this patch.
>  > 
>  > Best,
>  > Patrick
>  > 
>  > On Mon, Apr 10, 2023 at 11:19 AM Ali Alnubani <alialnu@nvidia.com> wrote:
>  > 
>  > > > Hi Ali,
>  > > >
>  > > > Is this good to be merged since it's been acked by a maintainer with no
>  > > more discussion afterwards? Or is there something more to be done here?
>  > > [..]
>  > >
>  > > Hello Patrick,
>  > >
>  > > Already acked from my side, waiting for a maintainer to merge if they have
>  > > no other comments (Thomas/Aaron).
>  > >
>  > > Thanks,
>  > > Ali