Re: [dpdk-dev] [PATCH v3 0/2] clean up interrupt handle

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, April 4, 2017 6:13 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v3 0/2] clean up interrupt handle
> 
> Hi,
> 
> 2017-03-30 22:09, Qi Zhang:
> > It seems its not necessary to register an intr_handle for interrupt
> > callback function. "void* cb_arg" shows enough when be used to pass
> > the object that contain the information be required to handle the
> > interrupt event( A typical way which is implemented by almost all
> > driver is by passing a rte_ethdev instance). The patch change the
> > prototype of rte_intr_callback_fn by removing the uncessary intr_handle
> paramter.
> >
> > v3:
> > - update bnx2x driver which is missed in v1,v2
> >
> > v2:
> > - seperate patch 1 in v1 into 2 patches.
> > - correct some commit log.
> >
> > Qi Zhang (2):
> >   eal: clean up interrupt handle
> >   app/test: update test code
> 
> Several comments:
> 
> * You forgot to use --in-reply-to, so it is not convenient to check the history.
Will follow, thanks for your reminder.
> 
> * Please keep the the prior acked-by in your patches if there are.
Will add that back
> 
> * There is another miss in this patch:
> 
> drivers/net/mlx5/mlx5_ethdev.c:1259:10:
> fatal error: incompatible pointer types passing 'void (struct rte_intr_handle *,
> void *)'
> to parameter of type 'rte_intr_callback_fn'
> (aka 'void (*)(void *)') [-Wincompatible-pointer-types]
>     mlx5_dev_interrupt_handler,

After I turn on mlx5 driver and downloaded the missing mlx libraries, I saw this issue.
Will update.

> 
> * The second patch is clearly not up to date as the file
> app/test/test_interrupts.c has moved.

Will sync to latest code.

Thanks
Qi