Re: [dpdk-dev] [PATCH v5 0/2] clean up interrupt handle

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, April 4, 2017 10:50 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v5 0/2] clean up interrupt handle
> 
> 2017-04-05 06:27, Qi Zhang:
> > It seems its not necessary to register an intr_handle for interrupt
> > callback function. "void* cb_arg" shows enough when be used to pass
> > the object that contain the information be required to handle the
> > interrupt event( A typical way which is implemented by almost all
> > driver is by passing a rte_ethdev instance).
> > The patch change the prototype of rte_intr_callback_fn by removing the
> > uncessary intr_handle paramter.
> >
> > v5:
> >
> > - Update mlx4 driver which is missed in previous version.
> >
> > v4:
> >
> > - Update mlx5 driver which is missed in v1, v2, v3.
> > - Add back patch 1 of v2 to make this complete though it already be
> applied.
> > - Remove patch 3 which is not necessary with latest master.
> 
> Why have you removed patch 3?
> 
> There is this error now:
> 
> test/test/test_interrupts.c:217:4: fatal error:
> incompatible pointer types passing 'void (struct rte_intr_handle *, void *)'
> to parameter of type 'rte_intr_callback_fn' (aka 'void (*)(void *)')
> [-Wincompatible-pointer-types]
>                         test_interrupt_callback, arg) >= 0) {
> 
Sorry, did not noticed the recent change "mk: do not build tests by default",
I thought the related test code has been removed.
Will Fix.