Re: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Shahaf Shuler [mailto:shahafs@mellanox.com]
> Sent: Tuesday, April 4, 2017 9:54 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; thomas.monjalon@6wind.com
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle
> 
> Wednesday, April 5, 2017 12:21 AM, Qi Zhang:
> > The patch change the prototype of callback function
> > (rte_intr_callback_fn) by removing the unnecessary parameter.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > v4:
> >
> > - Update mlx5 driver which is missed in v1, v2, v3.
> 
> Thanks for the update of mlx5.
> The compilation is still failing for mlx4. the implementation there is much
> similar to mlx5.

OK, should not rely on compile option , now scan the code, this should be the last missing one:)
Thanks.
> 
> >
> > v3:
> >
> > - Update bnx2x driver which is missed in v1,v2
> >
> > v2:
> >
> > - Seperate patch 1 of v1 into 2 patches.(part 2)
> >
> >  drivers/net/bnx2x/bnx2x_ethdev.c               |  5 +++--
> >  drivers/net/bnxt/bnxt_irq.c                    |  3 +--
> >  drivers/net/e1000/em_ethdev.c                  |  8 +++-----
> >  drivers/net/e1000/igb_ethdev.c                 | 15 ++++++---------
> >  drivers/net/enic/enic_main.c                   |  3 +--
> >  drivers/net/fm10k/fm10k_ethdev.c               | 12 ++++--------
> >  drivers/net/i40e/i40e_ethdev.c                 |  8 +++-----
> >  drivers/net/i40e/i40e_ethdev_vf.c              |  5 ++---
> >  drivers/net/ixgbe/ixgbe_ethdev.c               | 14 +++++---------
> >  drivers/net/mlx5/mlx5.h                        |  2 +-
> >  drivers/net/mlx5/mlx5_ethdev.c                 |  3 +--
> >  drivers/net/nfp/nfp_net.c                      |  6 ++----
> >  drivers/net/qede/qede_ethdev.c                 |  4 ++--
> >  drivers/net/sfc/sfc_intr.c                     | 10 ++++++----
> >  drivers/net/virtio/virtio_ethdev.c             |  5 ++---
> >  lib/librte_eal/common/include/rte_interrupts.h |  3 +--
> >  lib/librte_eal/linuxapp/eal/eal_alarm.c        |  5 ++---
> >  lib/librte_eal/linuxapp/eal/eal_interrupts.c   |  3 +--
> >  18 files changed, 46 insertions(+), 68 deletions(-)
> 
> [...]
> 
> > @@ -119,12 +119,13 @@ bnx2x_interrupt_action(struct rte_eth_dev
> *dev)