DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc/power: add info on scale mode reaction time
@ 2021-11-24 16:53 David Hunt
  2021-11-26 13:23 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: David Hunt @ 2021-11-24 16:53 UTC (permalink / raw)
  To: dev; +Cc: david.hunt

When using PMD Power Management, scale mode reacts slower than
monitor mode and pause mode. Add note in user guide to this
effect.

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 doc/guides/prog_guide/power_man.rst               | 4 +++-
 doc/guides/sample_app_ug/l3_forward_power_man.rst | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index e387d7811e..66592cf22f 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -216,7 +216,9 @@ power saving whenever empty poll count reaches a certain number.
 
 * Frequency scaling
    This power saving scheme will use ``librte_power`` library functionality to
-   scale the core frequency up/down depending on traffic volume.
+   scale the core frequency up/down depending on traffic volume. The reaction
+   time of the frequency scaling mode is longer than the pause and monitor
+   mode.
 
 The "monitor" mode is only supported in the following configurations and scenarios:
 
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index 8817eaadbf..84b014fab5 100644
--- a/doc/guides/sample_app_ug/l3_forward_power_man.rst
+++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst
@@ -345,8 +345,9 @@ and has three available power management schemes:
   to avoid busy looping when there is no traffic.
 
 ``scale``
-  This will use frequency scaling routines
-  available in the ``librte_power`` library.
+  This will use frequency scaling routines available in
+  the ``librte_power`` library. The reaction time of the
+  scale mode is longer than the pause and monitor mode.
 
 See :doc:`Power Management<../prog_guide/power_man>` chapter
 in the DPDK Programmer's Guide for more details on PMD power management.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc/power: add info on scale mode reaction time
  2021-11-24 16:53 [PATCH] doc/power: add info on scale mode reaction time David Hunt
@ 2021-11-26 13:23 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-11-26 13:23 UTC (permalink / raw)
  To: David Hunt; +Cc: dev, bruce.richardson, ferruh.yigit, david.marchand

24/11/2021 17:53, David Hunt:
> When using PMD Power Management, scale mode reacts slower than
> monitor mode and pause mode. Add note in user guide to this
> effect.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>     This power saving scheme will use ``librte_power`` library functionality to
> -   scale the core frequency up/down depending on traffic volume.
> +   scale the core frequency up/down depending on traffic volume. The reaction
> +   time of the frequency scaling mode is longer than the pause and monitor
> +   mode.
[...]
> -  This will use frequency scaling routines
> -  available in the ``librte_power`` library.
> +  This will use frequency scaling routines available in
> +  the ``librte_power`` library. The reaction time of the
> +  scale mode is longer than the pause and monitor mode.

You don't have to change existing lines to add a new sentence.
That's why I recommend always starting a new sentence on a new line.
I fixed it to make the patch cleaner.

Applied



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-26 13:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 16:53 [PATCH] doc/power: add info on scale mode reaction time David Hunt
2021-11-26 13:23 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git