[PATCH v1] usertools/telemetry: fix unused parameter

[PATCH v1] usertools/telemetry: fix unused parameter

[Samina Arshad]

This bug fix ensures that the runtime socket path is generated
correctly, based on the user-specified file_prefix value,
resolving the issue that occurred in the previous implementation.

Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
Cc: lihuisong@huawei.com
Cc: stable@dpdk.org

Signed-off-by: Samina Arshad <samina.arshad@intel.com>
---
 usertools/dpdk-telemetry-client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index d6718ca5b0..3441b6b02e 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -55,7 +55,7 @@ def getFilepath(self, file_path):
         # Gets arguments from Command-Line and assigns to instance of client
         self.file_path = file_path
 
-    def setRunpath(self, file_path):
+    def setRunpath(self, file_prefix):
         self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
                                      RUNTIME_SOCKET_NAME)
 
-- 
2.25.1

Re: [PATCH v1] usertools/telemetry: fix unused parameter

[Burakov, Anatoly]

On 5/18/2023 2:47 PM, Samina Arshad wrote:
> This bug fix ensures that the runtime socket path is generated
> correctly, based on the user-specified file_prefix value,
> resolving the issue that occurred in the previous implementation.
> 
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> ---
>   usertools/dpdk-telemetry-client.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
> index d6718ca5b0..3441b6b02e 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -55,7 +55,7 @@ def getFilepath(self, file_path):
>           # Gets arguments from Command-Line and assigns to instance of client
>           self.file_path = file_path
>   
> -    def setRunpath(self, file_path):
> +    def setRunpath(self, file_prefix):
>           self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
>                                        RUNTIME_SOCKET_NAME)
>   

Does this fix anything? The path is generated from args.file_prefix 
anyway, so this change will have no effect, I think?

-- 
Thanks,
Anatoly

[PATCH v2] usertools/telemetry: fix unused parameter

[Samina Arshad]

This bug fix ensures that the runtime socket path is generated
correctly, based on the user-specified file_prefix value,
resolving the issue that occurred in the previous implementation.

Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
Cc: lihuisong@huawei.com
Cc: stable@dpdk.org

Signed-off-by: Samina Arshad <samina.arshad@intel.com>
---
v2:
Made changes for previous commit to be efficient. Removed
"args" from "args.file_prefix".
---
---
 usertools/dpdk-telemetry-client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index d6718ca5b0..e3bb1c9ee0 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -55,8 +55,8 @@ def getFilepath(self, file_path):
         # Gets arguments from Command-Line and assigns to instance of client
         self.file_path = file_path
 
-    def setRunpath(self, file_path):
-        self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
+    def setRunpath(self, file_prefix):
+        self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix),
                                      RUNTIME_SOCKET_NAME)
 
     def register(self):
-- 
2.25.1

RE: [PATCH v2] usertools/telemetry: fix unused parameter

[Power, Ciara]

Hi Samina,

> -----Original Message-----
> From: Arshad, Samina <samina.arshad@intel.com>
> Sent: Tuesday 23 May 2023 15:39
> To: y
> Cc: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org; Kearney, Tadhg
> <tadhg.kearney@intel.com>; stable@dpdk.org; Arshad, Samina
> <samina.arshad@intel.com>; lihuisong@huawei.com
> Subject: [PATCH v2] usertools/telemetry: fix unused parameter
> 
> This bug fix ensures that the runtime socket path is generated correctly, based
> on the user-specified file_prefix value, resolving the issue that occurred in the
> previous implementation.
> 
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
> Cc: stable@dpdk.org

No need for cc stable here because the bad commit was only introduced in 23.03 release.
That means we don't need the fix to be backported to 21.11 or 22.11, as the bug didn't exist in those releases.

+1 for code changes though,

Acked-by: Ciara Power <ciara.power@intel.com>

> 
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> ---
> v2:
> Made changes for previous commit to be efficient. Removed "args" from
> "args.file_prefix".
<snip>

[PATCH v3] usertools/telemetry: fix unused parameter

[Samina Arshad]

This bug fix ensures that the runtime socket path is generated
correctly, based on the user-specified file_prefix value,
resolving the issue that occurred in the previous implementation.

Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
Cc: lihuisong@huawei.com

Signed-off-by: Samina Arshad <samina.arshad@intel.com>
Acked-by: Ciara Power <ciara.power@intel.com>
---
v2:
Made changes for previous commit to be efficient. Removed
"args" from "args.file_prefix".
---
v3:
Edit commit body by removing stable@dpdk.org from cc as
the fix is not needed to be backported to 21.11 or 22.11.
---
---
 usertools/dpdk-telemetry-client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index d6718ca5b0..e3bb1c9ee0 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -55,8 +55,8 @@ def getFilepath(self, file_path):
         # Gets arguments from Command-Line and assigns to instance of client
         self.file_path = file_path
 
-    def setRunpath(self, file_path):
-        self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
+    def setRunpath(self, file_prefix):
+        self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix),
                                      RUNTIME_SOCKET_NAME)
 
     def register(self):
-- 
2.25.1

Re: [PATCH v3] usertools/telemetry: fix unused parameter

[lihuisong (C)]

在 2023/5/25 23:50, Samina Arshad 写道:
> This bug fix ensures that the runtime socket path is generated
> correctly, based on the user-specified file_prefix value,
> resolving the issue that occurred in the previous implementation.
>
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
>
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> ---
> v2:
> Made changes for previous commit to be efficient. Removed
> "args" from "args.file_prefix".
> ---
> v3:
> Edit commit body by removing stable@dpdk.org from cc as
> the fix is not needed to be backported to 21.11 or 22.11.
> ---
> ---
>   usertools/dpdk-telemetry-client.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
> index d6718ca5b0..e3bb1c9ee0 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -55,8 +55,8 @@ def getFilepath(self, file_path):
>           # Gets arguments from Command-Line and assigns to instance of client
>           self.file_path = file_path
>   
> -    def setRunpath(self, file_path):
> -        self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
> +    def setRunpath(self, file_prefix):
> +        self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix),
>                                        RUNTIME_SOCKET_NAME)

Apologise for the mistake.

Acked-by: lihuisong@huawei.com

>   
>       def register(self):

Re: [PATCH v2] usertools/telemetry: fix unused parameter

[Thomas Monjalon]

25/05/2023 15:34, Power, Ciara:
> From: Arshad, Samina <samina.arshad@intel.com>
> > Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> > Cc: lihuisong@huawei.com
> > Cc: stable@dpdk.org
> 
> No need for cc stable here because the bad commit was only introduced in 23.03 release.
> That means we don't need the fix to be backported to 21.11 or 22.11, as the bug didn't exist in those releases.

We need to Cc: stable as long as the bug is in a different release.
It will not trigger a backport for upstream releases,
but it could help someone maintaining 23.03 for a specific purpose.

RE: [PATCH v2] usertools/telemetry: fix unused parameter

[Power, Ciara]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday 1 June 2023 15:42
> To: Arshad, Samina <samina.arshad@intel.com>; Power, Ciara
> <ciara.power@intel.com>
> Cc: dev@dpdk.org; Kearney, Tadhg <tadhg.kearney@intel.com>;
> stable@dpdk.org; lihuisong@huawei.com; Dooley, Brian
> <brian.dooley@intel.com>
> Subject: Re: [PATCH v2] usertools/telemetry: fix unused parameter
> 
> 25/05/2023 15:34, Power, Ciara:
> > From: Arshad, Samina <samina.arshad@intel.com>
> > > Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix
> > > argument")
> > > Cc: lihuisong@huawei.com
> > > Cc: stable@dpdk.org
> >
> > No need for cc stable here because the bad commit was only introduced in
> 23.03 release.
> > That means we don't need the fix to be backported to 21.11 or 22.11, as the
> bug didn't exist in those releases.
> 
> We need to Cc: stable as long as the bug is in a different release.
> It will not trigger a backport for upstream releases, but it could help someone
> maintaining 23.03 for a specific purpose.
> 

Ah - didn't realise that. Noted, thanks Thomas!

Re: [PATCH v3] usertools/telemetry: fix unused parameter

[Thomas Monjalon]

26/05/2023 05:41, lihuisong (C):
> 在 2023/5/25 23:50, Samina Arshad 写道:
> > This bug fix ensures that the runtime socket path is generated
> > correctly, based on the user-specified file_prefix value,
> > resolving the issue that occurred in the previous implementation.

In general we require to describe the issue,
but I'll accept this one as it is simple enough.

> >
> > Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> > Cc: lihuisong@huawei.com
> >
> > Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> > Acked-by: Ciara Power <ciara.power@intel.com>
> Acked-by: lihuisong@huawei.com

Applied, thanks.