DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options
@ 2020-10-22 22:05 Thomas Monjalon
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option Thomas Monjalon
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-22 22:05 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain

Below patches are cleaning traces of CONFIG_RTE_ after make removal,
except one occurence in app/test/test_cryptodev.c (left as exercise).
PS: In reality I don't know what must be done for this case about QAT.

Thomas Monjalon (5):
  eal: remove comment about old partition option
  mem: fix config name in error logs
  lib: remove config prefix used with make
  drivers: remove config prefix used with make
  doc: remove references to make from known issues

 doc/guides/rel_notes/known_issues.rst       |  8 ++------
 drivers/net/bnxt/bnxt_ethdev.c              |  2 +-
 drivers/net/ixgbe/ixgbe_rxtx.c              |  2 +-
 drivers/net/sfc/sfc_ef10_essb_rx.c          |  2 +-
 lib/librte_eal/arm/include/rte_atomic_32.h  |  2 +-
 lib/librte_eal/arm/include/rte_atomic_64.h  |  2 +-
 lib/librte_eal/arm/include/rte_byteorder.h  |  2 +-
 lib/librte_eal/arm/include/rte_mcslock.h    |  2 +-
 lib/librte_eal/arm/include/rte_spinlock.h   |  2 +-
 lib/librte_eal/arm/include/rte_ticketlock.h |  2 +-
 lib/librte_eal/common/eal_common_dynmem.c   |  4 ++--
 lib/librte_eal/freebsd/eal_memory.c         |  6 +++---
 lib/librte_eal/include/rte_eal.h            |  8 --------
 lib/librte_eal/linux/eal_memory.c           |  8 ++++----
 lib/librte_eal/linux/eal_timer.c            |  2 +-
 lib/librte_eal/linux/eal_vfio_mp_sync.c     |  2 +-
 lib/librte_mbuf/rte_mbuf_core.h             |  3 +--
 lib/librte_rcu/rte_rcu_qsbr.h               | 10 +++++-----
 18 files changed, 28 insertions(+), 41 deletions(-)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option
  2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
@ 2020-10-22 22:05 ` Thomas Monjalon
  2020-10-28 12:08   ` Burakov, Anatoly
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs Thomas Monjalon
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-22 22:05 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain

The main initialization function (rte_eal_init) has documentation
about a feature from another era: memory partition.

Curiously, this lost treasure is found only now,
suggesting there may be other interesting things to discover in the doc.
To all aspiring Indiana Jones: the hunt is open!

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/include/rte_eal.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h
index 0ae12cf4fb..eaf6469e50 100644
--- a/lib/librte_eal/include/rte_eal.h
+++ b/lib/librte_eal/include/rte_eal.h
@@ -67,16 +67,8 @@ int rte_eal_iopl_init(void);
  *
  * This function is to be executed on the MAIN lcore only, as soon
  * as possible in the application's main() function.
- *
- * The function finishes the initialization process before main() is called.
  * It puts the WORKER lcores in the WAIT state.
  *
- * When the multi-partition feature is supported, depending on the
- * configuration (if CONFIG_RTE_EAL_MAIN_PARTITION is disabled), this
- * function waits to ensure that the magic number is set before
- * returning. See also the rte_eal_get_configuration() function. Note:
- * This behavior may change in the future.
- *
  * @param argc
  *   A non-negative value.  If it is greater than 0, the array members
  *   for argv[0] through argv[argc] (non-inclusive) shall contain pointers
-- 
2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs
  2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option Thomas Monjalon
@ 2020-10-22 22:05 ` Thomas Monjalon
  2020-10-28 12:08   ` Burakov, Anatoly
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make Thomas Monjalon
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-22 22:05 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain, stable

When introducing the new option CONFIG_RTE_MAX_MEM_MB_PER_TYPE,
some logs were referencing a wrong name: CONFIG_RTE_MAX_MEM_PER_TYPE.

Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/freebsd/eal_memory.c | 2 +-
 lib/librte_eal/linux/eal_memory.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/freebsd/eal_memory.c b/lib/librte_eal/freebsd/eal_memory.c
index b8b337a554..8d4b26b9b8 100644
--- a/lib/librte_eal/freebsd/eal_memory.c
+++ b/lib/librte_eal/freebsd/eal_memory.c
@@ -174,7 +174,7 @@ rte_eal_hugepage_init(void)
 			if (msl_idx == RTE_MAX_MEMSEG_LISTS) {
 				RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n",
 					RTE_STR(CONFIG_RTE_MAX_MEMSEG_PER_TYPE),
-					RTE_STR(CONFIG_RTE_MAX_MEM_PER_TYPE));
+					RTE_STR(CONFIG_RTE_MAX_MEM_MB_PER_TYPE));
 				return -1;
 			}
 			arr = &msl->memseg_arr;
diff --git a/lib/librte_eal/linux/eal_memory.c b/lib/librte_eal/linux/eal_memory.c
index 3e47efe582..df0f07ee7e 100644
--- a/lib/librte_eal/linux/eal_memory.c
+++ b/lib/librte_eal/linux/eal_memory.c
@@ -714,7 +714,7 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end)
 	if (msl_idx == RTE_MAX_MEMSEG_LISTS) {
 		RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n",
 				RTE_STR(CONFIG_RTE_MAX_MEMSEG_PER_TYPE),
-				RTE_STR(CONFIG_RTE_MAX_MEM_PER_TYPE));
+				RTE_STR(CONFIG_RTE_MAX_MEM_MB_PER_TYPE));
 		return -1;
 	}
 
-- 
2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make
  2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option Thomas Monjalon
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs Thomas Monjalon
@ 2020-10-22 22:05 ` Thomas Monjalon
  2020-10-23  6:28   ` Ruifeng Wang
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-22 22:05 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain, Jan Viktorin, Ruifeng Wang,
	Jerin Jacob, Honnappa Nagarahalli

The config options CONFIG_RTE_* are simple RTE_* defines with meson.
Now that make support is dropped, update the names in logs and comments.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/arm/include/rte_atomic_32.h  |  2 +-
 lib/librte_eal/arm/include/rte_atomic_64.h  |  2 +-
 lib/librte_eal/arm/include/rte_byteorder.h  |  2 +-
 lib/librte_eal/arm/include/rte_mcslock.h    |  2 +-
 lib/librte_eal/arm/include/rte_spinlock.h   |  2 +-
 lib/librte_eal/arm/include/rte_ticketlock.h |  2 +-
 lib/librte_eal/common/eal_common_dynmem.c   |  4 ++--
 lib/librte_eal/freebsd/eal_memory.c         |  6 +++---
 lib/librte_eal/linux/eal_memory.c           |  8 ++++----
 lib/librte_eal/linux/eal_timer.c            |  2 +-
 lib/librte_eal/linux/eal_vfio_mp_sync.c     |  2 +-
 lib/librte_mbuf/rte_mbuf_core.h             |  3 +--
 lib/librte_rcu/rte_rcu_qsbr.h               | 10 +++++-----
 13 files changed, 23 insertions(+), 24 deletions(-)

diff --git a/lib/librte_eal/arm/include/rte_atomic_32.h b/lib/librte_eal/arm/include/rte_atomic_32.h
index fe48ab428e..c00ab78dba 100644
--- a/lib/librte_eal/arm/include/rte_atomic_32.h
+++ b/lib/librte_eal/arm/include/rte_atomic_32.h
@@ -6,7 +6,7 @@
 #define _RTE_ATOMIC_ARM32_H_
 
 #ifndef RTE_FORCE_INTRINSICS
-#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#  error Platform must be built with RTE_FORCE_INTRINSICS
 #endif
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/arm/include/rte_atomic_64.h b/lib/librte_eal/arm/include/rte_atomic_64.h
index 20dd6c75dd..2cef88629c 100644
--- a/lib/librte_eal/arm/include/rte_atomic_64.h
+++ b/lib/librte_eal/arm/include/rte_atomic_64.h
@@ -7,7 +7,7 @@
 #define _RTE_ATOMIC_ARM64_H_
 
 #ifndef RTE_FORCE_INTRINSICS
-#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#  error Platform must be built with RTE_FORCE_INTRINSICS
 #endif
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/arm/include/rte_byteorder.h b/lib/librte_eal/arm/include/rte_byteorder.h
index 9ec4a97508..df2f1d87ba 100644
--- a/lib/librte_eal/arm/include/rte_byteorder.h
+++ b/lib/librte_eal/arm/include/rte_byteorder.h
@@ -6,7 +6,7 @@
 #define _RTE_BYTEORDER_ARM_H_
 
 #ifndef RTE_FORCE_INTRINSICS
-#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#  error Platform must be built with RTE_FORCE_INTRINSICS
 #endif
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/arm/include/rte_mcslock.h b/lib/librte_eal/arm/include/rte_mcslock.h
index dd1fe135ba..896d678073 100644
--- a/lib/librte_eal/arm/include/rte_mcslock.h
+++ b/lib/librte_eal/arm/include/rte_mcslock.h
@@ -6,7 +6,7 @@
 #define _RTE_MCSLOCK_ARM_H_
 
 #ifndef RTE_FORCE_INTRINSICS
-#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#  error Platform must be built with RTE_FORCE_INTRINSICS
 #endif
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/arm/include/rte_spinlock.h b/lib/librte_eal/arm/include/rte_spinlock.h
index 1a6916b6e8..a973763c23 100644
--- a/lib/librte_eal/arm/include/rte_spinlock.h
+++ b/lib/librte_eal/arm/include/rte_spinlock.h
@@ -6,7 +6,7 @@
 #define _RTE_SPINLOCK_ARM_H_
 
 #ifndef RTE_FORCE_INTRINSICS
-#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#  error Platform must be built with RTE_FORCE_INTRINSICS
 #endif
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/arm/include/rte_ticketlock.h b/lib/librte_eal/arm/include/rte_ticketlock.h
index e09fbd6a65..e66beefbe2 100644
--- a/lib/librte_eal/arm/include/rte_ticketlock.h
+++ b/lib/librte_eal/arm/include/rte_ticketlock.h
@@ -6,7 +6,7 @@
 #define _RTE_TICKETLOCK_ARM_H_
 
 #ifndef RTE_FORCE_INTRINSICS
-#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#  error Platform must be built with RTE_FORCE_INTRINSICS
 #endif
 
 #ifdef __cplusplus
diff --git a/lib/librte_eal/common/eal_common_dynmem.c b/lib/librte_eal/common/eal_common_dynmem.c
index 1cefe52443..7c5437ddfa 100644
--- a/lib/librte_eal/common/eal_common_dynmem.c
+++ b/lib/librte_eal/common/eal_common_dynmem.c
@@ -120,7 +120,7 @@ eal_dynmem_memseg_lists_init(void)
 
 	if (max_seglists_per_type == 0) {
 		RTE_LOG(ERR, EAL, "Cannot accommodate all memory types, please increase %s\n",
-			RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
+			RTE_STR(RTE_MAX_MEMSEG_LISTS));
 		goto out;
 	}
 
@@ -180,7 +180,7 @@ eal_dynmem_memseg_lists_init(void)
 			if (msl_idx >= RTE_MAX_MEMSEG_LISTS) {
 				RTE_LOG(ERR, EAL,
 					"No more space in memseg lists, please increase %s\n",
-					RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
+					RTE_STR(RTE_MAX_MEMSEG_LISTS));
 				goto out;
 			}
 			msl = &mcfg->memsegs[msl_idx++];
diff --git a/lib/librte_eal/freebsd/eal_memory.c b/lib/librte_eal/freebsd/eal_memory.c
index 8d4b26b9b8..78ac142b82 100644
--- a/lib/librte_eal/freebsd/eal_memory.c
+++ b/lib/librte_eal/freebsd/eal_memory.c
@@ -173,8 +173,8 @@ rte_eal_hugepage_init(void)
 			}
 			if (msl_idx == RTE_MAX_MEMSEG_LISTS) {
 				RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n",
-					RTE_STR(CONFIG_RTE_MAX_MEMSEG_PER_TYPE),
-					RTE_STR(CONFIG_RTE_MAX_MEM_MB_PER_TYPE));
+					RTE_STR(RTE_MAX_MEMSEG_PER_TYPE),
+					RTE_STR(RTE_MAX_MEM_MB_PER_TYPE));
 				return -1;
 			}
 			arr = &msl->memseg_arr;
@@ -405,7 +405,7 @@ memseg_primary_init(void)
 			if (msl_idx >= RTE_MAX_MEMSEG_LISTS) {
 				RTE_LOG(ERR, EAL,
 					"No more space in memseg lists, please increase %s\n",
-					RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
+					RTE_STR(RTE_MAX_MEMSEG_LISTS));
 				return -1;
 			}
 
diff --git a/lib/librte_eal/linux/eal_memory.c b/lib/librte_eal/linux/eal_memory.c
index df0f07ee7e..03a4f2dd2d 100644
--- a/lib/librte_eal/linux/eal_memory.c
+++ b/lib/librte_eal/linux/eal_memory.c
@@ -713,8 +713,8 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end)
 	}
 	if (msl_idx == RTE_MAX_MEMSEG_LISTS) {
 		RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n",
-				RTE_STR(CONFIG_RTE_MAX_MEMSEG_PER_TYPE),
-				RTE_STR(CONFIG_RTE_MAX_MEM_MB_PER_TYPE));
+				RTE_STR(RTE_MAX_MEMSEG_PER_TYPE),
+				RTE_STR(RTE_MAX_MEM_MB_PER_TYPE));
 		return -1;
 	}
 
@@ -963,7 +963,7 @@ prealloc_segments(struct hugepage_file *hugepages, int n_pages)
 			}
 			if (msl_idx == RTE_MAX_MEMSEG_LISTS) {
 				RTE_LOG(ERR, EAL, "Not enough space in memseg lists, please increase %s\n",
-					RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
+					RTE_STR(RTE_MAX_MEMSEG_LISTS));
 				return -1;
 			}
 
@@ -1818,7 +1818,7 @@ memseg_primary_init_32(void)
 				if (msl_idx >= RTE_MAX_MEMSEG_LISTS) {
 					RTE_LOG(ERR, EAL,
 						"No more space in memseg lists, please increase %s\n",
-						RTE_STR(CONFIG_RTE_MAX_MEMSEG_LISTS));
+						RTE_STR(RTE_MAX_MEMSEG_LISTS));
 					return -1;
 				}
 
diff --git a/lib/librte_eal/linux/eal_timer.c b/lib/librte_eal/linux/eal_timer.c
index c0a67cfd7b..7cf15cabac 100644
--- a/lib/librte_eal/linux/eal_timer.c
+++ b/lib/librte_eal/linux/eal_timer.c
@@ -163,7 +163,7 @@ rte_eal_hpet_init(int make_default)
 		RTE_LOG(ERR, EAL, "ERROR: Cannot mmap "DEV_HPET"!\n"
 				"Please enable CONFIG_HPET_MMAP in your kernel configuration "
 				"to allow HPET support.\n"
-				"To run without using HPET, set CONFIG_RTE_LIBEAL_USE_HPET=n "
+				"To run without using HPET, unset RTE_LIBEAL_USE_HPET "
 				"in your build configuration or use '--no-hpet' EAL flag.\n");
 		close(fd);
 		internal_conf->no_hpet = 1;
diff --git a/lib/librte_eal/linux/eal_vfio_mp_sync.c b/lib/librte_eal/linux/eal_vfio_mp_sync.c
index 6254696ae5..a2accfab3a 100644
--- a/lib/librte_eal/linux/eal_vfio_mp_sync.c
+++ b/lib/librte_eal/linux/eal_vfio_mp_sync.c
@@ -17,7 +17,7 @@
  * @file
  * VFIO socket for communication between primary and secondary processes.
  *
- * This file is only compiled if CONFIG_RTE_EAL_VFIO is set to "y".
+ * This file is only compiled if RTE_EAL_VFIO is set.
  */
 
 #ifdef VFIO_PRESENT
diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index 8f631b84cf..065d87d28a 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -495,8 +495,7 @@ struct rte_mbuf {
 	 * It should only be accessed using the following functions:
 	 * rte_mbuf_refcnt_update(), rte_mbuf_refcnt_read(), and
 	 * rte_mbuf_refcnt_set(). The functionality of these functions (atomic,
-	 * or non-atomic) is controlled by the CONFIG_RTE_MBUF_REFCNT_ATOMIC
-	 * config option.
+	 * or non-atomic) is controlled by the RTE_MBUF_REFCNT_ATOMIC flag.
 	 */
 	uint16_t refcnt;
 	uint16_t nb_segs;         /**< Number of segments. */
diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h
index 376efc630b..fa2b881bd0 100644
--- a/lib/librte_rcu/rte_rcu_qsbr.h
+++ b/lib/librte_rcu/rte_rcu_qsbr.h
@@ -84,7 +84,7 @@ struct rte_rcu_qsbr_cnt {
 	 *   changes to various APIs.
 	 */
 	uint32_t lock_cnt;
-	/**< Lock counter. Used when CONFIG_RTE_LIBRTE_RCU_DEBUG is enabled */
+	/**< Lock counter. Used when RTE_LIBRTE_RCU_DEBUG is enabled */
 } __rte_cache_aligned;
 
 #define __RTE_QSBR_CNT_THR_OFFLINE 0
@@ -383,11 +383,11 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id)
  * This API is provided to aid debugging. This should be called before
  * accessing a shared data structure.
  *
- * When CONFIG_RTE_LIBRTE_RCU_DEBUG is enabled a lock counter is incremented.
+ * When RTE_LIBRTE_RCU_DEBUG is enabled a lock counter is incremented.
  * Similarly rte_rcu_qsbr_unlock will decrement the counter. When the
  * rte_rcu_qsbr_check API will verify that this counter is 0.
  *
- * When CONFIG_RTE_LIBRTE_RCU_DEBUG is disabled, this API will do nothing.
+ * When RTE_LIBRTE_RCU_DEBUG is disabled, this API will do nothing.
  *
  * @param v
  *   QS variable
@@ -416,11 +416,11 @@ rte_rcu_qsbr_lock(__rte_unused struct rte_rcu_qsbr *v,
  * This API is provided to aid debugging. This should be called after
  * accessing a shared data structure.
  *
- * When CONFIG_RTE_LIBRTE_RCU_DEBUG is enabled, rte_rcu_qsbr_unlock will
+ * When RTE_LIBRTE_RCU_DEBUG is enabled, rte_rcu_qsbr_unlock will
  * decrement a lock counter. rte_rcu_qsbr_check API will verify that this
  * counter is 0.
  *
- * When CONFIG_RTE_LIBRTE_RCU_DEBUG is disabled, this API will do nothing.
+ * When RTE_LIBRTE_RCU_DEBUG is disabled, this API will do nothing.
  *
  * @param v
  *   QS variable
-- 
2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make
  2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
                   ` (2 preceding siblings ...)
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make Thomas Monjalon
@ 2020-10-22 22:05 ` Thomas Monjalon
  2020-10-22 22:10   ` Ajit Khaparde
                     ` (2 more replies)
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 5/5] doc: remove references to make from known issues Thomas Monjalon
  2020-10-23  7:37 ` [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options David Marchand
  5 siblings, 3 replies; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-22 22:05 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain, Ajit Khaparde, Somnath Kotur,
	Jeff Guo, Haiyue Wang, Andrew Rybchenko

The config options CONFIG_RTE_* are simple RTE_* defines with meson.
Now that make support is dropped, update the names in log and comments.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/bnxt/bnxt_ethdev.c     | 2 +-
 drivers/net/ixgbe/ixgbe_rxtx.c     | 2 +-
 drivers/net/sfc/sfc_ef10_essb_rx.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 32318cfd00..1c7d1b758d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1255,7 +1255,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
 
 	if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {
 		PMD_DRV_LOG(ERR,
-			"RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
+			"RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
 			bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);
 	}
 
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index d1d3baff90..5f19972031 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -5920,7 +5920,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,
 	return 0;
 }
 
-/* Stubs needed for linkage when CONFIG_RTE_ARCH_PPC_64 is set */
+/* Stubs needed for linkage when RTE_ARCH_PPC_64 is set */
 #if defined(RTE_ARCH_PPC_64)
 int
 ixgbe_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)
diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c
index 17e4c140f5..97c81c8233 100644
--- a/drivers/net/sfc/sfc_ef10_essb_rx.c
+++ b/drivers/net/sfc/sfc_ef10_essb_rx.c
@@ -47,7 +47,7 @@
  * Each HW Rx descriptor has many Rx buffers. The number of buffers
  * in one HW Rx descriptor is equal to size of contiguous block
  * provided by Rx buffers memory pool. The contiguous block size
- * depends on CONFIG_RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB and rte_mbuf
+ * depends on RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB and rte_mbuf
  * data size specified on the memory pool creation. Typical rte_mbuf
  * data size is about 2k which makes a bit less than 32 buffers in
  * contiguous block with default bucket size equal to 64k.
-- 
2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 5/5] doc: remove references to make from known issues
  2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
                   ` (3 preceding siblings ...)
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
@ 2020-10-22 22:05 ` Thomas Monjalon
  2020-10-23  7:37 ` [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options David Marchand
  5 siblings, 0 replies; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-22 22:05 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain

The config options CONFIG_RTE_* are simple RTE_* defines with meson.
Now that make support is dropped, update the HPET config reference.

The comment about the AVX512 config option is not relevant anymore.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/known_issues.rst | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 5fb7f834f8..ee3ed1e658 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -118,8 +118,8 @@ HPET timers do not work on the Osage customer reference platform
    On Osage boards, the implementation of the ``rte_delay_us()`` function must be changed to not use the HPET timer.
 
 **Resolution/Workaround**:
-   This can be addressed by building the system with the ``CONFIG_RTE_LIBEAL_USE_HPET=n``
-   configuration option or by using the ``--no-hpet`` EAL option.
+   This can be addressed by building the system with ``RTE_LIBEAL_USE_HPET`` unset
+   or by using the ``--no-hpet`` EAL option.
 
 **Affected Environment/Platform**:
    The Osage customer reference platform.
@@ -833,10 +833,6 @@ AVX-512 support disabled
 
 **Description**:
    ``AVX-512`` support has been disabled on some conditions.
-   This shouldn't be confused with ``CONFIG_RTE_ENABLE_AVX512`` config option which is already
-   disabled by default. This config option defines if ``AVX-512`` specific implementations of
-   some file to be used or not. What has been disabled is compiler feature to produce ``AVX-512``
-   instructions from any source code.
 
    On DPDK v18.11 ``AVX-512`` is disabled for all ``GCC`` builds which reported to cause a performance
    drop.
-- 
2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
@ 2020-10-22 22:10   ` Ajit Khaparde
  2020-10-23  1:55   ` Wang, Haiyue
  2020-10-23  6:47   ` Andrew Rybchenko
  2 siblings, 0 replies; 14+ messages in thread
From: Ajit Khaparde @ 2020-10-22 22:10 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dpdk-dev, Ferruh Yigit, David Marchand, Bruce Richardson,
	Anatoly Burakov, Olivier Matz, Ciara Power, Akhil Goyal,
	fiona.trahe, john.griffin, Jain, Deepak K, Somnath Kotur,
	Jeff Guo, Haiyue Wang, Andrew Rybchenko

On Thu, Oct 22, 2020 at 3:05 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The config options CONFIG_RTE_* are simple RTE_* defines with meson.
> Now that make support is dropped, update the names in log and comments.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
For bnxt PMD,
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

> ---
>  drivers/net/bnxt/bnxt_ethdev.c     | 2 +-
>  drivers/net/ixgbe/ixgbe_rxtx.c     | 2 +-
>  drivers/net/sfc/sfc_ef10_essb_rx.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 32318cfd00..1c7d1b758d 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1255,7 +1255,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
>
>         if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {
>                 PMD_DRV_LOG(ERR,
> -                       "RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
> +                       "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
>                         bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);
>         }
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index d1d3baff90..5f19972031 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -5920,7 +5920,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,
>         return 0;
>  }
>
> -/* Stubs needed for linkage when CONFIG_RTE_ARCH_PPC_64 is set */
> +/* Stubs needed for linkage when RTE_ARCH_PPC_64 is set */
>  #if defined(RTE_ARCH_PPC_64)
>  int
>  ixgbe_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)
> diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c
> index 17e4c140f5..97c81c8233 100644
> --- a/drivers/net/sfc/sfc_ef10_essb_rx.c
> +++ b/drivers/net/sfc/sfc_ef10_essb_rx.c
> @@ -47,7 +47,7 @@
>   * Each HW Rx descriptor has many Rx buffers. The number of buffers
>   * in one HW Rx descriptor is equal to size of contiguous block
>   * provided by Rx buffers memory pool. The contiguous block size
> - * depends on CONFIG_RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB and rte_mbuf
> + * depends on RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB and rte_mbuf
>   * data size specified on the memory pool creation. Typical rte_mbuf
>   * data size is about 2k which makes a bit less than 32 buffers in
>   * contiguous block with default bucket size equal to 64k.
> --
> 2.28.0
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
  2020-10-22 22:10   ` Ajit Khaparde
@ 2020-10-23  1:55   ` Wang, Haiyue
  2020-10-23  6:47   ` Andrew Rybchenko
  2 siblings, 0 replies; 14+ messages in thread
From: Wang, Haiyue @ 2020-10-23  1:55 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: Yigit, Ferruh, david.marchand, Richardson, Bruce, Burakov,
	Anatoly, olivier.matz, Power, Ciara, akhil.goyal, Trahe, Fiona,
	Griffin, John, Jain, Deepak K, Ajit Khaparde, Somnath Kotur, Guo,
	Jia, Andrew Rybchenko

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, October 23, 2020 06:05
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; david.marchand@redhat.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>; olivier.matz@6wind.com;
> Power, Ciara <ciara.power@intel.com>; akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Guo, Jia <jia.guo@intel.com>;
> Wang, Haiyue <haiyue.wang@intel.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Subject: [PATCH 4/5] drivers: remove config prefix used with make
> 
> The config options CONFIG_RTE_* are simple RTE_* defines with meson.
> Now that make support is dropped, update the names in log and comments.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c     | 2 +-
>  drivers/net/ixgbe/ixgbe_rxtx.c     | 2 +-

For ixgbe PMD

Acked-by: Haiyue Wang <haiyue.wang@intel.com>

>  drivers/net/sfc/sfc_ef10_essb_rx.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 2.28.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make Thomas Monjalon
@ 2020-10-23  6:28   ` Ruifeng Wang
  0 siblings, 0 replies; 14+ messages in thread
From: Ruifeng Wang @ 2020-10-23  6:28 UTC (permalink / raw)
  To: thomas, dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, Akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain, Jan Viktorin, jerinj,
	Honnappa Nagarahalli, nd


> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, October 23, 2020 6:05 AM
> To: dev@dpdk.org
> Cc: ferruh.yigit@intel.com; david.marchand@redhat.com;
> bruce.richardson@intel.com; anatoly.burakov@intel.com;
> olivier.matz@6wind.com; ciara.power@intel.com; Akhil.goyal@nxp.com;
> fiona.trahe@intel.com; john.griffin@intel.com; deepak.k.jain@intel.com; Jan
> Viktorin <viktorin@rehivetech.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; jerinj@marvell.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>
> Subject: [PATCH 3/5] lib: remove config prefix used with make
> 
> The config options CONFIG_RTE_* are simple RTE_* defines with meson.
> Now that make support is dropped, update the names in logs and comments.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  lib/librte_eal/arm/include/rte_atomic_32.h  |  2 +-
> lib/librte_eal/arm/include/rte_atomic_64.h  |  2 +-
> lib/librte_eal/arm/include/rte_byteorder.h  |  2 +-
>  lib/librte_eal/arm/include/rte_mcslock.h    |  2 +-
>  lib/librte_eal/arm/include/rte_spinlock.h   |  2 +-
>  lib/librte_eal/arm/include/rte_ticketlock.h |  2 +-
>  lib/librte_eal/common/eal_common_dynmem.c   |  4 ++--
>  lib/librte_eal/freebsd/eal_memory.c         |  6 +++---
>  lib/librte_eal/linux/eal_memory.c           |  8 ++++----
>  lib/librte_eal/linux/eal_timer.c            |  2 +-
>  lib/librte_eal/linux/eal_vfio_mp_sync.c     |  2 +-
>  lib/librte_mbuf/rte_mbuf_core.h             |  3 +--
>  lib/librte_rcu/rte_rcu_qsbr.h               | 10 +++++-----
>  13 files changed, 23 insertions(+), 24 deletions(-)
> 
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 4/5] drivers: remove config prefix used with make
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
  2020-10-22 22:10   ` Ajit Khaparde
  2020-10-23  1:55   ` Wang, Haiyue
@ 2020-10-23  6:47   ` Andrew Rybchenko
  2 siblings, 0 replies; 14+ messages in thread
From: Andrew Rybchenko @ 2020-10-23  6:47 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, anatoly.burakov,
	olivier.matz, ciara.power, akhil.goyal, fiona.trahe,
	john.griffin, deepak.k.jain, Ajit Khaparde, Somnath Kotur,
	Jeff Guo, Haiyue Wang

On 10/23/20 1:05 AM, Thomas Monjalon wrote:
> The config options CONFIG_RTE_* are simple RTE_* defines with meson.
> Now that make support is dropped, update the names in log and comments.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options
  2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
                   ` (4 preceding siblings ...)
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 5/5] doc: remove references to make from known issues Thomas Monjalon
@ 2020-10-23  7:37 ` David Marchand
  2020-10-23 17:24   ` Thomas Monjalon
  5 siblings, 1 reply; 14+ messages in thread
From: David Marchand @ 2020-10-23  7:37 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Yigit, Ferruh, Bruce Richardson, Burakov, Anatoly,
	Olivier Matz, Ciara Power, Akhil Goyal, Trahe, Fiona,
	John Griffin, Deepak Kumar Jain

On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Below patches are cleaning traces of CONFIG_RTE_ after make removal,
> except one occurence in app/test/test_cryptodev.c (left as exercise).
> PS: In reality I don't know what must be done for this case about QAT.

It seems a reintroduction with raw datapath API merge.

I would apply the same as Ciara previous:
https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505

I.e.
@@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv
__rte_unused, int argc __rte_unused*/)
                        RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));

        if (gbl_driver_id == -1) {
-               RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both "
-               "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM "
-               "are enabled in config file to run this testsuite.\n");
+               RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n");
                return TEST_SKIPPED;
        }


The rest of the series looks good to me.
Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options
  2020-10-23  7:37 ` [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options David Marchand
@ 2020-10-23 17:24   ` Thomas Monjalon
  0 siblings, 0 replies; 14+ messages in thread
From: Thomas Monjalon @ 2020-10-23 17:24 UTC (permalink / raw)
  To: David Marchand
  Cc: dev, Yigit, Ferruh, Bruce Richardson, Burakov, Anatoly,
	Olivier Matz, Ciara Power, Akhil Goyal, Trahe, Fiona,
	John Griffin, Deepak Kumar Jain

23/10/2020 09:37, David Marchand:
> On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > Below patches are cleaning traces of CONFIG_RTE_ after make removal,
> > except one occurence in app/test/test_cryptodev.c (left as exercise).
> > PS: In reality I don't know what must be done for this case about QAT.
> 
> It seems a reintroduction with raw datapath API merge.
> 
> I would apply the same as Ciara previous:
> https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505
> 
> I.e.
> @@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv
> __rte_unused, int argc __rte_unused*/)
>                         RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
> 
>         if (gbl_driver_id == -1) {
> -               RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both "
> -               "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM "
> -               "are enabled in config file to run this testsuite.\n");
> +               RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n");
>                 return TEST_SKIPPED;
>         }

Yes it seems the right thing to do.

> The rest of the series looks good to me.
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied with above change



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option Thomas Monjalon
@ 2020-10-28 12:08   ` Burakov, Anatoly
  0 siblings, 0 replies; 14+ messages in thread
From: Burakov, Anatoly @ 2020-10-28 12:08 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
	ciara.power, akhil.goyal, fiona.trahe, john.griffin,
	deepak.k.jain

On 22-Oct-20 11:05 PM, Thomas Monjalon wrote:
> The main initialization function (rte_eal_init) has documentation
> about a feature from another era: memory partition.
> 
> Curiously, this lost treasure is found only now,
> suggesting there may be other interesting things to discover in the doc.
> To all aspiring Indiana Jones: the hunt is open!
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs
  2020-10-22 22:05 ` [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs Thomas Monjalon
@ 2020-10-28 12:08   ` Burakov, Anatoly
  0 siblings, 0 replies; 14+ messages in thread
From: Burakov, Anatoly @ 2020-10-28 12:08 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: ferruh.yigit, david.marchand, bruce.richardson, olivier.matz,
	ciara.power, akhil.goyal, fiona.trahe, john.griffin,
	deepak.k.jain, stable

On 22-Oct-20 11:05 PM, Thomas Monjalon wrote:
> When introducing the new option CONFIG_RTE_MAX_MEM_MB_PER_TYPE,
> some logs were referencing a wrong name: CONFIG_RTE_MAX_MEM_PER_TYPE.
> 
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-10-28 12:09 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22 22:05 [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options Thomas Monjalon
2020-10-22 22:05 ` [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option Thomas Monjalon
2020-10-28 12:08   ` Burakov, Anatoly
2020-10-22 22:05 ` [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs Thomas Monjalon
2020-10-28 12:08   ` Burakov, Anatoly
2020-10-22 22:05 ` [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make Thomas Monjalon
2020-10-23  6:28   ` Ruifeng Wang
2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
2020-10-22 22:10   ` Ajit Khaparde
2020-10-23  1:55   ` Wang, Haiyue
2020-10-23  6:47   ` Andrew Rybchenko
2020-10-22 22:05 ` [dpdk-dev] [PATCH 5/5] doc: remove references to make from known issues Thomas Monjalon
2020-10-23  7:37 ` [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options David Marchand
2020-10-23 17:24   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git