DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mempool: fix name size in mempool structure
@ 2021-10-13  8:57 Andrew Rybchenko
  2021-10-13 11:07 ` David Marchand
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Rybchenko @ 2021-10-13  8:57 UTC (permalink / raw)
  To: Olivier Matz, Zoltan Kiss; +Cc: dev

Use correct define as a name array size.

The change breaks ABI and therefore cannot be backported to
stable branches.

Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")

Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
 lib/mempool/rte_mempool.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index f57ecbd6fc..04b14d7ae9 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -209,12 +209,7 @@ struct rte_mempool_info {
  * The RTE mempool structure.
  */
 struct rte_mempool {
-	/*
-	 * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
-	 * compatibility requirements, it could be changed to
-	 * RTE_MEMPOOL_NAMESIZE next time the ABI changes
-	 */
-	char name[RTE_MEMZONE_NAMESIZE]; /**< Name of mempool. */
+	char name[RTE_MEMPOOL_NAMESIZE]; /**< Name of mempool. */
 	RTE_STD_C11
 	union {
 		void *pool_data;         /**< Ring or pool to store objects. */
-- 
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure
  2021-10-13  8:57 [dpdk-dev] [PATCH] mempool: fix name size in mempool structure Andrew Rybchenko
@ 2021-10-13 11:07 ` David Marchand
  2021-10-13 11:14   ` Andrew Rybchenko
  2021-10-13 20:58   ` Thomas Monjalon
  0 siblings, 2 replies; 5+ messages in thread
From: David Marchand @ 2021-10-13 11:07 UTC (permalink / raw)
  To: Andrew Rybchenko
  Cc: Olivier Matz, Zoltan Kiss, dev, Ray Kinsella, Thomas Monjalon

On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Use correct define as a name array size.
>
> The change breaks ABI and therefore cannot be backported to
> stable branches.
>
> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Reviewed-by: David Marchand <david.marchand@redhat.com>

Good catch, I guess we can clean ring too, quick grep:

lib/ring/rte_ring_core.h-struct rte_ring {
lib/ring/rte_ring_core.h-       /*
lib/ring/rte_ring_core.h:        * Note: this field kept the
RTE_MEMZONE_NAMESIZE size due to ABI
lib/ring/rte_ring_core.h-        * compatibility requirements, it
could be changed to RTE_RING_NAMESIZE
lib/ring/rte_ring_core.h:        * next time the ABI changes
lib/ring/rte_ring_core.h-        */
lib/ring/rte_ring_core.h-       char name[RTE_MEMZONE_NAMESIZE]
__rte_cache_aligned;


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure
  2021-10-13 11:07 ` David Marchand
@ 2021-10-13 11:14   ` Andrew Rybchenko
  2021-10-13 17:30     ` Honnappa Nagarahalli
  2021-10-13 20:58   ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Andrew Rybchenko @ 2021-10-13 11:14 UTC (permalink / raw)
  To: David Marchand
  Cc: Olivier Matz, Zoltan Kiss, dev, Ray Kinsella, Thomas Monjalon,
	Konstantin Ananyev, Honnappa Nagarahalli

On 10/13/21 2:07 PM, David Marchand wrote:
> On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Use correct define as a name array size.
>>
>> The change breaks ABI and therefore cannot be backported to
>> stable branches.
>>
>> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> Good catch, I guess we can clean ring too, quick grep:
> 
> lib/ring/rte_ring_core.h-struct rte_ring {
> lib/ring/rte_ring_core.h-       /*
> lib/ring/rte_ring_core.h:        * Note: this field kept the
> RTE_MEMZONE_NAMESIZE size due to ABI
> lib/ring/rte_ring_core.h-        * compatibility requirements, it
> could be changed to RTE_RING_NAMESIZE
> lib/ring/rte_ring_core.h:        * next time the ABI changes
> lib/ring/rte_ring_core.h-        */
> lib/ring/rte_ring_core.h-       char name[RTE_MEMZONE_NAMESIZE]
> __rte_cache_aligned;
> 
> 

Yes. I've not bothered to grep... Cc maintainers.

@David, @Konstantin, or @Honnappa, will you send a patch or
should I do?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure
  2021-10-13 11:14   ` Andrew Rybchenko
@ 2021-10-13 17:30     ` Honnappa Nagarahalli
  0 siblings, 0 replies; 5+ messages in thread
From: Honnappa Nagarahalli @ 2021-10-13 17:30 UTC (permalink / raw)
  To: Andrew Rybchenko, David Marchand
  Cc: Olivier Matz, Zoltan Kiss, dev, Ray Kinsella, thomas,
	Konstantin Ananyev, nd, nd

<snip>

> 
> On 10/13/21 2:07 PM, David Marchand wrote:
> > On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko
> > <andrew.rybchenko@oktetlabs.ru> wrote:
> >>
> >> Use correct define as a name array size.
> >>
> >> The change breaks ABI and therefore cannot be backported to stable
> >> branches.
> >>
> >> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data
> >> types")
> >>
> >> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> >
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> >
> > Good catch, I guess we can clean ring too, quick grep:
> >
> > lib/ring/rte_ring_core.h-struct rte_ring {
> > lib/ring/rte_ring_core.h-       /*
> > lib/ring/rte_ring_core.h:        * Note: this field kept the
> > RTE_MEMZONE_NAMESIZE size due to ABI
> > lib/ring/rte_ring_core.h-        * compatibility requirements, it
> > could be changed to RTE_RING_NAMESIZE
> > lib/ring/rte_ring_core.h:        * next time the ABI changes
> > lib/ring/rte_ring_core.h-        */
> > lib/ring/rte_ring_core.h-       char name[RTE_MEMZONE_NAMESIZE]
> > __rte_cache_aligned;
> >
> >
> 
> Yes. I've not bothered to grep... Cc maintainers.
> 
> @David, @Konstantin, or @Honnappa, will you send a patch or should I do?
I will send a patch

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure
  2021-10-13 11:07 ` David Marchand
  2021-10-13 11:14   ` Andrew Rybchenko
@ 2021-10-13 20:58   ` Thomas Monjalon
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-10-13 20:58 UTC (permalink / raw)
  To: Andrew Rybchenko
  Cc: dev, Olivier Matz, Zoltan Kiss, dev, Ray Kinsella, David Marchand

13/10/2021 13:07, David Marchand:
> On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
> >
> > Use correct define as a name array size.
> >
> > The change breaks ABI and therefore cannot be backported to
> > stable branches.
> >
> > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
> >
> > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-13 20:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13  8:57 [dpdk-dev] [PATCH] mempool: fix name size in mempool structure Andrew Rybchenko
2021-10-13 11:07 ` David Marchand
2021-10-13 11:14   ` Andrew Rybchenko
2021-10-13 17:30     ` Honnappa Nagarahalli
2021-10-13 20:58   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git