From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Myers, Charles" <Charles.Myers@spirent.com>,
Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU.
Date: Fri, 13 Sep 2019 19:59:25 +0100 [thread overview]
Message-ID: <53c63dd0-3eb7-a28b-278d-ac3a643f93eb@intel.com> (raw)
In-Reply-To: <9f7a6d64-9d54-f57d-3c82-9df0c11f4f33@intel.com>
On 9/13/2019 7:47 PM, Ferruh Yigit wrote:
> On 8/21/2019 3:16 AM, Myers, Charles wrote:
>> From: Charles Myers <charles.myers@spirent.com>
>>
>> When the mtu_set() function is not implemented, rte_eth_dev_set_mtu()
>> fails with -ENOTSUP and mtu is not stored in the mtu field in the
>> rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is
>> shared with hypervisor to always be set to 1500.
>>
>> This may cause issues receiving jumbo frames on Enhanced Data Path
>> N-VDS.
>>
>> Signed-off-by: Charles Myers <charles.myers@spirent.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
It seems there is waiting change request from the maintainer that I missed,
dropping the patch from the tree and updating the patchwork state.
Charles, can you please sync with Yong if the change request is not clear?
>
>
>> @@ -1205,6 +1209,18 @@ vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev)
>> }
>>
>> static int
>> +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
>> +{
>
> 'mtu' is unused and giving build error:
> error: unused parameter ‘mtu’ [-Werror=unused-parameter]
>
> Fixed while merging:
> +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu __rte_unused)
>
>
next prev parent reply other threads:[~2019-09-13 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 4:53 [dpdk-dev] [PATCH] " Myers, Charles
2019-08-20 4:06 ` [dpdk-dev] [PATCH v2] " Myers, Charles
2019-08-20 15:12 ` Stephen Hemminger
2019-09-03 20:10 ` Yong Wang
2019-08-21 2:16 ` [dpdk-dev] [PATCH v3] " Myers, Charles
2019-08-21 4:43 ` Stephen Hemminger
2019-08-21 5:19 ` Myers, Charles
2019-09-13 18:47 ` Ferruh Yigit
2019-09-13 18:59 ` Ferruh Yigit [this message]
2020-03-25 18:43 ` [dpdk-dev] [PATCH v4] " Eduard Serra
2020-03-25 18:46 ` [dpdk-dev] [PATCH v5] " Eduard Serra
2020-03-25 19:18 ` [dpdk-dev] [PATCH v6] " Eduard Serra
2020-03-31 17:31 ` Yong Wang
2020-04-01 16:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53c63dd0-3eb7-a28b-278d-ac3a643f93eb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Charles.Myers@spirent.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).