DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yong Wang <yongwang@vmware.com>
To: Eduard Serra Miralles <eserra@vmware.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.
Date: Tue, 31 Mar 2020 17:31:14 +0000	[thread overview]
Message-ID: <64523A3C-DEBB-4920-A936-47E8BD9CB594@vmware.com> (raw)
In-Reply-To: <1585163931-27895-1-git-send-email-eserra@vmware.com>


-----Original Message-----
From: Eduard Serra Miralles <eserra@vmware.com>
Date: Wednesday, March 25, 2020 at 12:19 PM
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Yong Wang <yongwang@vmware.com>
Subject: [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.

    (Picked up from @Charles Myers patch
    https://patchwork.dpdk.org/patch/57771/)
    
    When the mtu_set() function is not implemented, rte_eth_dev_set_mtu()
    fails with -ENOTSUP and mtu is not stored in the mtu field in the
    rte_eth_dev_data.  This causes the mtu in Vmxnet3_MiscConf which is
    shared with hypervisor to always be set to 1500.
    
    This may cause issues receiving jumbo frames on Enhanced Data Path
    N-VDS.
    
    Signed-off-by: Eduard Serra <eserra@vmware.com>
    Acked-by: Yong Wang <yongwang@vmware.com>
    ---

Acked-by: Yong Wang <yongwang@vmware.com>

     drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++++++++++++++++
     1 file changed, 16 insertions(+)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 705e976..c6e11ad 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -87,6 +87,7 @@ static int vmxnet3_dev_info_get(struct rte_eth_dev *dev,
     				struct rte_eth_dev_info *dev_info);
     static const uint32_t *
     vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev);
    +static int vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
     static int vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev,
     				       uint16_t vid, int on);
     static int vmxnet3_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask);
    @@ -124,6 +125,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
     	.mac_addr_set         = vmxnet3_mac_addr_set,
     	.dev_infos_get        = vmxnet3_dev_info_get,
     	.dev_supported_ptypes_get = vmxnet3_dev_supported_ptypes_get,
    +	.mtu_set              = vmxnet3_dev_mtu_set,
     	.vlan_filter_set      = vmxnet3_dev_vlan_filter_set,
     	.vlan_offload_set     = vmxnet3_dev_vlan_offload_set,
     	.rx_queue_setup       = vmxnet3_dev_rx_queue_setup,
    @@ -1166,6 +1168,8 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev,
     	dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES;
     	dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM;
     	dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS register */
    +	dev_info->min_mtu = VMXNET3_MIN_MTU;
    +	dev_info->max_mtu = VMXNET3_MAX_MTU;
     	dev_info->speed_capa = ETH_LINK_SPEED_10G;
     	dev_info->max_mac_addrs = VMXNET3_MAX_MAC_ADDRS;
     
    @@ -1212,6 +1216,18 @@ vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev)
     }
     
     static int
    +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, __rte_unused uint16_t mtu)
    +{
    +	if (dev->data->dev_started) {
    +		PMD_DRV_LOG(ERR, "Port %d must be stopped to configure MTU",
    +			    dev->data->port_id);
    +		return -EBUSY;
    +	}
    +
    +	return 0;
    +}
    +
    +static int
     vmxnet3_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
     {
     	struct vmxnet3_hw *hw = dev->data->dev_private;
    -- 
    2.7.4
    
    


  reply	other threads:[~2020-03-31 17:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  4:53 [dpdk-dev] [PATCH] " Myers, Charles
2019-08-20  4:06 ` [dpdk-dev] [PATCH v2] " Myers, Charles
2019-08-20 15:12   ` Stephen Hemminger
2019-09-03 20:10   ` Yong Wang
2019-08-21  2:16 ` [dpdk-dev] [PATCH v3] " Myers, Charles
2019-08-21  4:43   ` Stephen Hemminger
2019-08-21  5:19     ` Myers, Charles
2019-09-13 18:47   ` Ferruh Yigit
2019-09-13 18:59     ` Ferruh Yigit
2020-03-25 18:43   ` [dpdk-dev] [PATCH v4] " Eduard Serra
2020-03-25 18:46     ` [dpdk-dev] [PATCH v5] " Eduard Serra
2020-03-25 19:18       ` [dpdk-dev] [PATCH v6] " Eduard Serra
2020-03-31 17:31         ` Yong Wang [this message]
2020-04-01 16:07           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64523A3C-DEBB-4920-A936-47E8BD9CB594@vmware.com \
    --to=yongwang@vmware.com \
    --cc=dev@dpdk.org \
    --cc=eserra@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).