DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH 0/1] PPC64 buid error in 19.08
@ 2019-08-13 11:28 Christian Ehrhardt
  2019-08-13 11:28 ` [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 Christian Ehrhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Ehrhardt @ 2019-08-13 11:28 UTC (permalink / raw)
  To: dev; +Cc: Luca Boccassi, Thomas Monjalon, Frank Heimes, Christian Ehrhardt

A build of recent DPDK 19.08 on all Ubuntu architectures returned this on ppc64:
  ../drivers/net/mlx4/mlx4_rxtx.c: In function ‘mlx4_tx_burst’:
  ../drivers/net/mlx4/mlx4_rxtx.c:919:14: error: incompatible types when
    initializing type ‘__vector __bool int’ {aka ‘__vector(4) __bool int’}
    using type ‘int’
    919 |   bool tso = txq->priv->tso && (buf->ol_flags & PKT_TX_TCP_SEG);
        |              ^~~
  ../drivers/net/mlx4/mlx4_rxtx.c:938:7: error: used vector type where scalar
    is required
    938 |   if (tso) {
        |       ^~~

Which reminds everyone of the sad caps-lock story [1] which happened on 18.08.
Back then the fix was [2] and a discussion around ppc64 support state
happened, given that it wasn't even build-tested before release.

We might have to have the same discussion again, but for now I provided
the fix for the build fail on mlx4 implemented the same way as it was
done on mlx5 [2].

[1]: https://mails.dpdk.org/archives/dev/2018-August/110472.html
[2]: https://git.dpdk.org/dpdk/commit/?id=725f5dd0bfb50192a2d2341d4cc69084c2c4e03d

Christian Ehrhardt (1):
  net/mlx4: fix build on PPC64

 drivers/net/mlx4/mlx4_utils.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64
  2019-08-13 11:28 [dpdk-dev] [PATCH 0/1] PPC64 buid error in 19.08 Christian Ehrhardt
@ 2019-08-13 11:28 ` Christian Ehrhardt
  2019-08-13 23:49   ` David Christensen
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Ehrhardt @ 2019-08-13 11:28 UTC (permalink / raw)
  To: dev; +Cc: Luca Boccassi, Thomas Monjalon, Frank Heimes, Christian Ehrhardt

The AltiVec header file breaks boolean type:

error: incompatible types when initializing type
'__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'

If __APPLE_ALTIVEC__ is defined, then bool type is redefined
and conflicts with stdbool.h.

There is no good solution to fix it for the whole project without
breaking something else, so a workaround is inserted in mlx5 PMD.
This workaround is not compatible with C++ but there is no C++ in DPDK.

Related to:
https://git.dpdk.org/dpdk/commit/?id=725f5dd0bfb50192a2d2341d4cc69084c2c4e03d

Change-Id: Iceb058c07086def4176c5ab199ca4dd5018d0340
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 drivers/net/mlx4/mlx4_utils.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/mlx4/mlx4_utils.h b/drivers/net/mlx4/mlx4_utils.h
index a49190252..74b9d2ecd 100644
--- a/drivers/net/mlx4/mlx4_utils.h
+++ b/drivers/net/mlx4/mlx4_utils.h
@@ -15,6 +15,16 @@
 
 #include "mlx4.h"
 
+/*
+ * Compilation workaround for PPC64 when AltiVec is fully enabled, e.g. std=c11.
+ * Otherwise there would be a type conflict between stdbool and altivec.
+ */
+#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__)
+#undef bool
+/* redefine as in stdbool.h */
+#define bool _Bool
+#endif
+
 extern int mlx4_logtype;
 
 #ifndef NDEBUG
-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64
  2019-08-13 11:28 ` [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 Christian Ehrhardt
@ 2019-08-13 23:49   ` David Christensen
  0 siblings, 0 replies; 3+ messages in thread
From: David Christensen @ 2019-08-13 23:49 UTC (permalink / raw)
  To: Christian Ehrhardt, dev; +Cc: Luca Boccassi, Thomas Monjalon, Frank Heimes

On 8/13/19 4:28 AM, Christian Ehrhardt wrote:
> The AltiVec header file breaks boolean type:
> 
> error: incompatible types when initializing type
> '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
> 
> If __APPLE_ALTIVEC__ is defined, then bool type is redefined
> and conflicts with stdbool.h.
> 
> There is no good solution to fix it for the whole project without
> breaking something else, so a workaround is inserted in mlx5 PMD.
> This workaround is not compatible with C++ but there is no C++ in DPDK.
> 
> Related to:
> https://git.dpdk.org/dpdk/commit/?id=725f5dd0bfb50192a2d2341d4cc69084c2c4e03d
> 
> Change-Id: Iceb058c07086def4176c5ab199ca4dd5018d0340
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Tested-by: David Christensen <drc@linux.vnet.ibm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 11:28 [dpdk-dev] [PATCH 0/1] PPC64 buid error in 19.08 Christian Ehrhardt
2019-08-13 11:28 ` [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 Christian Ehrhardt
2019-08-13 23:49   ` David Christensen

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox