Re: [PATCH] ring: build with global includes

[David Marchand <david.marchand@redhat.com>]

On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote:
> > 21/11/2022 22:27, Konstantin Ananyev:
> > > From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > > e.g. i don't see.
> > > >
> > > > deps += ['eal']
> > > >
> > > > is the dependency on eal the library or just eal headers? because if it
> > > > is header only it is equivalent to telemetry i think?
> > >
> > > rte_ring.c uses bunch of EAL functions:
> > > rte_zmalloc, rte_memzone_*,  rte_log*, rte_mcfg*, etc.
> >
> > I think deps += ['eal'] is missing in ring meson file.
>
> i guess that's what i'm kind of getting at... if it was there then the
> patch i submitted is not required since depending on eal would drag in
> global_inc.

It is implicitly added, via lib/meson.build:

First eal is parsed before a lot of other components:

libraries = [
        'kvargs', # eal depends on kvargs
        'telemetry', # basic info querying
        'eal', # everything depends on eal
        'ring',

Then, there is:

    # eal is standard dependency once built
    if dpdk_conf.has('RTE_LIB_EAL')
        deps += ['eal']
    endif


-- 
David Marchand