DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] ring: build with global includes
Date: Mon, 21 Nov 2022 10:31:29 +0000	[thread overview]
Message-ID: <Y3tTgS3qdN//wPDB@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com>

On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote:
> ring has no dependencies and should be able to be built standalone but
> cannot be since it cannot find rte_config.h. this change directs meson
> to include global_inc paths just like is done with other libraries
> e.g. telemetry.
> 
> Tyler Retzlaff (1):
>   ring: build with global includes
> 
>  lib/ring/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
>

I am a little confused by this change - how do you mean built-standalone?
The ring library depends upon EAL for memory management, does it not? Also,
no DPDK library can be built on its own without the rest of the top-level
build infrastructure, which will ensure that the global-include folders are
on the include path? 

In terms of other libs, e.g. telemetry, the only reason those need the
global includes added to their include path explicitly is because those are
built ahead of EAL. Anything that depends on EAL - including ring - will
have the global includes available.

Can you explain a little more about the use-case you are looking at here,
and how you are attempting to build ring?

/Bruce 

  parent reply	other threads:[~2022-11-21 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 23:22 Tyler Retzlaff
2022-11-18 23:22 ` Tyler Retzlaff
2022-11-21 10:31 ` Bruce Richardson [this message]
2022-11-21 19:53   ` Tyler Retzlaff
2022-11-21 21:27     ` Konstantin Ananyev
2022-11-21 21:36       ` Thomas Monjalon
2022-11-21 22:48         ` Tyler Retzlaff
2022-11-22  8:51           ` David Marchand
2022-11-22  9:17             ` Bruce Richardson
2022-11-22 16:22               ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3tTgS3qdN//wPDB@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).