DPDK patches and discussions
 help / color / mirror / Atom feed
* Confirm if rte_ipv4_udptcp_cksum_verify should be experimental
@ 2022-05-26 21:39 Ben Magistro
  2022-05-30 10:43 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Magistro @ 2022-05-26 21:39 UTC (permalink / raw)
  To: dev, Olivier Matz; +Cc: ben.magistro

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

This may simply be a docs and signature mismatch (or macro wasn't available
at the time, didn't check that aspect) but the function
rte_ipv4_udptcp_cksum_verify() is marked as experimental in the signature
but not in the associated function comments (doxygen).  Should this
function be considered experimental and the docs section updated or is this
considered a stable function and the signature should updated?

Introduced in
https://patches.dpdk.org/project/dpdk/patch/20210630135158.8108-4-olivier.matz@6wind.com/


Thanks,

Ben Magistro

[-- Attachment #2: Type: text/html, Size: 751 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Confirm if rte_ipv4_udptcp_cksum_verify should be experimental
  2022-05-26 21:39 Confirm if rte_ipv4_udptcp_cksum_verify should be experimental Ben Magistro
@ 2022-05-30 10:43 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2022-05-30 10:43 UTC (permalink / raw)
  To: Ben Magistro, Olivier Matz; +Cc: ben.magistro, dev

On 5/26/2022 10:39 PM, Ben Magistro wrote:
> [CAUTION: External Email]
> This may simply be a docs and signature mismatch (or macro wasn't 
> available at the time, didn't check that aspect) but the function 
> rte_ipv4_udptcp_cksum_verify() is marked as experimental in the 
> signature but not in the associated function comments (doxygen).  Should 
> this function be considered experimental and the docs section updated or 
> is this considered a stable function and the signature should updated?
> 
> Introduced in 
> https://patches.dpdk.org/project/dpdk/patch/20210630135158.8108-4-olivier.matz@6wind.com/ 
> 
> 
> Thanks,
> 
> Ben Magistro

Hi Ben,

It looks like API is still experimental but doxygen comment is not 
added, if Oliver agrees it can be an option to remove the experimental 
tag at this stage of the API.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-30 10:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 21:39 Confirm if rte_ipv4_udptcp_cksum_verify should be experimental Ben Magistro
2022-05-30 10:43 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).