[PATCH] net/igc: disable EEE by default on I225/226

[PATCH] net/igc: disable EEE by default on I225/226

[Matthew Smith]

I226-V devices can hang when EEE is enabled. Explicitly disable
EEE during initialization of the device, as the Linux and FreeBSD
kernel drivers do.

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
---
 drivers/net/igc/base/igc_i225.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c
index 180d3cf687..17a1573064 100644
--- a/drivers/net/igc/base/igc_i225.c
+++ b/drivers/net/igc/base/igc_i225.c
@@ -122,6 +122,9 @@ static s32 igc_init_mac_params_i225(struct igc_hw *hw)
 
 	mac->ops.write_vfta = igc_write_vfta_generic;
 
+	/* Disable EEE by default */
+	dev_spec->eee_disable = true;
+
 	return IGC_SUCCESS;
 }
 
@@ -1243,6 +1246,7 @@ s32 igc_init_hw_i225(struct igc_hw *hw)
 
 	hw->phy.ops.get_cfg_done = igc_get_cfg_done_i225;
 	ret_val = igc_init_hw_base(hw);
+	igc_set_eee_i225(hw, false, false, false);
 	return ret_val;
 }
 
-- 
2.30.1 (Apple Git-130)

RE: [PATCH] net/igc: disable EEE by default on I225/226

[Zhang, Qi Z]

> -----Original Message-----
> From: Matthew Smith <mgsmith@netgate.com>
> Sent: Tuesday, June 20, 2023 10:56 PM
> To: Guo, Junfeng <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
> Cc: dev@dpdk.org; Smith, Matthew <mgsmith@netgate.com>
> Subject: [PATCH] net/igc: disable EEE by default on I225/226
> 
> I226-V devices can hang when EEE is enabled. Explicitly disable EEE during
> initialization of the device, as the Linux and FreeBSD kernel drivers do.
> 
> Signed-off-by: Matthew Smith <mgsmith@netgate.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi