* [PATCH] gpu/cuda: Add missing stdlib include
@ 2023-09-26 18:23 Aaron Conole
2023-09-29 14:58 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Aaron Conole @ 2023-09-26 18:23 UTC (permalink / raw)
To: dev; +Cc: John Romein, Elena Agostini
From: John Romein <romein@astron.nl>
getenv needs stdlib.h to be included.
Bugzilla ID: 1133
Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by: John Romein <romein@astron.nl>
---
NOTE: this is a post of https://github.com/DPDK/dpdk/pull/69 to the
mailing list.
drivers/gpu/cuda/gdrcopy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c
index 322a5dbeb20..f19ad396f14 100644
--- a/drivers/gpu/cuda/gdrcopy.c
+++ b/drivers/gpu/cuda/gdrcopy.c
@@ -2,6 +2,8 @@
* Copyright (c) 2022 NVIDIA Corporation & Affiliates
*/
+#include <stdlib.h>
+
#include "common.h"
#ifdef DRIVERS_GPU_CUDA_GDRCOPY_H
---
2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu/cuda: Add missing stdlib include
2023-09-26 18:23 [PATCH] gpu/cuda: Add missing stdlib include Aaron Conole
@ 2023-09-29 14:58 ` David Marchand
2023-10-05 12:43 ` Elena Agostini
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2023-09-29 14:58 UTC (permalink / raw)
To: Aaron Conole, John Romein; +Cc: dev, Elena Agostini, levendsayar
On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
>
>
> From: John Romein <romein@astron.nl>
>
> getenv needs stdlib.h to be included.
>
> Bugzilla ID: 1133
>
> Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> Signed-off-by: John Romein <romein@astron.nl>
Thanks for the patch, it seems to be a duplicate of the prior patch
sent by Levend:
https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu/cuda: Add missing stdlib include
2023-09-29 14:58 ` David Marchand
@ 2023-10-05 12:43 ` Elena Agostini
2023-10-06 8:09 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Elena Agostini @ 2023-10-05 12:43 UTC (permalink / raw)
To: David Marchand, Aaron Conole, John Romein; +Cc: dev, levendsayar
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Ack
Thanks
EA
From: David Marchand <david.marchand@redhat.com>
Date: Friday, 29 September 2023 at 16:58
To: Aaron Conole <aconole@redhat.com>, John Romein <romein@astron.nl>
Cc: dev@dpdk.org <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>, levendsayar@gmail.com <levendsayar@gmail.com>
Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
External email: Use caution opening links or attachments
On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
>
>
> From: John Romein <romein@astron.nl>
>
> getenv needs stdlib.h to be included.
>
> Bugzilla ID: 1133
>
> Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> Signed-off-by: John Romein <romein@astron.nl>
Thanks for the patch, it seems to be a duplicate of the prior patch
sent by Levend:
https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
--
David Marchand
[-- Attachment #2: Type: text/html, Size: 3731 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu/cuda: Add missing stdlib include
2023-10-05 12:43 ` Elena Agostini
@ 2023-10-06 8:09 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2023-10-06 8:09 UTC (permalink / raw)
To: Elena Agostini; +Cc: Aaron Conole, John Romein, dev, levendsayar
Hello,
On Thu, Oct 5, 2023 at 2:44 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> Ack
Please, don't top post.
>
>
>
> Thanks
>
> EA
>
>
>
> From: David Marchand <david.marchand@redhat.com>
> Date: Friday, 29 September 2023 at 16:58
> To: Aaron Conole <aconole@redhat.com>, John Romein <romein@astron.nl>
> Cc: dev@dpdk.org <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>, levendsayar@gmail.com <levendsayar@gmail.com>
> Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> >
> > From: John Romein <romein@astron.nl>
> >
> > getenv needs stdlib.h to be included.
> >
> > Bugzilla ID: 1133
> >
> > Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> > Signed-off-by: John Romein <romein@astron.nl>
>
> Thanks for the patch, it seems to be a duplicate of the prior patch
> sent by Levend:
> https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
As I mentionned, this is a duplicate and you just acked the other patch.
Please pay attention.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gpu/cuda: Add missing stdlib include
@ 2023-09-12 17:08 John Romein
2023-09-13 11:12 ` Aaron Conole
0 siblings, 1 reply; 6+ messages in thread
From: John Romein @ 2023-09-12 17:08 UTC (permalink / raw)
To: dev; +Cc: aconole
getenv needs stdlib.h to be included.
Bugzilla ID: 1133
Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by: John Romein <romein@astron.nl>
---
drivers/gpu/cuda/gdrcopy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c
index 322a5dbeb2..f19ad396f1 100644
--- a/drivers/gpu/cuda/gdrcopy.c
+++ b/drivers/gpu/cuda/gdrcopy.c
@@ -2,6 +2,8 @@
* Copyright (c) 2022 NVIDIA Corporation & Affiliates
*/
+#include <stdlib.h>
+
#include "common.h"
#ifdef DRIVERS_GPU_CUDA_GDRCOPY_H
--
2.39.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu/cuda: Add missing stdlib include
2023-09-12 17:08 John Romein
@ 2023-09-13 11:12 ` Aaron Conole
0 siblings, 0 replies; 6+ messages in thread
From: Aaron Conole @ 2023-09-13 11:12 UTC (permalink / raw)
To: John Romein; +Cc: dev, Elena Agostini
John Romein <romein@astron.nl> writes:
> getenv needs stdlib.h to be included.
>
> Bugzilla ID: 1133
>
> Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> Signed-off-by: John Romein <romein@astron.nl>
> ---
Hi John,
Thanks so much for the contribution. It looks like the patch got
corrupted by something. Please check your mail client settings. I'll
point out some of the specific characters here. You may also need to
switch to using a gmail server or some other mail service to email the
patch.
-Aaron
> drivers/gpu/cuda/gdrcopy.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c
> index 322a5dbeb2..f19ad396f1 100644
> --- a/drivers/gpu/cuda/gdrcopy.c
> +++ b/drivers/gpu/cuda/gdrcopy.c
> @@ -2,6 +2,8 @@
> * Copyright (c) 2022 NVIDIA Corporation & Affiliates
^ This character looks incorrect
> */
^ Same here
>
> +#include <stdlib.h>
> +
> #include "common.h"
^ Same here
> #ifdef DRIVERS_GPU_CUDA_GDRCOPY_H
^ Same here
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-06 8:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-26 18:23 [PATCH] gpu/cuda: Add missing stdlib include Aaron Conole
2023-09-29 14:58 ` David Marchand
2023-10-05 12:43 ` Elena Agostini
2023-10-06 8:09 ` David Marchand
-- strict thread matches above, loose matches on Subject: below --
2023-09-12 17:08 John Romein
2023-09-13 11:12 ` Aaron Conole
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).