test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
  2021-03-30 14:46 [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf sunqin
@ 2021-03-30  6:21 ` Sun, QinX
  2021-04-07  1:41 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Sun, QinX @ 2021-03-30  6:21 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Tuesday, March 30, 2021 10:47 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf

Tested-by: Sun Qin <qinx.sun@intel.com>

[-- Attachment #2: TestCVLAdvancedIAVFRSSGTPU.log --]
[-- Type: application/octet-stream, Size: 2664411 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
@ 2021-03-30 14:46 sunqin
  2021-03-30  6:21 ` Sun, QinX
  2021-04-07  1:41 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: sunqin @ 2021-03-30 14:46 UTC (permalink / raw)
  To: dts; +Cc: sunqin

Confirm with developer that the design of dpdk is changed for VF,
the VLAN ID needs to be set before VF receives VLAN packets.

Signed-off-by: sunqin <qinx.sun@intel.com>
---
v1: add vlan id in a common function,will be called by most of cases
v2: add vlan id only for related cases

 tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 mode change 100755 => 100644 tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py

diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
old mode 100755
new mode 100644
index 6490dcbf..3a679178
--- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
+++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
@@ -8678,34 +8678,60 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
     # vf rss gtpc gtpu
     def test_mac_ipv4_gtpu(self):
         self.switch_testpmd(symmetric=False)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+        self.pmd_output.execute_cmd('rx_vlan add 3 0')
+        self.pmd_output.execute_cmd('rx_vlan add 5 0')
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_toeplitz)
 
     def test_mac_ipv6_gtpu(self):
         self.switch_testpmd(symmetric=False)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+        self.pmd_output.execute_cmd('rx_vlan add 5 0')
+        self.pmd_output.execute_cmd('rx_vlan add 7 0')
+
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_toeplitz)
 
     def test_mac_ipv4_gtpc(self):
         self.switch_testpmd(symmetric=False)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+        self.pmd_output.execute_cmd('rx_vlan add 3 0')
+        self.pmd_output.execute_cmd('rx_vlan add 5 0')
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_toeplitz)
 
     def test_mac_ipv6_gtpc(self):
         self.switch_testpmd(symmetric=False)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+        self.pmd_output.execute_cmd('rx_vlan add 5 0')
+        self.pmd_output.execute_cmd('rx_vlan add 3 0')
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_toeplitz)
 
     def test_mac_ipv4_gtpu_symmetric(self):
         self.switch_testpmd(symmetric=True)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_symmetric_toeplitz)
 
     def test_mac_ipv6_gtpu_symmetric(self):
         self.switch_testpmd(symmetric=True)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_symmetric_toeplitz)
 
     def test_mac_ipv4_gtpc_symmetric(self):
         self.switch_testpmd(symmetric=True)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_symmetric_toeplitz)
 
     def test_mac_ipv6_gtpc_symmetric(self):
         self.switch_testpmd(symmetric=True)
+        self.pmd_output.execute_cmd('vlan set filter on 0')
+        self.pmd_output.execute_cmd('rx_vlan add 1 0')
+
         self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_symmetric_toeplitz)
 
     def tear_down(self):
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
  2021-03-30 14:46 [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf sunqin
  2021-03-30  6:21 ` Sun, QinX
@ 2021-04-07  1:41 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-04-07  1:41 UTC (permalink / raw)
  To: Sun, QinX, dts; +Cc: Sun, QinX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of sunqin
> Sent: 2021年3月30日 22:47
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
> 
> Confirm with developer that the design of dpdk is changed for VF, the VLAN ID
> needs to be set before VF receives VLAN packets.
> 
> Signed-off-by: sunqin <qinx.sun@intel.com>
> ---
> v1: add vlan id in a common function,will be called by most of cases
> v2: add vlan id only for related cases
> 
>  tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  mode change 100755 => 100644
> tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> 
> diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> old mode 100755
> new mode 100644
> index 6490dcbf..3a679178
> --- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> +++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> @@ -8678,34 +8678,60 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
>      # vf rss gtpc gtpu
>      def test_mac_ipv4_gtpu(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')

Add vlan id in every related test cases, but never remove them, in the following cases the setting is still valid.

For example, add vlan id 1, 3, 5 in test case #1, when running test case #2 the setting is still there.

Could you please consider what's the best way to achieve your target and least impact to other cases.

> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_toeplitz)
> 
>      def test_mac_ipv6_gtpu(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 7 0')
> +
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_toeplitz)
> 
>      def test_mac_ipv4_gtpc(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_toeplitz)
> 
>      def test_mac_ipv6_gtpc(self):
>          self.switch_testpmd(symmetric=False)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 5 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 3 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_toeplitz)
> 
>      def test_mac_ipv4_gtpu_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_symmet
> ric_toeplitz)
> 
>      def test_mac_ipv6_gtpu_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_symmet
> ric_toeplitz)
> 
>      def test_mac_ipv4_gtpc_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_symmet
> ric_toeplitz)
> 
>      def test_mac_ipv6_gtpc_symmetric(self):
>          self.switch_testpmd(symmetric=True)
> +        self.pmd_output.execute_cmd('vlan set filter on 0')
> +        self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +
> 
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_symmet
> ric_toeplitz)
> 
>      def tear_down(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-07  1:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 14:46 [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf sunqin
2021-03-30  6:21 ` Sun, QinX
2021-04-07  1:41 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git