test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function.
@ 2020-02-26  9:18 zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
                   ` (8 more replies)
  0 siblings, 9 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai

Remove parameters:"--socket-mem 1024,1024"

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_perf_virtio_user_pvp.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/TestSuite_perf_virtio_user_pvp.py b/tests/TestSuite_perf_virtio_user_pvp.py
index 2073426..12031c3 100644
--- a/tests/TestSuite_perf_virtio_user_pvp.py
+++ b/tests/TestSuite_perf_virtio_user_pvp.py
@@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
             eal_params = self.dut.create_eal_parameters(cores=self.core_list_host,
                             ports=[0], prefix='vhost')
         command_line_client = self.target + "/app/testpmd %s " + \
-                        "--socket-mem 1024,1024 "  \
                         "--vdev 'net_vhost0,iface=vhost-net,queues=1' " + \
                         "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
         command_line_client = command_line_client % (eal_params, len(self.core_list_host)-1,
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/pvp_diff_qemu_version:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_pvp_diff_qemu_version.py | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_pvp_diff_qemu_version.py b/tests/TestSuite_pvp_diff_qemu_version.py
index 226693f..77db6ce 100644
--- a/tests/TestSuite_pvp_diff_qemu_version.py
+++ b/tests/TestSuite_pvp_diff_qemu_version.py
@@ -63,8 +63,6 @@ class TestVhostPVPDiffQemuVersion(TestCase):
         self.verify(self.cores_num >= 3,
                     "There has not enought cores to test this suite")
         self.cores = self.dut.get_core_list("1S/3C/1T", socket=self.socket)
-        self.coremask = utils.create_mask(self.cores)
-        self.memory_channel = 4
         self.vm_dut = None
         self.packet_params_set()
 
@@ -82,6 +80,7 @@ class TestVhostPVPDiffQemuVersion(TestCase):
         # create an instance to set stream field setting
         self.pktgen_helper = PacketGeneratorHelper()
         self.base_dir = self.dut.base_dir.replace('~', '/root')
+        self.pci_info = self.dut.ports_info[0]['pci']
 
     def set_up(self):
         """
@@ -201,12 +200,11 @@ class TestVhostPVPDiffQemuVersion(TestCase):
         """
         Launch the vhost testpmd
         """
-        command_line_client = self.dut.target + "/app/testpmd -n %d -c %s \
-            --socket-mem 1024,1024 --file-prefix=vhost \
-            --vdev 'eth_vhost0,iface=%s/vhost-net,queues=1' -- \
-            -i --nb-cores=1 --txd=1024 --rxd=1024"
-        command_line_client = command_line_client % (
-                              self.memory_channel, self.coremask, self.base_dir)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"--vdev 'eth_vhost0,iface=%s/vhost-net,queues=1'" % self.base_dir]
+        eal_params = self.dut.create_eal_parameters(cores=self.cores, prefix='vhost', ports=[self.pci_info], vdevs=vdev)
+        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
+        command_line_client = testcmd + eal_params + para
         self.vhost.send_expect(command_line_client, "testpmd> ", 30)
         self.vhost.send_expect("set fwd mac", "testpmd> ", 30)
         self.vhost.send_expect("start", "testpmd> ", 30)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 .../TestSuite_pvp_qemu_multi_paths_port_restart.py | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_pvp_qemu_multi_paths_port_restart.py b/tests/TestSuite_pvp_qemu_multi_paths_port_restart.py
index ea2e1cd..f10e2a6 100644
--- a/tests/TestSuite_pvp_qemu_multi_paths_port_restart.py
+++ b/tests/TestSuite_pvp_qemu_multi_paths_port_restart.py
@@ -61,7 +61,6 @@ class TestPVPQemuMultiPathPortRestart(TestCase):
         self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
         self.core_list = self.dut.get_core_list(
             self.core_config, socket=self.ports_socket)
-        self.core_mask = utils.create_mask(self.core_list)
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
         self.vm_dut = None
         self.virtio1_mac = "52:54:00:00:00:01"
@@ -72,6 +71,7 @@ class TestPVPQemuMultiPathPortRestart(TestCase):
             self.tester.send_expect('mkdir -p %s' % self.out_path, '# ')
         # create an instance to set stream field setting
         self.pktgen_helper = PacketGeneratorHelper()
+        self.pci_info = self.dut.ports_info[0]['pci']
 
     def set_up(self):
         """
@@ -94,13 +94,11 @@ class TestPVPQemuMultiPathPortRestart(TestCase):
         """
         self.dut.send_expect("killall -s INT testpmd", "#")
         self.dut.send_expect("rm -rf ./vhost-net*", "#")
-        command_client = self.dut.target + "/app/testpmd " + \
-                         " -n %d -c %s --socket-mem 1024,1024 " + \
-                         " --legacy-mem --file-prefix=vhost " + \
-                         " --vdev 'net_vhost0,iface=vhost-net,queues=1' " + \
-                         " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
-        command_line_client = command_client % (
-            self.dut.get_memory_channels(), self.core_mask)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"--vdev 'net_vhost0,iface=vhost-net,queues=1'"]
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list, prefix='vhost', ports=[self.pci_info], vdevs=vdev)
+        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
+        command_line_client = testcmd + eal_params + para
         self.vhost.send_expect(command_line_client, "testpmd> ", 120)
         self.vhost.send_expect("set fwd mac", "testpmd> ", 120)
         self.vhost.send_expect("start", "testpmd> ", 120)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-27  9:52   ` Zhu, ShuaiX
  2020-03-03  5:41   ` Tu, Lijuan
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
                   ` (5 subsequent siblings)
  8 siblings, 2 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_pvp_vhost_user_reconnect.py | 26 +++++++--------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_pvp_vhost_user_reconnect.py b/tests/TestSuite_pvp_vhost_user_reconnect.py
index 7b201a0..f361373 100644
--- a/tests/TestSuite_pvp_vhost_user_reconnect.py
+++ b/tests/TestSuite_pvp_vhost_user_reconnect.py
@@ -56,10 +56,9 @@ class TestPVPVhostUserReconnect(TestCase):
         # Get the port's socket
         self.pf = self.dut_ports[0]
         netdev = self.dut.ports_info[self.pf]['port']
+        self.pci_info = self.dut.ports_info[0]['pci']
         self.socket = netdev.get_nic_socket()
         self.cores = self.dut.get_core_list("1S/2C/1T", socket=self.socket)
-        self.coremask = utils.create_mask(self.cores)
-        self.memory_channel = self.dut.get_memory_channels()
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
         # set diff arg about mem_socket base on socket number
         if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
@@ -101,14 +100,10 @@ class TestPVPVhostUserReconnect(TestCase):
         vdev_info = ""
         for i in range(self.vm_num):
             vdev_info += "--vdev 'net_vhost%d,iface=vhost-net%d,client=1,queues=1' " % (i, i)
-        self.vhostapp_testcmd = self.dut.base_dir + \
-                    "/%s/app/testpmd -c %s -n %d --socket-mem %s --legacy-mem" + \
-                    " --file-prefix=vhost %s" + \
-                    " -- -i --port-topology=chained --nb-cores=1" + \
-                    " --txd=1024 --rxd=1024"
-        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
-                                self.coremask, self.memory_channel,
-                                self.socket_mem, vdev_info)
+        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
+        eal_params = self.dut.create_eal_parameters(cores=self.cores, prefix='vhost', ports=[self.pci_info])
+        para = " -- -i --port-topology=chained --nb-cores=1 --txd=1024 --rxd=1024"
+        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
         self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ", 40)
         self.vhost_user.send_expect("set fwd mac", "testpmd> ", 40)
         self.vhost_user.send_expect("start", "testpmd> ", 40)
@@ -120,13 +115,10 @@ class TestPVPVhostUserReconnect(TestCase):
         vdev_info = ""
         for i in range(self.vm_num):
             vdev_info += "--vdev 'net_vhost%d,iface=vhost-net%d,client=1,queues=1' " % (i, i)
-        self.vhostapp_testcmd = self.dut.base_dir + \
-                    "/%s/app/testpmd -c %s -n %d --socket-mem %s --legacy-mem" + \
-                    " --no-pci --file-prefix=vhost %s" + \
-                    " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
-        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
-                                self.coremask, self.memory_channel,
-                                self.socket_mem, vdev_info)
+        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
+        eal_params = self.dut.create_eal_parameters(cores=self.cores, no_pci=True, prefix='vhost', ports=[self.pci_info])
+        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
+        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
         self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ", 40)
         self.vhost_user.send_expect("start", "testpmd> ", 40)
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/pvp_virtio_bonding:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
                   ` (2 preceding siblings ...)
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-27  9:52   ` Zhu, ShuaiX
  2020-03-03  5:41   ` Tu, Lijuan
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
                   ` (4 subsequent siblings)
  8 siblings, 2 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai

Remove parameters:"--socket-mem 2048,2048 --legacy-mem"

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_pvp_virtio_bonding.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_pvp_virtio_bonding.py b/tests/TestSuite_pvp_virtio_bonding.py
index 1405b0b..b551487 100644
--- a/tests/TestSuite_pvp_virtio_bonding.py
+++ b/tests/TestSuite_pvp_virtio_bonding.py
@@ -88,7 +88,7 @@ class TestPVPVirtIOBonding(TestCase):
         for i in range(self.queues):
             vdev_info += "--vdev 'net_vhost%d,iface=vhost-net%d,client=1,queues=1' " % (i, i)
         params = "--port-topology=chained --nb-cores=4 --txd=1024 --rxd=1024"
-        eal_param = "--socket-mem 2048,2048 --legacy-mem --file-prefix=vhost %s " % vdev_info
+        eal_param = "--file-prefix=vhost %s " % vdev_info
         self.vhost_testpmd = PmdOutput(self.dut)
         self.vhost_testpmd.start_testpmd(self.core_config, params, eal_param=eal_param)
         self.vhost_testpmd.execute_cmd('set fwd mac')
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
                   ` (3 preceding siblings ...)
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 .../TestSuite_pvp_virtio_user_2M_hugepages.py | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/tests/TestSuite_pvp_virtio_user_2M_hugepages.py b/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
index 5531e0b..35572d8 100644
--- a/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
+++ b/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
@@ -61,9 +61,6 @@ class TestPVPVirtioWith2Mhuge(TestCase):
 
         self.core_list_virtio_user = self.core_list[0:2]
         self.core_list_vhost_user = self.core_list[2:4]
-        self.core_mask_virtio_user = utils.create_mask(self.core_list_virtio_user)
-        self.core_mask_vhost_user = utils.create_mask(self.core_list_vhost_user)
-        self.mem_channels = self.dut.get_memory_channels()
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
         self.header_size = HEADER_SIZE['eth'] + HEADER_SIZE['ip'] + HEADER_SIZE['tcp']
         self.frame_sizes = [64, 128, 256, 512, 1024, 1518]
@@ -77,6 +74,7 @@ class TestPVPVirtioWith2Mhuge(TestCase):
             self.tester.send_expect('mkdir -p %s' % self.out_path, '# ')
         # create an instance to set stream field setting
         self.pktgen_helper = PacketGeneratorHelper()
+        self.pci_info = self.dut.ports_info[0]['pci']
 
     def set_up(self):
         """
@@ -129,11 +127,10 @@ class TestPVPVirtioWith2Mhuge(TestCase):
         """
         start testpmd on vhost
         """
-        command_line_client = "%s/app/testpmd -c %s -n %d " + \
-                              "--socket-mem 1024,1024 --file-prefix=vhost " + \
-                              "--vdev 'net_vhost0,iface=vhost-net,queues=1' -- -i"
-        command_line_client = command_line_client % (self.target,
-                        self.core_mask_vhost_user, self.mem_channels)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"--vdev 'net_vhost0,iface=vhost-net,queues=1'"]
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost_user, prefix='vhost', ports=[self.pci_info], vdevs=vdev)
+        command_line_client = testcmd + eal_params + " -- -i"
         self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
         self.vhost_user.send_expect("start", "testpmd> ", 120)
 
@@ -141,12 +138,10 @@ class TestPVPVirtioWith2Mhuge(TestCase):
         """
         start testpmd on virtio
         """
-        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
-                            "--no-pci --socket-mem 1024,1024 " + \
-                            "--file-prefix=virtio-user --single-file-segments " + \
-                            "--vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 -- -i"
-        command_line_user = command_line_user % (self.target,
-                self.mem_channels, self.core_mask_virtio_user)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = " --single-file-segments --vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 -- -i"
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list_virtio_user, no_pci=True, prefix='virtio-user', ports=[self.pci_info])
+        command_line_user = testcmd + eal_params + vdev
         self.virtio_user.send_expect(command_line_user, "testpmd> ", 120)
         self.virtio_user.send_expect("start", "testpmd> ", 120)
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
                   ` (4 preceding siblings ...)
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-27  9:54   ` Zhu, ShuaiX
  2020-03-03  5:41   ` Tu, Lijuan
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/virtio_pvp_regression:add " zhu,shuai
                   ` (2 subsequent siblings)
  8 siblings, 2 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_pvp_virtio_user_4k_pages.py | 24 +++++++++------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/tests/TestSuite_pvp_virtio_user_4k_pages.py b/tests/TestSuite_pvp_virtio_user_4k_pages.py
index 95b5494..5e6f657 100644
--- a/tests/TestSuite_pvp_virtio_user_4k_pages.py
+++ b/tests/TestSuite_pvp_virtio_user_4k_pages.py
@@ -65,9 +65,7 @@ class TestPvpVirtioUser4kPages(TestCase):
             self.core_config, socket=self.ports_socket)
         self.core_list_virtio_user = self.core_list[0:2]
         self.core_list_vhost_user = self.core_list[2:4]
-        self.core_mask_virtio_user = utils.create_mask(self.core_list_virtio_user)
-        self.core_mask_vhost_user = utils.create_mask(self.core_list_vhost_user)
-        self.mem_channels = self.dut.get_memory_channels()
+        self.pci_info = self.dut.ports_info[0]['pci']
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
         self.frame_sizes = [64, 128, 256, 512, 1024, 1518]
         self.logger.info("You can config packet_size in file %s.cfg," % self.suite_name + \
@@ -131,12 +129,11 @@ class TestPvpVirtioUser4kPages(TestCase):
         """
         Start testpmd on vhost
         """
-        command_line_client = "%s/app/testpmd -c %s -n %d " + \
-                              "--file-prefix=vhost  -m 1024 --no-huge " + \
-                              "--vdev 'net_vhost0,iface=vhost-net,queues=1' -- -i " + \
-                              "--no-numa --socket-num=%d"
-        command_line_client = command_line_client % (self.target,
-                            self.core_mask_vhost_user, self.mem_channels, self.ports_socket)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = " -m 1024 --no-huge --vdev 'net_vhost0,iface=vhost-net,queues=1'"
+        para = " -- -i --no-numa --socket-num=%d" % self.ports_socket
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list_vhost_user, prefix='vhost', ports=[self.pci_info])
+        command_line_client = testcmd + eal_params + vdev + para
         self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
         self.vhost_user.send_expect("start", "testpmd> ", 120)
 
@@ -144,11 +141,10 @@ class TestPvpVirtioUser4kPages(TestCase):
         """
         Start testpmd on virtio
         """
-        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
-                            "--no-huge -m 1024 --file-prefix=virtio-user " + \
-                            "--vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 -- -i"
-        command_line_user = command_line_user % (self.target,
-                self.mem_channels, self.core_mask_virtio_user)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = " --no-huge -m 1024 --vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 -- -i"
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list_virtio_user, prefix='virtio-user', ports=[self.pci_info])
+        command_line_user = testcmd + eal_params + vdev
         self.virtio_user.send_expect(command_line_user, "testpmd> ", 120)
         self.virtio_user.send_expect("set fwd mac", "testpmd> ", 120)
         self.virtio_user.send_expect("start", "testpmd> ", 120)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [dts] [PATCH V1] tests/virtio_pvp_regression:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
                   ` (5 preceding siblings ...)
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
@ 2020-02-26  9:18 ` " zhu,shuai
  2020-02-27  9:51 ` [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " Zhu, ShuaiX
  2020-03-03  5:29 ` Tu, Lijuan
  8 siblings, 0 replies; 19+ messages in thread
From: zhu,shuai @ 2020-02-26  9:18 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai



Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_virtio_pvp_regression.py | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/tests/TestSuite_virtio_pvp_regression.py b/tests/TestSuite_virtio_pvp_regression.py
index e03048e..90836e3 100644
--- a/tests/TestSuite_virtio_pvp_regression.py
+++ b/tests/TestSuite_virtio_pvp_regression.py
@@ -57,14 +57,13 @@ class TestVirtioPVPRegression(TestCase):
         self.pf = self.dut_ports[0]
         # Get the port's socket
         netdev = self.dut.ports_info[self.pf]['port']
+        self.pci_info = self.dut.ports_info[self.pf]['pci']
         self.socket = netdev.get_nic_socket()
         self.cores = self.dut.get_core_list("1S/3C/1T", socket=self.socket)
 
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
         self.verify(len(self.cores) >= 3,
                     "There has not enought cores to test this suite")
-        self.coremask = utils.create_mask(self.cores)
-        self.memory_channel = self.dut.get_memory_channels()
         self.port_number = 2
         self.queues_number = 2
         self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
@@ -248,15 +247,11 @@ class TestVirtioPVPRegression(TestCase):
         """
         Launch the vhost testpmd
         """
-        command_line_client = self.dut.target + "/app/testpmd -n %d -c %s \
-            --socket-mem %s --file-prefix=vhost -w %s \
-            --vdev 'eth_vhost0,iface=%s/vhost-net,queues=%d,client=1' -- \
-            -i --nb-cores=%d --rxq=%d --txq=%d  --txd=1024 --rxd=1024"
-        command_line_client = command_line_client % (
-                        self.memory_channel, self.coremask, self.socket_mem,
-                        self.dut.ports_info[self.pf]['pci'], self.base_dir,
-                        self.queues_number, self.queues_number, self.queues_number,
-                        self.queues_number)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"--vdev 'eth_vhost0,iface=%s/vhost-net,queues=%d,client=1'" % (self.base_dir, self.queues_number)]
+        eal_params = self.dut.create_eal_parameters(cores=self.cores, prefix='vhost', ports=[self.pci_info], vdevs=vdev)
+        para = " -- -i --nb-cores=%d --rxq=%d --txq=%d  --txd=1024 --rxd=1024" % (self.queues_number, self.queues_number, self.queues_number)
+        command_line_client = testcmd + eal_params + para
         self.vhost.send_expect(command_line_client, "testpmd> ", 30)
         self.vhost.send_expect("set fwd mac", "testpmd> ", 30)
         self.vhost.send_expect("start", "testpmd> ", 30)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
                   ` (6 preceding siblings ...)
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/virtio_pvp_regression:add " zhu,shuai
@ 2020-02-27  9:51 ` " Zhu, ShuaiX
  2020-03-03  5:29 ` Tu, Lijuan
  8 siblings, 0 replies; 19+ messages in thread
From: Zhu, ShuaiX @ 2020-02-27  9:51 UTC (permalink / raw)
  To: dts; +Cc: Zhu, ShuaiX

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: Zhu, ShuaiX
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts][PATCH V1] tests/perf_virtio_user_pvp:add
> create_eal_parameters function.
> 
> Remove parameters:"--socket-mem 1024,1024"
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_perf_virtio_user_pvp.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_perf_virtio_user_pvp.py
> b/tests/TestSuite_perf_virtio_user_pvp.py
> index 2073426..12031c3 100644
> --- a/tests/TestSuite_perf_virtio_user_pvp.py
> +++ b/tests/TestSuite_perf_virtio_user_pvp.py
> @@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
>              eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_host,
>                              ports=[0], prefix='vhost')
>          command_line_client = self.target + "/app/testpmd %s " + \
> -                        "--socket-mem 1024,1024 "  \
>                          "--vdev 'net_vhost0,iface=vhost-net,queues=1' " + \
>                          "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
>          command_line_client = command_line_client % (eal_params,
> len(self.core_list_host)-1,
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add create_eal_parameters function.
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
@ 2020-02-27  9:52   ` Zhu, ShuaiX
  2020-03-03  5:41   ` Tu, Lijuan
  1 sibling, 0 replies; 19+ messages in thread
From: Zhu, ShuaiX @ 2020-02-27  9:52 UTC (permalink / raw)
  To: dts; +Cc: Zhu, ShuaiX

[-- Attachment #1: Type: text/plain, Size: 4109 bytes --]

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: Zhu, ShuaiX
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts][PATCH V1] tests/pvp_vhost_user_reconnect:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_vhost_user_reconnect.py | 26 +++++++--------------
>  1 file changed, 9 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_vhost_user_reconnect.py
> b/tests/TestSuite_pvp_vhost_user_reconnect.py
> index 7b201a0..f361373 100644
> --- a/tests/TestSuite_pvp_vhost_user_reconnect.py
> +++ b/tests/TestSuite_pvp_vhost_user_reconnect.py
> @@ -56,10 +56,9 @@ class TestPVPVhostUserReconnect(TestCase):
>          # Get the port's socket
>          self.pf = self.dut_ports[0]
>          netdev = self.dut.ports_info[self.pf]['port']
> +        self.pci_info = self.dut.ports_info[0]['pci']
>          self.socket = netdev.get_nic_socket()
>          self.cores = self.dut.get_core_list("1S/2C/1T", socket=self.socket)
> -        self.coremask = utils.create_mask(self.cores)
> -        self.memory_channel = self.dut.get_memory_channels()
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          # set diff arg about mem_socket base on socket number
>          if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
> @@ -101,14 +100,10 @@ class TestPVPVhostUserReconnect(TestCase):
>          vdev_info = ""
>          for i in range(self.vm_num):
>              vdev_info += "--vdev
> 'net_vhost%d,iface=vhost-net%d,client=1,queues=1' " % (i, i)
> -        self.vhostapp_testcmd = self.dut.base_dir + \
> -                    "/%s/app/testpmd -c %s -n %d --socket-mem %s
> --legacy-mem" + \
> -                    " --file-prefix=vhost %s" + \
> -                    " -- -i --port-topology=chained --nb-cores=1" + \
> -                    " --txd=1024 --rxd=1024"
> -        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
> -                                self.coremask, self.memory_channel,
> -                                self.socket_mem, vdev_info)
> +        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
> +        eal_params = self.dut.create_eal_parameters(cores=self.cores,
> prefix='vhost', ports=[self.pci_info])
> +        para = " -- -i --port-topology=chained --nb-cores=1 --txd=1024
> --rxd=1024"
> +        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
>          self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ",
> 40)
>          self.vhost_user.send_expect("set fwd mac", "testpmd> ", 40)
>          self.vhost_user.send_expect("start", "testpmd> ", 40) @@ -120,13
> +115,10 @@ class TestPVPVhostUserReconnect(TestCase):
>          vdev_info = ""
>          for i in range(self.vm_num):
>              vdev_info += "--vdev
> 'net_vhost%d,iface=vhost-net%d,client=1,queues=1' " % (i, i)
> -        self.vhostapp_testcmd = self.dut.base_dir + \
> -                    "/%s/app/testpmd -c %s -n %d --socket-mem %s
> --legacy-mem" + \
> -                    " --no-pci --file-prefix=vhost %s" + \
> -                    " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> -        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
> -                                self.coremask, self.memory_channel,
> -                                self.socket_mem, vdev_info)
> +        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
> +        eal_params = self.dut.create_eal_parameters(cores=self.cores,
> no_pci=True, prefix='vhost', ports=[self.pci_info])
> +        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> +        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
>          self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ",
> 40)
>          self.vhost_user.send_expect("start", "testpmd> ", 40)
> 
> --
> 2.17.2


[-- Attachment #2: TestPVPVhostUserReconnect.log --]
[-- Type: application/octet-stream, Size: 1018091 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_virtio_bonding:add create_eal_parameters function.
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
@ 2020-02-27  9:52   ` Zhu, ShuaiX
  2020-03-03  5:41   ` Tu, Lijuan
  1 sibling, 0 replies; 19+ messages in thread
From: Zhu, ShuaiX @ 2020-02-27  9:52 UTC (permalink / raw)
  To: dts; +Cc: Zhu, ShuaiX

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: Zhu, ShuaiX
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts][PATCH V1] tests/pvp_virtio_bonding:add create_eal_parameters
> function.
> 
> Remove parameters:"--socket-mem 2048,2048 --legacy-mem"
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_bonding.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_bonding.py
> b/tests/TestSuite_pvp_virtio_bonding.py
> index 1405b0b..b551487 100644
> --- a/tests/TestSuite_pvp_virtio_bonding.py
> +++ b/tests/TestSuite_pvp_virtio_bonding.py
> @@ -88,7 +88,7 @@ class TestPVPVirtIOBonding(TestCase):
>          for i in range(self.queues):
>              vdev_info += "--vdev
> 'net_vhost%d,iface=vhost-net%d,client=1,queues=1' " % (i, i)
>          params = "--port-topology=chained --nb-cores=4 --txd=1024
> --rxd=1024"
> -        eal_param = "--socket-mem 2048,2048 --legacy-mem
> --file-prefix=vhost %s " % vdev_info
> +        eal_param = "--file-prefix=vhost %s " % vdev_info
>          self.vhost_testpmd = PmdOutput(self.dut)
>          self.vhost_testpmd.start_testpmd(self.core_config, params,
> eal_param=eal_param)
>          self.vhost_testpmd.execute_cmd('set fwd mac')
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add create_eal_parameters function.
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
@ 2020-02-27  9:54   ` Zhu, ShuaiX
  2020-03-03  5:41   ` Tu, Lijuan
  1 sibling, 0 replies; 19+ messages in thread
From: Zhu, ShuaiX @ 2020-02-27  9:54 UTC (permalink / raw)
  To: dts; +Cc: Zhu, ShuaiX

[-- Attachment #1: Type: text/plain, Size: 3878 bytes --]

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: Zhu, ShuaiX
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts][PATCH V1] tests/pvp_virtio_user_4k_pages:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_user_4k_pages.py | 24 +++++++++------------
>  1 file changed, 10 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_4k_pages.py
> b/tests/TestSuite_pvp_virtio_user_4k_pages.py
> index 95b5494..5e6f657 100644
> --- a/tests/TestSuite_pvp_virtio_user_4k_pages.py
> +++ b/tests/TestSuite_pvp_virtio_user_4k_pages.py
> @@ -65,9 +65,7 @@ class TestPvpVirtioUser4kPages(TestCase):
>              self.core_config, socket=self.ports_socket)
>          self.core_list_virtio_user = self.core_list[0:2]
>          self.core_list_vhost_user = self.core_list[2:4]
> -        self.core_mask_virtio_user =
> utils.create_mask(self.core_list_virtio_user)
> -        self.core_mask_vhost_user =
> utils.create_mask(self.core_list_vhost_user)
> -        self.mem_channels = self.dut.get_memory_channels()
> +        self.pci_info = self.dut.ports_info[0]['pci']
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          self.frame_sizes = [64, 128, 256, 512, 1024, 1518]
>          self.logger.info("You can config packet_size in file %s.cfg," %
> self.suite_name + \ @@ -131,12 +129,11 @@ class
> TestPvpVirtioUser4kPages(TestCase):
>          """
>          Start testpmd on vhost
>          """
> -        command_line_client = "%s/app/testpmd -c %s -n %d " + \
> -                              "--file-prefix=vhost  -m 1024 --no-huge " + \
> -                              "--vdev
> 'net_vhost0,iface=vhost-net,queues=1' -- -i " + \
> -                              "--no-numa --socket-num=%d"
> -        command_line_client = command_line_client % (self.target,
> -                            self.core_mask_vhost_user,
> self.mem_channels, self.ports_socket)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " -m 1024 --no-huge --vdev
> 'net_vhost0,iface=vhost-net,queues=1'"
> +        para = " -- -i --no-numa --socket-num=%d" % self.ports_socket
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost_user, prefix='vhost',
> ports=[self.pci_info])
> +        command_line_client = testcmd + eal_params + vdev + para
>          self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
>          self.vhost_user.send_expect("start", "testpmd> ", 120)
> 
> @@ -144,11 +141,10 @@ class TestPvpVirtioUser4kPages(TestCase):
>          """
>          Start testpmd on virtio
>          """
> -        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
> -                            "--no-huge -m 1024 --file-prefix=virtio-user " + \
> -
> "--vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> -        command_line_user = command_line_user % (self.target,
> -                self.mem_channels, self.core_mask_virtio_user)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " --no-huge -m 1024
> --vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_virtio_user,
> prefix='virtio-user', ports=[self.pci_info])
> +        command_line_user = testcmd + eal_params + vdev
>          self.virtio_user.send_expect(command_line_user, "testpmd> ", 120)
>          self.virtio_user.send_expect("set fwd mac", "testpmd> ", 120)
>          self.virtio_user.send_expect("start", "testpmd> ", 120)
> --
> 2.17.2


[-- Attachment #2: TestPvpVirtioUser4kPages.log --]
[-- Type: application/octet-stream, Size: 31989 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function.
  2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
                   ` (7 preceding siblings ...)
  2020-02-27  9:51 ` [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " Zhu, ShuaiX
@ 2020-03-03  5:29 ` Tu, Lijuan
  2020-03-03  5:50   ` Zhu, ShuaiX
  8 siblings, 1 reply; 19+ messages in thread
From: Tu, Lijuan @ 2020-03-03  5:29 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan, Zhu, ShuaiX

Why remove it , can you add some explanation? 

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> create_eal_parameters function.
> 
> Remove parameters:"--socket-mem 1024,1024"
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_perf_virtio_user_pvp.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_perf_virtio_user_pvp.py
> b/tests/TestSuite_perf_virtio_user_pvp.py
> index 2073426..12031c3 100644
> --- a/tests/TestSuite_perf_virtio_user_pvp.py
> +++ b/tests/TestSuite_perf_virtio_user_pvp.py
> @@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
>              eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_host,
>                              ports=[0], prefix='vhost')
>          command_line_client = self.target + "/app/testpmd %s " + \
> -                        "--socket-mem 1024,1024 "  \
>                          "--vdev 'net_vhost0,iface=vhost-net,queues=1' " + \
>                          "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
>          command_line_client = command_line_client % (eal_params,
> len(self.core_list_host)-1,
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add create_eal_parameters function.
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
  2020-02-27  9:52   ` Zhu, ShuaiX
@ 2020-03-03  5:41   ` Tu, Lijuan
  1 sibling, 0 replies; 19+ messages in thread
From: Tu, Lijuan @ 2020-03-03  5:41 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan, Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_vhost_user_reconnect.py | 26 +++++++--------------
>  1 file changed, 9 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_vhost_user_reconnect.py
> b/tests/TestSuite_pvp_vhost_user_reconnect.py
> index 7b201a0..f361373 100644
> --- a/tests/TestSuite_pvp_vhost_user_reconnect.py
> +++ b/tests/TestSuite_pvp_vhost_user_reconnect.py
> @@ -56,10 +56,9 @@ class TestPVPVhostUserReconnect(TestCase):
>          # Get the port's socket
>          self.pf = self.dut_ports[0]
>          netdev = self.dut.ports_info[self.pf]['port']
> +        self.pci_info = self.dut.ports_info[0]['pci']
>          self.socket = netdev.get_nic_socket()
>          self.cores = self.dut.get_core_list("1S/2C/1T", socket=self.socket)
> -        self.coremask = utils.create_mask(self.cores)
> -        self.memory_channel = self.dut.get_memory_channels()
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          # set diff arg about mem_socket base on socket number
>          if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
> @@ -101,14 +100,10 @@ class TestPVPVhostUserReconnect(TestCase):
>          vdev_info = ""
>          for i in range(self.vm_num):
>              vdev_info += "--vdev 'net_vhost%d,iface=vhost-
> net%d,client=1,queues=1' " % (i, i)
> -        self.vhostapp_testcmd = self.dut.base_dir + \
> -                    "/%s/app/testpmd -c %s -n %d --socket-mem %s --legacy-mem" +
> \
> -                    " --file-prefix=vhost %s" + \
> -                    " -- -i --port-topology=chained --nb-cores=1" + \
> -                    " --txd=1024 --rxd=1024"
> -        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
> -                                self.coremask, self.memory_channel,
> -                                self.socket_mem, vdev_info)
> +        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
> +        eal_params = self.dut.create_eal_parameters(cores=self.cores,
> prefix='vhost', ports=[self.pci_info])
> +        para = " -- -i --port-topology=chained --nb-cores=1 --txd=1024 --
> rxd=1024"
> +        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
>          self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ", 40)
>          self.vhost_user.send_expect("set fwd mac", "testpmd> ", 40)
>          self.vhost_user.send_expect("start", "testpmd> ", 40) @@ -120,13
> +115,10 @@ class TestPVPVhostUserReconnect(TestCase):
>          vdev_info = ""
>          for i in range(self.vm_num):
>              vdev_info += "--vdev 'net_vhost%d,iface=vhost-
> net%d,client=1,queues=1' " % (i, i)
> -        self.vhostapp_testcmd = self.dut.base_dir + \
> -                    "/%s/app/testpmd -c %s -n %d --socket-mem %s --legacy-mem" +
> \
> -                    " --no-pci --file-prefix=vhost %s" + \
> -                    " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> -        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
> -                                self.coremask, self.memory_channel,
> -                                self.socket_mem, vdev_info)
> +        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
> +        eal_params = self.dut.create_eal_parameters(cores=self.cores,
> no_pci=True, prefix='vhost', ports=[self.pci_info])
> +        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> +        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
>          self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ", 40)
>          self.vhost_user.send_expect("start", "testpmd> ", 40)
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_virtio_bonding:add create_eal_parameters function.
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
  2020-02-27  9:52   ` Zhu, ShuaiX
@ 2020-03-03  5:41   ` Tu, Lijuan
  1 sibling, 0 replies; 19+ messages in thread
From: Tu, Lijuan @ 2020-03-03  5:41 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan, Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_virtio_bonding:add
> create_eal_parameters function.
> 
> Remove parameters:"--socket-mem 2048,2048 --legacy-mem"
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_bonding.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_bonding.py
> b/tests/TestSuite_pvp_virtio_bonding.py
> index 1405b0b..b551487 100644
> --- a/tests/TestSuite_pvp_virtio_bonding.py
> +++ b/tests/TestSuite_pvp_virtio_bonding.py
> @@ -88,7 +88,7 @@ class TestPVPVirtIOBonding(TestCase):
>          for i in range(self.queues):
>              vdev_info += "--vdev 'net_vhost%d,iface=vhost-
> net%d,client=1,queues=1' " % (i, i)
>          params = "--port-topology=chained --nb-cores=4 --txd=1024 --rxd=1024"
> -        eal_param = "--socket-mem 2048,2048 --legacy-mem --file-
> prefix=vhost %s " % vdev_info
> +        eal_param = "--file-prefix=vhost %s " % vdev_info
>          self.vhost_testpmd = PmdOutput(self.dut)
>          self.vhost_testpmd.start_testpmd(self.core_config, params,
> eal_param=eal_param)
>          self.vhost_testpmd.execute_cmd('set fwd mac')
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add create_eal_parameters function.
  2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
  2020-02-27  9:54   ` Zhu, ShuaiX
@ 2020-03-03  5:41   ` Tu, Lijuan
  1 sibling, 0 replies; 19+ messages in thread
From: Tu, Lijuan @ 2020-03-03  5:41 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan, Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_user_4k_pages.py | 24 +++++++++------------
>  1 file changed, 10 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_4k_pages.py
> b/tests/TestSuite_pvp_virtio_user_4k_pages.py
> index 95b5494..5e6f657 100644
> --- a/tests/TestSuite_pvp_virtio_user_4k_pages.py
> +++ b/tests/TestSuite_pvp_virtio_user_4k_pages.py
> @@ -65,9 +65,7 @@ class TestPvpVirtioUser4kPages(TestCase):
>              self.core_config, socket=self.ports_socket)
>          self.core_list_virtio_user = self.core_list[0:2]
>          self.core_list_vhost_user = self.core_list[2:4]
> -        self.core_mask_virtio_user = utils.create_mask(self.core_list_virtio_user)
> -        self.core_mask_vhost_user =
> utils.create_mask(self.core_list_vhost_user)
> -        self.mem_channels = self.dut.get_memory_channels()
> +        self.pci_info = self.dut.ports_info[0]['pci']
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          self.frame_sizes = [64, 128, 256, 512, 1024, 1518]
>          self.logger.info("You can config packet_size in file %s.cfg," %
> self.suite_name + \ @@ -131,12 +129,11 @@ class
> TestPvpVirtioUser4kPages(TestCase):
>          """
>          Start testpmd on vhost
>          """
> -        command_line_client = "%s/app/testpmd -c %s -n %d " + \
> -                              "--file-prefix=vhost  -m 1024 --no-huge " + \
> -                              "--vdev 'net_vhost0,iface=vhost-net,queues=1' -- -i " + \
> -                              "--no-numa --socket-num=%d"
> -        command_line_client = command_line_client % (self.target,
> -                            self.core_mask_vhost_user, self.mem_channels,
> self.ports_socket)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " -m 1024 --no-huge --vdev 'net_vhost0,iface=vhost-
> net,queues=1'"
> +        para = " -- -i --no-numa --socket-num=%d" % self.ports_socket
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost_user,
> prefix='vhost', ports=[self.pci_info])
> +        command_line_client = testcmd + eal_params + vdev + para
>          self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
>          self.vhost_user.send_expect("start", "testpmd> ", 120)
> 
> @@ -144,11 +141,10 @@ class TestPvpVirtioUser4kPages(TestCase):
>          """
>          Start testpmd on virtio
>          """
> -        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
> -                            "--no-huge -m 1024 --file-prefix=virtio-user " + \
> -                            "--
> vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> -        command_line_user = command_line_user % (self.target,
> -                self.mem_channels, self.core_mask_virtio_user)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " --no-huge -m 1024 --
> vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_virtio_user,
> prefix='virtio-user', ports=[self.pci_info])
> +        command_line_user = testcmd + eal_params + vdev
>          self.virtio_user.send_expect(command_line_user, "testpmd> ", 120)
>          self.virtio_user.send_expect("set fwd mac", "testpmd> ", 120)
>          self.virtio_user.send_expect("start", "testpmd> ", 120)
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function.
  2020-03-03  5:29 ` Tu, Lijuan
@ 2020-03-03  5:50   ` Zhu, ShuaiX
  2020-03-03  7:42     ` Tu, Lijuan
  0 siblings, 1 reply; 19+ messages in thread
From: Zhu, ShuaiX @ 2020-03-03  5:50 UTC (permalink / raw)
  To: Tu, Lijuan, dts; +Cc: Wang, Yinan

This is the result given by BB, let delete this parameter.

> -----Original Message-----
> From: Tu, Lijuan
> Sent: Tuesday, March 3, 2020 1:29 PM
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> create_eal_parameters function.
> 
> Why remove it , can you add some explanation?
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > Sent: Wednesday, February 26, 2020 5:19 PM
> > To: dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > <shuaix.zhu@intel.com>
> > Subject: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > create_eal_parameters function.
> >
> > Remove parameters:"--socket-mem 1024,1024"
> >
> > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > ---
> >  tests/TestSuite_perf_virtio_user_pvp.py | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_perf_virtio_user_pvp.py
> > b/tests/TestSuite_perf_virtio_user_pvp.py
> > index 2073426..12031c3 100644
> > --- a/tests/TestSuite_perf_virtio_user_pvp.py
> > +++ b/tests/TestSuite_perf_virtio_user_pvp.py
> > @@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
> >              eal_params =
> > self.dut.create_eal_parameters(cores=self.core_list_host,
> >                              ports=[0], prefix='vhost')
> >          command_line_client = self.target + "/app/testpmd %s " + \
> > -                        "--socket-mem 1024,1024 "  \
> >                          "--vdev 'net_vhost0,iface=vhost-net,queues=1' "
> + \
> >                          "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
> >          command_line_client = command_line_client % (eal_params,
> > len(self.core_list_host)-1,
> > --
> > 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function.
  2020-03-03  5:50   ` Zhu, ShuaiX
@ 2020-03-03  7:42     ` Tu, Lijuan
  2020-03-16  3:36       ` Wang, Yinan
  0 siblings, 1 reply; 19+ messages in thread
From: Tu, Lijuan @ 2020-03-03  7:42 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan

So please ask your "BB" to explain. thanks

> -----Original Message-----
> From: Zhu, ShuaiX
> Sent: Tuesday, March 3, 2020 1:51 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> create_eal_parameters function.
> 
> This is the result given by BB, let delete this parameter.
> 
> > -----Original Message-----
> > From: Tu, Lijuan
> > Sent: Tuesday, March 3, 2020 1:29 PM
> > To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > <shuaix.zhu@intel.com>
> > Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > create_eal_parameters function.
> >
> > Why remove it , can you add some explanation?
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > > Sent: Wednesday, February 26, 2020 5:19 PM
> > > To: dts@dpdk.org
> > > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > > <shuaix.zhu@intel.com>
> > > Subject: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > > create_eal_parameters function.
> > >
> > > Remove parameters:"--socket-mem 1024,1024"
> > >
> > > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > > ---
> > >  tests/TestSuite_perf_virtio_user_pvp.py | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tests/TestSuite_perf_virtio_user_pvp.py
> > > b/tests/TestSuite_perf_virtio_user_pvp.py
> > > index 2073426..12031c3 100644
> > > --- a/tests/TestSuite_perf_virtio_user_pvp.py
> > > +++ b/tests/TestSuite_perf_virtio_user_pvp.py
> > > @@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
> > >              eal_params =
> > > self.dut.create_eal_parameters(cores=self.core_list_host,
> > >                              ports=[0], prefix='vhost')
> > >          command_line_client = self.target + "/app/testpmd %s " + \
> > > -                        "--socket-mem 1024,1024 "  \
> > >                          "--vdev 'net_vhost0,iface=vhost-net,queues=1' "
> > + \
> > >                          "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
> > >          command_line_client = command_line_client % (eal_params,
> > > len(self.core_list_host)-1,
> > > --
> > > 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function.
  2020-03-03  7:42     ` Tu, Lijuan
@ 2020-03-16  3:36       ` Wang, Yinan
  0 siblings, 0 replies; 19+ messages in thread
From: Wang, Yinan @ 2020-03-16  3:36 UTC (permalink / raw)
  To: Tu, Lijuan, Zhu, ShuaiX, dts

Hi Lijuan,

Now virtio case migrate to using new memory system, so whether add "socket-mem "or not will not influence memory usage since new memory system can allocate memory when needed, this plan just to align with test plan.

BR,
Yinan

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: 2020^[$BG/^[(B3^[$B7n^[(B3^[$BF|^[(B 15:42
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> create_eal_parameters function.
> 
> So please ask your "BB" to explain. thanks
> 
> > -----Original Message-----
> > From: Zhu, ShuaiX
> > Sent: Tuesday, March 3, 2020 1:51 PM
> > To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>
> > Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > create_eal_parameters function.
> >
> > This is the result given by BB, let delete this parameter.
> >
> > > -----Original Message-----
> > > From: Tu, Lijuan
> > > Sent: Tuesday, March 3, 2020 1:29 PM
> > > To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> > > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > > <shuaix.zhu@intel.com>
> > > Subject: RE: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > > create_eal_parameters function.
> > >
> > > Why remove it , can you add some explanation?
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > > > Sent: Wednesday, February 26, 2020 5:19 PM
> > > > To: dts@dpdk.org
> > > > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > > > <shuaix.zhu@intel.com>
> > > > Subject: [dts] [PATCH V1] tests/perf_virtio_user_pvp:add
> > > > create_eal_parameters function.
> > > >
> > > > Remove parameters:"--socket-mem 1024,1024"
> > > >
> > > > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > > > ---
> > > >  tests/TestSuite_perf_virtio_user_pvp.py | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/tests/TestSuite_perf_virtio_user_pvp.py
> > > > b/tests/TestSuite_perf_virtio_user_pvp.py
> > > > index 2073426..12031c3 100644
> > > > --- a/tests/TestSuite_perf_virtio_user_pvp.py
> > > > +++ b/tests/TestSuite_perf_virtio_user_pvp.py
> > > > @@ -236,7 +236,6 @@ class TestVirtioSingleCorePerf(TestCase):
> > > >              eal_params =
> > > > self.dut.create_eal_parameters(cores=self.core_list_host,
> > > >                              ports=[0], prefix='vhost')
> > > >          command_line_client = self.target + "/app/testpmd %s " + \
> > > > -                        "--socket-mem 1024,1024 "  \
> > > >                          "--vdev
> 'net_vhost0,iface=vhost-net,queues=1' "
> > > + \
> > > >                          "-- -i --nb-cores=%d  --txd=%d --rxd=%d"
> > > >          command_line_client = command_line_client % (eal_params,
> > > > len(self.core_list_host)-1,
> > > > --
> > > > 2.17.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, back to index

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add create_eal_parameters function zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
2020-02-27  9:54   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/virtio_pvp_regression:add " zhu,shuai
2020-02-27  9:51 ` [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " Zhu, ShuaiX
2020-03-03  5:29 ` Tu, Lijuan
2020-03-03  5:50   ` Zhu, ShuaiX
2020-03-03  7:42     ` Tu, Lijuan
2020-03-16  3:36       ` Wang, Yinan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox