* [dpdk-stable] [PATCH 18.05] net/mlx5: fix GRE flow rule
@ 2018-06-19 23:30 Yongseok Koh
2018-08-30 0:28 ` Yongseok Koh
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2018-06-19 23:30 UTC (permalink / raw)
To: stable; +Cc: Yongseok Koh
Creating a flow having pattern from the middle of a packet is allowed. For
example,
testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ...
Device can parse GRE protocol number in outer IP header but specifying from
GRE header can't differentiate it from VxLAN tunnel. As a result, the
following rule will be interpreted as a wildcard rule, which always matches
any packet.
testpmd> flow create 0 ingress pattern gre / end actions ...
Fixes: 96c6c65a10d2 ("net/mlx5: support GRE tunnel flow")
Fixes: 1f106da2bf7b ("net/mlx5: support MPLS-in-GRE and MPLS-in-UDP")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 994be05be..adb995f0d 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -331,8 +331,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
[RTE_FLOW_ITEM_TYPE_END] = {
.items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
RTE_FLOW_ITEM_TYPE_VXLAN,
- RTE_FLOW_ITEM_TYPE_VXLAN_GPE,
- RTE_FLOW_ITEM_TYPE_GRE),
+ RTE_FLOW_ITEM_TYPE_VXLAN_GPE),
},
[RTE_FLOW_ITEM_TYPE_ETH] = {
.items = ITEMS(RTE_FLOW_ITEM_TYPE_VLAN,
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 18.05] net/mlx5: fix GRE flow rule
2018-06-19 23:30 [dpdk-stable] [PATCH 18.05] net/mlx5: fix GRE flow rule Yongseok Koh
@ 2018-08-30 0:28 ` Yongseok Koh
0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2018-08-30 0:28 UTC (permalink / raw)
To: Christian Ehrhardt; +Cc: dpdk stable
Hi, Christian
Can you please also include this patch?
You might have missed it because it had been sent a while ago.
Thanks,
Yongseok
> On Jun 19, 2018, at 4:30 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
> Creating a flow having pattern from the middle of a packet is allowed. For
> example,
>
> testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ...
>
> Device can parse GRE protocol number in outer IP header but specifying from
> GRE header can't differentiate it from VxLAN tunnel. As a result, the
> following rule will be interpreted as a wildcard rule, which always matches
> any packet.
>
> testpmd> flow create 0 ingress pattern gre / end actions ...
>
> Fixes: 96c6c65a10d2 ("net/mlx5: support GRE tunnel flow")
> Fixes: 1f106da2bf7b ("net/mlx5: support MPLS-in-GRE and MPLS-in-UDP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 994be05be..adb995f0d 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -331,8 +331,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
> [RTE_FLOW_ITEM_TYPE_END] = {
> .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
> RTE_FLOW_ITEM_TYPE_VXLAN,
> - RTE_FLOW_ITEM_TYPE_VXLAN_GPE,
> - RTE_FLOW_ITEM_TYPE_GRE),
> + RTE_FLOW_ITEM_TYPE_VXLAN_GPE),
> },
> [RTE_FLOW_ITEM_TYPE_ETH] = {
> .items = ITEMS(RTE_FLOW_ITEM_TYPE_VLAN,
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-30 0:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 23:30 [dpdk-stable] [PATCH 18.05] net/mlx5: fix GRE flow rule Yongseok Koh
2018-08-30 0:28 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).