* [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables
@ 2021-09-06 7:31 christian.ehrhardt
2021-09-06 8:20 ` Christian Ehrhardt
0 siblings, 1 reply; 3+ messages in thread
From: christian.ehrhardt @ 2021-09-06 7:31 UTC (permalink / raw)
To: stable; +Cc: Yury Kylulin, Ashish Paul, Christian Ehrhardt
From: Yury Kylulin <yury.kylulin@intel.com>
[ upstream commit b1daa3461429e7674206a714c17adca65e9b44b4 ]
Enable additional PHY types (25G-AOC and 25G-ACC) for set PHY config
command.
Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1940957
Cc: stable@dpdk.org
Signed-off-by: Yury Kylulin <yury.kylulin@intel.com>
Tested-by: Ashish Paul <apaul@juniper.net>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 508f90595f..0c896ea915 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2264,7 +2264,8 @@ i40e_phy_conf_link(struct i40e_hw *hw,
phy_conf.phy_type = is_up ? cpu_to_le32(phy_type_mask) : 0;
phy_conf.phy_type_ext = is_up ? (I40E_AQ_PHY_TYPE_EXT_25G_KR |
I40E_AQ_PHY_TYPE_EXT_25G_CR | I40E_AQ_PHY_TYPE_EXT_25G_SR |
- I40E_AQ_PHY_TYPE_EXT_25G_LR) : 0;
+ I40E_AQ_PHY_TYPE_EXT_25G_LR | I40E_AQ_PHY_TYPE_EXT_25G_AOC |
+ I40E_AQ_PHY_TYPE_EXT_25G_ACC) : 0;
phy_conf.fec_config = phy_ab.fec_cfg_curr_mod_ext_info;
phy_conf.eee_capability = phy_ab.eee_capability;
phy_conf.eeer = phy_ab.eeer_val;
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables
2021-09-06 7:31 [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables christian.ehrhardt
@ 2021-09-06 8:20 ` Christian Ehrhardt
2021-09-06 11:01 ` Christian Ehrhardt
0 siblings, 1 reply; 3+ messages in thread
From: Christian Ehrhardt @ 2021-09-06 8:20 UTC (permalink / raw)
To: dpdk stable; +Cc: Yury Kylulin, Ashish Paul
On Mon, Sep 6, 2021 at 9:32 AM <christian.ehrhardt@canonical.com> wrote:
>
> From: Yury Kylulin <yury.kylulin@intel.com>
>
> [ upstream commit b1daa3461429e7674206a714c17adca65e9b44b4 ]
FYI - this commit is in 21.05 but was initially not targettet at stable@dpdk.
In some tests (the linked bug) it was found that it resolves issues with newer
hardware and therefore I did the backport (no changes) and submitted it here
for discussion.
It might be too late for 20.11.3/19.11.10 which are supposed to
release today, but we could queue them right away.
I'm mostly interested in feedback from the Authors if they think this
could be an issue (e.g. due to unidentified dependencies).
> Enable additional PHY types (25G-AOC and 25G-ACC) for set PHY config
> command.
>
> Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1940957
> Cc: stable@dpdk.org
>
> Signed-off-by: Yury Kylulin <yury.kylulin@intel.com>
> Tested-by: Ashish Paul <apaul@juniper.net>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 508f90595f..0c896ea915 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2264,7 +2264,8 @@ i40e_phy_conf_link(struct i40e_hw *hw,
> phy_conf.phy_type = is_up ? cpu_to_le32(phy_type_mask) : 0;
> phy_conf.phy_type_ext = is_up ? (I40E_AQ_PHY_TYPE_EXT_25G_KR |
> I40E_AQ_PHY_TYPE_EXT_25G_CR | I40E_AQ_PHY_TYPE_EXT_25G_SR |
> - I40E_AQ_PHY_TYPE_EXT_25G_LR) : 0;
> + I40E_AQ_PHY_TYPE_EXT_25G_LR | I40E_AQ_PHY_TYPE_EXT_25G_AOC |
> + I40E_AQ_PHY_TYPE_EXT_25G_ACC) : 0;
> phy_conf.fec_config = phy_ab.fec_cfg_curr_mod_ext_info;
> phy_conf.eee_capability = phy_ab.eee_capability;
> phy_conf.eeer = phy_ab.eeer_val;
> --
> 2.32.0
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables
2021-09-06 8:20 ` Christian Ehrhardt
@ 2021-09-06 11:01 ` Christian Ehrhardt
0 siblings, 0 replies; 3+ messages in thread
From: Christian Ehrhardt @ 2021-09-06 11:01 UTC (permalink / raw)
To: dpdk stable; +Cc: Yury Kylulin, Ashish Paul
On Mon, Sep 6, 2021 at 10:20 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Mon, Sep 6, 2021 at 9:32 AM <christian.ehrhardt@canonical.com> wrote:
> >
> > From: Yury Kylulin <yury.kylulin@intel.com>
> >
> > [ upstream commit b1daa3461429e7674206a714c17adca65e9b44b4 ]
FYI - I got an ack by Tmonjalo on IRC and enqueued this for 19.11.11
(not 19.11.10 that has released today).
> FYI - this commit is in 21.05 but was initially not targettet at stable@dpdk.
> In some tests (the linked bug) it was found that it resolves issues with newer
> hardware and therefore I did the backport (no changes) and submitted it here
> for discussion.
>
> It might be too late for 20.11.3/19.11.10 which are supposed to
> release today, but we could queue them right away.
> I'm mostly interested in feedback from the Authors if they think this
> could be an issue (e.g. due to unidentified dependencies).
>
> > Enable additional PHY types (25G-AOC and 25G-ACC) for set PHY config
> > command.
> >
> > Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1940957
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yury Kylulin <yury.kylulin@intel.com>
> > Tested-by: Ashish Paul <apaul@juniper.net>
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> > index 508f90595f..0c896ea915 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -2264,7 +2264,8 @@ i40e_phy_conf_link(struct i40e_hw *hw,
> > phy_conf.phy_type = is_up ? cpu_to_le32(phy_type_mask) : 0;
> > phy_conf.phy_type_ext = is_up ? (I40E_AQ_PHY_TYPE_EXT_25G_KR |
> > I40E_AQ_PHY_TYPE_EXT_25G_CR | I40E_AQ_PHY_TYPE_EXT_25G_SR |
> > - I40E_AQ_PHY_TYPE_EXT_25G_LR) : 0;
> > + I40E_AQ_PHY_TYPE_EXT_25G_LR | I40E_AQ_PHY_TYPE_EXT_25G_AOC |
> > + I40E_AQ_PHY_TYPE_EXT_25G_ACC) : 0;
> > phy_conf.fec_config = phy_ab.fec_cfg_curr_mod_ext_info;
> > phy_conf.eee_capability = phy_ab.eee_capability;
> > phy_conf.eeer = phy_ab.eeer_val;
> > --
> > 2.32.0
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-06 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 7:31 [dpdk-stable] [19.11 PATCH] net/i40e: support 25G AOC/ACC cables christian.ehrhardt
2021-09-06 8:20 ` Christian Ehrhardt
2021-09-06 11:01 ` Christian Ehrhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).