From: "Ling, WeiX" <weix.ling@intel.com>
To: "Liu, KevinX" <kevinx.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Liu, KevinX" <kevinx.liu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/ice: fix Tx offload path choice
Date: Thu, 24 Feb 2022 02:32:36 +0000 [thread overview]
Message-ID: <PH7PR11MB6006EED5E4A7522FF60CF974EE3D9@PH7PR11MB6006.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211224150925.3296471-1-kevinx.liu@intel.com>
> -----Original Message-----
> From: Kevin Liu <kevinx.liu@intel.com>
> Sent: Friday, December 24, 2021 11:09 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; Liu, KevinX <kevinx.liu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/ice: fix Tx offload path choice
>
> Testpmd forwards packets in checksum mode that it needs to calculate the
> checksum of each layer's protocol.
>
> When setting the hardware calculates the outer UDP checksum and the
> software calculates the outer IP checksum, the dev->tx_pkt_burst in
> ice_set_tx_function is set to ice_xmit_pkts_vec_avx2.
> The inner and outer UDP checksum of the tunnel packet after forwarding is
> wrong.The dev->tx_pkt_burst should be set to ice_xmit_pkts.
>
> The patch adds RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM to
> ICE_TX_NO_VECTOR_FLAGS,set dev->tx_pkt_burst to ice_xmit_pkts.After
> the tunnel packet is forwarded, the inner and outer UDP checksum is correct.
>
> At the same time, the patch of "net/ice: fix Tx Checksum offload" will cause
> interrupt errors in a special case that only inner IP and inner UDP checksum
> are set for hardware calculation.The patch is updating
> ICE_TX_NO_VECTOR_FLAGS, the problem can be solved, so I will restore the
> code modification of that patch.
>
> Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi-
> segments")
> Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
> Fixes: 295968d17407 ("ethdev: add namespace")
> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> ---
Tested-by: Wei Ling <weix.ling@intel.com>
next prev parent reply other threads:[~2022-02-24 2:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 15:09 Kevin Liu
[not found] ` <20211229093702.1930214-1-kevinx.liu@intel.com>
2021-12-29 9:37 ` [PATCH v2 1/2] " Kevin Liu
2022-03-04 3:19 ` Xu, Ting
2022-03-04 3:31 ` Zhang, Qi Z
2022-03-04 11:52 ` Ferruh Yigit
2021-12-29 9:37 ` [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Kevin Liu
[not found] ` <d2d97e6cf1a14faaa47b61b63ed55573@intel.com>
2022-03-03 6:29 ` Zhang, Yuying
2022-03-11 7:04 ` Liu, KevinX
2022-03-11 8:02 ` Singh, Aman Deep
2022-03-11 8:12 ` Liu, KevinX
2022-03-11 9:04 ` Singh, Aman Deep
2022-03-11 10:46 ` Ferruh Yigit
2022-03-14 2:33 ` Zhang, Qi Z
2022-03-14 20:21 ` Thomas Monjalon
2022-02-24 2:32 ` Ling, WeiX [this message]
2022-02-27 6:19 ` [PATCH] net/ice: fix Tx offload path choice Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6006EED5E4A7522FF60CF974EE3D9@PH7PR11MB6006.namprd11.prod.outlook.com \
--to=weix.ling@intel.com \
--cc=dev@dpdk.org \
--cc=kevinx.liu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).