automatic DPDK test reports
 help / color / Atom feed
* [dpdk-test-report] |WARNING| pw59094 [PATCH 2/2] net/enic: add flow implementation based on Flow Manager API
       [not found] <20190910095937.9731-3-hyonkim@cisco.com>
@ 2019-09-10 10:01 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-09-10 10:01 UTC (permalink / raw)
  To: test-report; +Cc: Hyong Youb Kim

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59094

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#298: FILE: drivers/net/enic/base/vnic_flowman.h:33:
+#define FKM_BITS		\
+	FBIT(FKM_QTAG)		\
+	FBIT(FKM_CMD)		\
+	FBIT(FKM_IPV4)		\
+	FBIT(FKM_IPV6)		\
+	FBIT(FKM_ROCE)		\
+	FBIT(FKM_UDP)		\
+	FBIT(FKM_TCP)		\
+	FBIT(FKM_TCPORUDP)	\
+	FBIT(FKM_IPFRAG)	\
+	FBIT(FKM_NVGRE)		\
+	FBIT(FKM_VXLAN)		\
+	FBIT(FKM_GENEVE)	\
+	FBIT(FKM_NSH)		\
+	FBIT(FKM_ROCEV2)	\
+	FBIT(FKM_VLAN_PRES)	\
+	FBIT(FKM_IPOK)		\
+	FBIT(FKM_L4OK)		\
+	FBIT(FKM_ROCEOK)	\
+	FBIT(FKM_FCSOK)		\
+	FBIT(FKM_EG_SPAN)	\
+	FBIT(FKM_IG_SPAN)	\
+	FBIT(FKM_EG_HAIRPINNED)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#331: FILE: drivers/net/enic/base/vnic_flowman.h:66:
+#define FKH_BITS	\
+	FBIT(FKH_ETHER)	\
+	FBIT(FKH_QTAG)	\
+	FBIT(FKH_L2RAW)	\
+	FBIT(FKH_IPV4)	\
+	FBIT(FKH_IPV6)	\
+	FBIT(FKH_L3RAW)	\
+	FBIT(FKH_UDP)	\
+	FBIT(FKH_TCP)	\
+	FBIT(FKH_ICMP)	\
+	FBIT(FKH_VXLAN)	\
+	FBIT(FKH_L4RAW)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/net/enic/base/vnic_flowman.h:90:
+#define FBIT(X) X = (1 << X##_BIT),

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#1405: FILE: drivers/net/enic/enic_fm_flow.c:674:
+	ENICPMD_LOG(DEBUG, "allocated exact match table: handle=0x%" PRIx64,

total: 3 errors, 0 warnings, 1 checks, 3141 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190910095937.9731-3-hyonkim@cisco.com>
2019-09-10 10:01 ` [dpdk-test-report] |WARNING| pw59094 [PATCH 2/2] net/enic: add flow implementation based on Flow Manager API checkpatch

automatic DPDK test reports

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ http://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/ public-inbox