* |WARNING| pw113795 [Patch v3 01/17] net/mana: add basic driver, build environment and doc
[not found] <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com>
@ 2022-07-07 20:31 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-07-07 20:31 UTC (permalink / raw)
To: test-report; +Cc: longli
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113795
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56:
MANA is a PCI device. It uses IB verbs to access hardware through the kernel
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#246: FILE: drivers/net/mana/mana.c:33:
+#define MKSTR(name, ...) \
+ int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
+ char name[mkstr_size_##name + 1]; \
+ \
+ memset(name, 0, mkstr_size_##name + 1); \
+ snprintf(name, sizeof(name), "" __VA_ARGS__)
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#280: FILE: drivers/net/mana/mana.c:67:
+static const char *mana_init_args[] = {
CHECK:CAMELCASE: Avoid CamelCase: <SCNx32>
#424: FILE: drivers/net/mana/mana.c:211:
+ "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",
CHECK:CAMELCASE: Avoid CamelCase: <SCNx8>
#424: FILE: drivers/net/mana/mana.c:211:
+ "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",
total: 0 errors, 2 warnings, 3 checks, 1298 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-07 20:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com>
2022-07-07 20:31 ` |WARNING| pw113795 [Patch v3 01/17] net/mana: add basic driver, build environment and doc checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).