|WARNING| pw118986 [PATCH v2] net/iavf: fix handling of IPsec events

|WARNING| pw118986 [PATCH v2] net/iavf: fix handling of IPsec events

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118986

_coding style issues_


WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#109: FILE: drivers/net/iavf/iavf_vchnl.c:497:
+						if (imsg->ipsec_opcode

total: 0 errors, 1 warnings, 0 checks, 48 lines checked

|WARNING| pw118986 [PATCH] [v2] net/iavf: fix handling of IPsec events

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 2837 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/118986

_apply patch failure_

Submitter: Radu Nicolau <radu.nicolau@intel.com>
Date: Monday, October 24 2022 11:34:47 
Applied on: CommitID:269f027453ae7a9ac1bf0d6786388f598a139314
Apply patch set 118986 failed:

Checking patch drivers/net/iavf/iavf_vchnl.c...
error: while searching for:
				iavf_handle_pf_event_msg(dev, info.msg_buf,
						info.msg_len);
			} else {
				/* check for inline IPsec events */
				struct inline_ipsec_msg *imsg =
					(struct inline_ipsec_msg *)info.msg_buf;
				struct rte_eth_event_ipsec_desc desc;
				if (msg_opc ==
					VIRTCHNL_OP_INLINE_IPSEC_CRYPTO &&
					imsg->ipsec_opcode ==
						INLINE_IPSEC_OP_EVENT) {
					struct virtchnl_ipsec_event *ev =
							imsg->ipsec_data.event;
					desc.subtype =
						RTE_ETH_EVENT_IPSEC_UNKNOWN;
					desc.metadata = ev->ipsec_event_data;
					iavf_dev_event_post(dev, RTE_ETH_EVENT_IPSEC,
							&desc, sizeof(desc));
					return;
				}

				/* read message and it's expected one */

error: patch failed: drivers/net/iavf/iavf_vchnl.c:488
Applying patch drivers/net/iavf/iavf_vchnl.c with 1 reject...
Rejected hunk #1.
diff a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c	(rejected hunks)
@@ -488,22 +488,32 @@ iavf_handle_virtchnl_msg(struct rte_eth_dev *dev)
 				iavf_handle_pf_event_msg(dev, info.msg_buf,
 						info.msg_len);
 			} else {
-				/* check for inline IPsec events */
-				struct inline_ipsec_msg *imsg =
-					(struct inline_ipsec_msg *)info.msg_buf;
-				struct rte_eth_event_ipsec_desc desc;
-				if (msg_opc ==
-					VIRTCHNL_OP_INLINE_IPSEC_CRYPTO &&
-					imsg->ipsec_opcode ==
-						INLINE_IPSEC_OP_EVENT) {
-					struct virtchnl_ipsec_event *ev =
-							imsg->ipsec_data.event;
-					desc.subtype =
-						RTE_ETH_EVENT_IPSEC_UNKNOWN;
-					desc.metadata = ev->ipsec_event_data;
-					iavf_dev_event_post(dev, RTE_ETH_EVENT_IPSEC,
-							&desc, sizeof(desc));
-					return;
+				/* check for unsolicited messages i.e. events */
+				if (info.msg_len > 0) {
+					switch (msg_opc) {
+					case VIRTCHNL_OP_INLINE_IPSEC_CRYPTO: {
+						struct inline_ipsec_msg *imsg =
+							(struct inline_ipsec_msg *)info.msg_buf;
+						if (imsg->ipsec_opcode
+								== INLINE_IPSEC_OP_EVENT) {
+							struct rte_eth_event_ipsec_desc desc;
+							struct virtchnl_ipsec_event *ev =
+									imsg->ipsec_data.event;
+							desc.subtype =
+									RTE_ETH_EVENT_IPSEC_UNKNOWN;
+							desc.metadata =
+									ev->ipsec_event_data;
+							iavf_dev_event_post(dev,
+								RTE_ETH_EVENT_IPSEC,
+								&desc, sizeof(desc));
+							continue;
+					}
+				}
+						break;
+					default:
+						break;
+					}
+
 				}
 
 				/* read message and it's expected one */

https://lab.dpdk.org/results/dashboard/patchsets/24147/

UNH-IOL DPDK Community Lab