* |WARNING| pw124873 [PATCH] [v3] net/mlx5: use just sufficient barrier for ARM platforms
@ 2023-03-11 8:51 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2023-03-11 8:51 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/124873
_apply patch failure_
Submitter: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Date: Thursday, March 09 2023 02:32:47
Applied on: CommitID:b15d75b2872efce397d827dac78692a919358302
Apply patch set 124873 failed:
Checking patch drivers/common/mlx5/mlx5_common.h...
error: while searching for:
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
rte_io_rmb();
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
error: patch failed: drivers/common/mlx5/mlx5_common.h:203
Applying patch drivers/common/mlx5/mlx5_common.h with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h (rejected hunks)
@@ -203,7 +203,11 @@ check_cqe(volatile struct mlx5_cqe *cqe, const uint16_t cqes_n,
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
- rte_io_rmb();
+ /* Prevent speculative reading of other fields in CQE until
+ * CQE is valid.
+ */
+ rte_atomic_thread_fence(__ATOMIC_ACQUIRE);
+
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
https://lab.dpdk.org/results/dashboard/patchsets/25649/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
* |WARNING| pw124873 [PATCH] [v3] net/mlx5: use just sufficient barrier for ARM platforms
@ 2023-03-11 9:39 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2023-03-11 9:39 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/124873
_apply patch failure_
Submitter: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Date: Thursday, March 09 2023 02:32:47
Applied on: CommitID:b15d75b2872efce397d827dac78692a919358302
Apply patch set 124873 failed:
Checking patch drivers/common/mlx5/mlx5_common.h...
error: while searching for:
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
rte_io_rmb();
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
error: patch failed: drivers/common/mlx5/mlx5_common.h:203
Applying patch drivers/common/mlx5/mlx5_common.h with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h (rejected hunks)
@@ -203,7 +203,11 @@ check_cqe(volatile struct mlx5_cqe *cqe, const uint16_t cqes_n,
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
- rte_io_rmb();
+ /* Prevent speculative reading of other fields in CQE until
+ * CQE is valid.
+ */
+ rte_atomic_thread_fence(__ATOMIC_ACQUIRE);
+
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
https://lab.dpdk.org/results/dashboard/patchsets/25649/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-11 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 8:51 |WARNING| pw124873 [PATCH] [v3] net/mlx5: use just sufficient barrier for ARM platforms dpdklab
2023-03-11 9:39 dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).