From: Thomas Monjalon <thomas@monjalon.net>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org,
radhika.chirra@ibm.com, stable@dpdk.org,
Vivian Kong <vivkong@ca.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init
Date: Wed, 10 Apr 2019 23:14:19 +0200 [thread overview]
Message-ID: <1832941.R5tAQzo2FV@xps> (raw)
Message-ID: <20190410211419.FB92WLqTQzIpPBv_cbYk7K8ohayO-iKUAGapaQJcMAg@z> (raw)
In-Reply-To: <a8c995fe-d809-be32-9222-c48a14ac36a7@linux.vnet.ibm.com>
10/04/2019 22:58, David Christensen:
> > This is a duplicate of this patch:
> >
> > https://patches.dpdk.org/patch/52505/
> >
> > You are from 2 different Linux teams at IBM,
> > you hit the same issue at the same time,
> > you both miss to give an explanation,
> > funny.
>
> We both work for infrastructure teams who are supporting a project team
> that is developing a DPDK application that runs across multiple CPU
> architectures and encountered the error.
>
> The error comes from g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0:
>
> [CXX] g++ -o utils/pcap_handle.o -c utils/pcap_handle.cc -g3
> -ggdb3 -mcpu=native -mtune=native -isystem
> /home/rchirra/gen/io/ppc64include -std=gnu++11 -flax-vector-conversions
> -Werror -isystem /home/rchirra/gen/io
>
> In file included from drivers/pmd.cc:7:0:
> /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:
> In function ‘int eth_dev_pci_specific_init(rte_eth_dev*, void*)’:
> /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35:
> error: invalid conversion from ‘void*’ to ‘rte_pci_device*’ [-fpermissive]
> struct rte_pci_device *pci_dev = bus_device;
> ^~~~~~~~~~
> make[1]: *** [drivers/pmd.o] Error 1
>
> Do you believe that more permissive compiler flags are the better answer?
No, we should not force any compiler flag of the application.
We are even trying to support pedantic flags in the app.
So it seems we must fix it.
We just need to change the title to mention it fixes the build for C++,
and add the error message in the body.
next prev parent reply other threads:[~2019-04-10 21:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 20:16 David Christensen
2019-04-10 20:16 ` David Christensen
2019-04-10 20:29 ` Thomas Monjalon
2019-04-10 20:29 ` Thomas Monjalon
2019-04-10 20:58 ` David Christensen
2019-04-10 20:58 ` David Christensen
2019-04-10 21:14 ` Thomas Monjalon [this message]
2019-04-10 21:14 ` Thomas Monjalon
2019-04-12 17:13 ` Ferruh Yigit
2019-04-12 17:13 ` Ferruh Yigit
2019-04-10 21:00 ` Bruce Richardson
2019-04-10 21:00 ` Bruce Richardson
2019-04-10 23:08 ` Stephen Hemminger
2019-04-10 23:08 ` Stephen Hemminger
2019-04-12 17:09 ` Ferruh Yigit
2019-04-12 17:09 ` Ferruh Yigit
2019-04-12 17:15 ` Ananyev, Konstantin
2019-04-12 17:15 ` Ananyev, Konstantin
2019-04-12 17:25 ` Ferruh Yigit
2019-04-12 17:25 ` Ferruh Yigit
2019-04-12 17:29 ` Ferruh Yigit
2019-04-12 17:29 ` Ferruh Yigit
2019-04-12 21:31 ` Stephen Hemminger
2019-04-12 21:31 ` Stephen Hemminger
2019-04-15 16:00 ` Ferruh Yigit
2019-04-15 16:00 ` Ferruh Yigit
2019-04-10 21:36 ` [dpdk-dev] [PATCH v2] ethdev: missing typecast causes C++ build error David Christensen
2019-04-10 21:36 ` David Christensen
2019-04-16 16:31 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-16 16:31 ` Ferruh Yigit
2019-04-16 16:39 ` Andrew Rybchenko
2019-04-16 16:39 ` Andrew Rybchenko
2019-04-16 16:46 ` Ananyev, Konstantin
2019-04-16 16:46 ` Ananyev, Konstantin
2019-04-16 21:19 ` Stephen Hemminger
2019-04-16 21:19 ` Stephen Hemminger
2019-04-16 21:50 ` David Christensen
2019-04-16 21:50 ` David Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1832941.R5tAQzo2FV@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=ferruh.yigit@intel.com \
--cc=radhika.chirra@ibm.com \
--cc=stable@dpdk.org \
--cc=vivkong@ca.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).