From: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
To: dev@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>,
Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC
Date: Fri, 28 Apr 2023 14:27:28 +0400 [thread overview]
Message-ID: <20230428102728.51956-4-denis.pryazhennikov@arknetworks.am> (raw)
In-Reply-To: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>
Only one valid FEC mode can be get by rte_eth_fec_get().
The previous name implied that more than one FEC mode
can be obtained.
Documentation was updated accordingly.
Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
Acked-by: Ivan Malov <ivan.malov@arknetworks.am>
Acked-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
---
lib/ethdev/rte_ethdev.c | 8 ++++----
lib/ethdev/rte_ethdev.h | 9 +++------
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index d02ee161cf6d..b046d4ea2f06 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -4718,7 +4718,7 @@ rte_eth_fec_get_capability(uint16_t port_id,
}
int
-rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
+rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode)
{
struct rte_eth_dev *dev;
int ret;
@@ -4726,7 +4726,7 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
dev = &rte_eth_devices[port_id];
- if (fec_capa == NULL) {
+ if (fec_mode == NULL) {
RTE_ETHDEV_LOG(ERR,
"Cannot get ethdev port %u current FEC mode to NULL\n",
port_id);
@@ -4735,9 +4735,9 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
if (*dev->dev_ops->fec_get == NULL)
return -ENOTSUP;
- ret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa));
+ ret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_mode));
- rte_eth_trace_fec_get(port_id, fec_capa, ret);
+ rte_eth_trace_fec_get(port_id, fec_mode, ret);
return ret;
}
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 0f10ac944061..aa71dbafc01f 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -4203,11 +4203,8 @@ int rte_eth_fec_get_capability(uint16_t port_id,
*
* @param port_id
* The port identifier of the Ethernet device.
- * @param fec_capa
- * A bitmask of enabled FEC modes. If AUTO bit is set, other
- * bits specify FEC modes which may be negotiated. If AUTO
- * bit is clear, specify FEC modes to be used (only one valid
- * mode per speed may be set).
+ * @param fec_mode
+ * The current FEC mode.
* @return
* - (0) if successful.
* - (-ENOTSUP) if underlying hardware OR driver doesn't support.
@@ -4216,7 +4213,7 @@ int rte_eth_fec_get_capability(uint16_t port_id,
* - (-ENODEV) if *port_id* invalid.
*/
__rte_experimental
-int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);
+int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode);
/**
* @warning
--
2.37.0 (Apple Git-136)
next prev parent reply other threads:[~2023-04-28 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:27 [RFC PATCH 0/3] improve FEC API usage Denis Pryazhennikov
2023-04-28 10:27 ` [RFC PATCH 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-02 14:57 ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-02 14:57 ` Ferruh Yigit
2023-04-28 10:27 ` Denis Pryazhennikov [this message]
2023-05-02 15:02 ` [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Ferruh Yigit
2023-05-04 7:13 ` Denis Pryazhennikov
2023-05-04 7:47 ` Ferruh Yigit
2023-05-08 11:47 ` [RFC PATCH v2 0/3] improve FEC API usage Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC Denis Pryazhennikov
2023-05-12 11:57 ` [RFC PATCH v2 0/3] improve FEC API usage Ferruh Yigit
2023-06-07 18:41 ` Ferruh Yigit
2023-06-19 12:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428102728.51956-4-denis.pryazhennikov@arknetworks.am \
--to=denis.pryazhennikov@arknetworks.am \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ivan.malov@arknetworks.am \
--cc=thomas@monjalon.net \
--cc=viacheslav.galaktionov@arknetworks.am \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).