From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Sunil Kumar Kori <skori@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags
Date: Sat, 18 May 2019 15:18:36 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725801616357C3@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1558006933-32247-2-git-send-email-skori@marvell.com>
Hi,
> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
> during fragmentation and reassemble operation implicitly.
> Because of this, application is forced to use checksum offload
> whether it is supported by platform or not.
>
> Also documentation does not provide any expected value of ol_flags
> in returned mbuf (reassembled or fragmented) so application will never
> come to know that which offloads are enabled. So transmission may be failed
> for the platforms which does not support checksum offload.
>
> Also, IPv6 does not contain any checksum field in header so setting
> mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.
>
> So removing mentioned flag from the library.
As there is a change in public API behavior, I think it deserves update in release notes.
Apart from that:
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 -
> lib/librte_ip_frag/rte_ipv4_reassembly.c | 3 ---
> lib/librte_ip_frag/rte_ipv6_reassembly.c | 3 ---
> 3 files changed, 7 deletions(-)
>
> diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
> index a96fb03..13e60fb 100644
> --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c
> +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
> @@ -173,7 +173,6 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num)
> fragment_offset = (uint16_t)(fragment_offset +
> out_pkt->pkt_len - sizeof(struct ipv4_hdr));
>
> - out_pkt->ol_flags |= PKT_TX_IP_CKSUM;
> out_pkt->l3_len = sizeof(struct ipv4_hdr);
>
> /* Write the fragment to the output list */
> diff --git a/lib/librte_ip_frag/rte_ipv4_reassembly.c b/lib/librte_ip_frag/rte_ipv4_reassembly.c
> index 1029b7a..4e20431 100644
> --- a/lib/librte_ip_frag/rte_ipv4_reassembly.c
> +++ b/lib/librte_ip_frag/rte_ipv4_reassembly.c
> @@ -66,9 +66,6 @@ struct rte_mbuf *
> m = fp->frags[IP_FIRST_FRAG_IDX].mb;
> fp->frags[IP_FIRST_FRAG_IDX].mb = NULL;
>
> - /* update mbuf fields for reassembled packet. */
> - m->ol_flags |= PKT_TX_IP_CKSUM;
> -
> /* update ipv4 header for the reassembled packet */
> ip_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4_hdr *, m->l2_len);
>
> diff --git a/lib/librte_ip_frag/rte_ipv6_reassembly.c b/lib/librte_ip_frag/rte_ipv6_reassembly.c
> index 855e3f7..eb8b849 100644
> --- a/lib/librte_ip_frag/rte_ipv6_reassembly.c
> +++ b/lib/librte_ip_frag/rte_ipv6_reassembly.c
> @@ -89,9 +89,6 @@ struct rte_mbuf *
> m = fp->frags[IP_FIRST_FRAG_IDX].mb;
> fp->frags[IP_FIRST_FRAG_IDX].mb = NULL;
>
> - /* update mbuf fields for reassembled packet. */
> - m->ol_flags |= PKT_TX_IP_CKSUM;
> -
> /* update ipv6 header for the reassembled datagram */
> ip_hdr = rte_pktmbuf_mtod_offset(m, struct ipv6_hdr *, m->l2_len);
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-05-18 15:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 11:24 [dpdk-dev] [PATCH 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 3/3] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-18 15:18 ` Ananyev, Konstantin [this message]
2019-06-26 21:10 ` Thomas Monjalon
2019-07-04 16:52 ` Thomas Monjalon
2019-07-05 8:31 ` Ananyev, Konstantin
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-18 15:21 ` Ananyev, Konstantin
2019-05-20 8:09 ` Sunil Kumar Kori
2019-05-20 8:15 ` Ananyev, Konstantin
2019-05-20 10:59 ` [dpdk-dev] [PATCH v3 1/2] " Sunil Kumar Kori
2019-05-20 10:59 ` [dpdk-dev] [PATCH v3 2/2] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-20 11:29 ` Ananyev, Konstantin
2019-05-20 11:28 ` [dpdk-dev] [PATCH v3 1/2] examples/ip_fragmentation: " Ananyev, Konstantin
2019-07-08 4:32 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag jerinj
2019-07-08 4:32 ` [dpdk-dev] [PATCH v4 2/3] examples/ip_fragmentation: enable IP checksum offload jerinj
2019-07-08 4:33 ` [dpdk-dev] [PATCH v4 3/3] examples/ip_reassembly: " jerinj
2019-07-08 9:07 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag Thomas Monjalon
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 3/3] examples/ip_reassembly: Enabling IP checksum offload in mbuf Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725801616357C3@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).