DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Sunil Kumar Kori <skori@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP	checksum offload in mbuf
Date: Sat, 18 May 2019 15:21:01 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725801616357D4@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1558006933-32247-3-git-send-email-skori@marvell.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sunil Kumar Kori
> Sent: Thursday, May 16, 2019 12:42 PM
> To: dev@dpdk.org
> Cc: skori@marvell.com
> Subject: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf
> 
> As per the documentation to use any IP offload features, application
> must set required offload flags into mbuf->ol_flags.
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
>  examples/ip_fragmentation/main.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index e90a61e..d821967 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -354,10 +354,13 @@ struct rte_lpm6_config lpm6_config = {
> 
>  		/* src addr */
>  		ether_addr_copy(&ports_eth_addr[port_out], &eth_hdr->s_addr);
> -		if (ipv6)
> +		if (ipv6) {
>  			eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv6);
> -		else
> +			m->ol_flags |= PKT_TX_IPV6;

Is there is any point to do that?
This sample app, as I remember doesn't request any extra HW offloads.
Same comment for patch #3.
Konstantin


> +		} else {
>  			eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv4);
> +			m->ol_flags |= (PKT_TX_IPV4 | PKT_TX_IP_CKSUM);
> +		}
>  	}
> 
>  	len += len2;
> --
> 1.8.3.1


  reply	other threads:[~2019-05-18 15:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 11:24 [dpdk-dev] [PATCH 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 3/3] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:42   ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-18 15:18     ` Ananyev, Konstantin
2019-06-26 21:10       ` Thomas Monjalon
2019-07-04 16:52         ` Thomas Monjalon
2019-07-05  8:31           ` Ananyev, Konstantin
2019-05-16 11:42   ` [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-18 15:21     ` Ananyev, Konstantin [this message]
2019-05-20  8:09       ` Sunil Kumar Kori
2019-05-20  8:15         ` Ananyev, Konstantin
2019-05-20 10:59     ` [dpdk-dev] [PATCH v3 1/2] " Sunil Kumar Kori
2019-05-20 10:59       ` [dpdk-dev] [PATCH v3 2/2] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-20 11:29         ` Ananyev, Konstantin
2019-05-20 11:28       ` [dpdk-dev] [PATCH v3 1/2] examples/ip_fragmentation: " Ananyev, Konstantin
2019-07-08  4:32       ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag jerinj
2019-07-08  4:32         ` [dpdk-dev] [PATCH v4 2/3] examples/ip_fragmentation: enable IP checksum offload jerinj
2019-07-08  4:33         ` [dpdk-dev] [PATCH v4 3/3] examples/ip_reassembly: " jerinj
2019-07-08  9:07         ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag Thomas Monjalon
2019-05-16 11:42   ` [dpdk-dev] [PATCH v2 3/3] examples/ip_reassembly: Enabling IP checksum offload in mbuf Sunil Kumar Kori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB97725801616357D4@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=skori@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).