From: "Dai, Wei" <wei.dai@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: Laurent Hardy <laurent.hardy@6wind.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated
Date: Mon, 13 Feb 2017 03:17:08 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A3676C5@PGSMSX106.gar.corp.intel.com> (raw)
In-Reply-To: <20170208180325.6e83f31c@glumotte.dev.6wind.com>
> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> Sent: Thursday, February 9, 2017 1:03 AM
> To: Dai, Wei <wei.dai@intel.com>
> Cc: Laurent Hardy <laurent.hardy@6wind.com>; Zhang, Helin
> <helin.zhang@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated
>
> Hi Wei,
>
> On Wed, 8 Feb 2017 15:51:42 +0000, "Dai, Wei" <wei.dai@intel.com> wrote:
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Laurent Hardy
> > > Sent: Friday, November 18, 2016 1:30 AM
> > > To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
> > > <konstantin.ananyev@intel.com>
> > > Cc: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated
> > >
> > > In case of link speed set to 1Gb at peer side (with autoneg or with
> > > defined speed) and cable not plugged-in when device is configured
> > > and started, then link status is not updated properly with new speed
> > > as no link setup is triggered.
> > >
> > > To avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a
> > > link setup each time link_update() is triggered and current link
> > > status is down. When cable is plugged-in, link setup will be
> > > performed via ixgbe_setup_link().
> > >
> > > Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
> > > ---
> > > drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++++++++++++
> > > drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
> > > 2 files changed, 21 insertions(+)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > index 52ebbe4..513d1d5 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > @@ -2095,6 +2095,7 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)
> > >
> > > /* set flag to update link status after init */
> > > intr->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
> > > + intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> > >
> > > /*
> > > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk
> > > @@ -3117,8 +3118,12 @@ ixgbe_dev_link_update(struct rte_eth_dev
> > > *dev, int wait_to_complete)
> > > struct ixgbe_hw *hw =
> > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > > struct rte_eth_link link, old;
> > > ixgbe_link_speed link_speed = IXGBE_LINK_SPEED_UNKNOWN;
> > > + struct ixgbe_interrupt *intr =
> > > + IXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);
> > > int link_up;
> > > int diag;
> > > + u32 speed = 0;
> > > + bool autoneg = false;
> > >
> > > link.link_status = ETH_LINK_DOWN;
> > > link.link_speed = 0;
> > > @@ -3128,6 +3133,19 @@ ixgbe_dev_link_update(struct rte_eth_dev
> > > *dev, int wait_to_complete)
> > >
> > > hw->mac.get_link_status = true;
> > >
> > > + if (intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) {
> > > + speed = hw->phy.autoneg_advertised;
> > > + if (!speed) {
> > > + ixgbe_get_link_capabilities(hw, &speed,
> > > &autoneg);
> > > + /* setup the highest link when no autoneg
> > > */
> > > + if (!autoneg) {
> > > + if (speed &
> > > IXGBE_LINK_SPEED_10GB_FULL)
> > > + speed =
> > > IXGBE_LINK_SPEED_10GB_FULL;
> > > + }
> > > + }
> > > + ixgbe_setup_link(hw, speed, true);
> > > + }
> > > +
> > > /* check if it needs to wait to complete, if lsc interrupt is
> > > enabled */ if (wait_to_complete == 0 ||
> > > dev->data->dev_conf.intr_conf.lsc != 0) diag = ixgbe_check_link(hw,
> > > &link_speed, &link_up, 0); @@ -3145,10 +3163,12 @@
> > > ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
> > >
> > > if (link_up == 0) {
> > > rte_ixgbe_dev_atomic_write_link_status(dev, &link);
> > > + intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> > > if (link.link_status == old.link_status)
> > > return -1;
> > > return 0;
> > > }
> > > + intr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;
> > > link.link_status = ETH_LINK_UP;
> > > link.link_duplex = ETH_LINK_FULL_DUPLEX;
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> > > b/drivers/net/ixgbe/ixgbe_ethdev.h
> > > index e060c3d..9d335ba 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> > > @@ -43,6 +43,7 @@
> > > #define IXGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)
> > > #define IXGBE_FLAG_MAILBOX (uint32_t)(1 << 1)
> > > #define IXGBE_FLAG_PHY_INTERRUPT (uint32_t)(1 << 2)
> > > +#define IXGBE_FLAG_NEED_LINK_CONFIG (uint32_t)(1 << 3)
> >
> > Now there is following macro in DPDK 17.02-rc2.
> > #define IXGBE_FLAG_MACSEC (uint32_t)(1 << 3)
> > You can redefine it as #define IXGBE_FLAG_NEED_LINK_CONFIG
> > (uint32_t)(1 << 4)
>
> Thanks, I'll send a v2.
>
> Do you agree with the rest of the patch?
So far I have no disagree opinions about the reset of this patch.
>
>
> Regards,
> Olivier
next prev parent reply other threads:[~2017-02-13 3:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 17:29 Laurent Hardy
2016-11-28 17:27 ` Laurent Hardy
2016-12-08 17:10 ` Ferruh Yigit
2017-02-01 14:14 ` Thomas Monjalon
2017-02-08 15:51 ` Dai, Wei
2017-02-08 17:03 ` Olivier MATZ
2017-02-13 3:17 ` Dai, Wei [this message]
2017-02-16 16:32 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2017-03-30 9:19 ` Olivier Matz
2017-03-30 16:32 ` Dai, Wei
2017-04-03 13:23 ` Laurent Hardy
2017-04-10 13:36 ` Ferruh Yigit
2017-04-11 12:13 ` Laurent Hardy
2017-04-12 8:21 ` [dpdk-dev] [PATCH] " Laurent Hardy
2017-04-18 14:33 ` Dai, Wei
2017-04-27 15:03 ` [dpdk-dev] [PATCH v4] " Laurent Hardy
2017-04-28 0:43 ` Dai, Wei
2017-04-28 5:23 ` Ferruh Yigit
2017-05-17 13:31 ` Roger B Melton
2017-05-22 18:54 ` [dpdk-dev] 2nd try: problem with ixgbe_dev_link_update() for multi-speed fiber [was] " Roger B. Melton
2017-05-23 7:24 ` Dai, Wei
2017-05-23 7:41 ` Dai, Wei
2017-05-24 14:40 ` Roger B. Melton
2017-05-24 18:38 ` Roger B. Melton
2017-06-02 16:15 ` Roger B. Melton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D63A3676C5@PGSMSX106.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=laurent.hardy@6wind.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).