From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Traynor, Kevin" <kevin.traynor@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information
Date: Fri, 4 Mar 2016 14:11:39 +0000 [thread overview]
Message-ID: <93BF5710-029E-4191-8A72-FFE82B409AC2@intel.com> (raw)
In-Reply-To: <BC0FEEC7D7650749874CEC11314A88F7454364C5@IRSMSX104.ger.corp.intel.com>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
>> Sent: Thursday, March 3, 2016 6:38 PM
>> To: Wiles, Keith <keith.wiles@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
>> information
>>
>> 2016-02-22 07:53, Keith Wiles:
>> > --- /dev/null
>> > +++ b/config/common_base
>> > +CONFIG_RTE_EAL_IGB_UIO=y
>> > +CONFIG_RTE_EAL_VFIO=y
>>
>> These options should be disabled in the base file
>> and enabled in Linux.
>>
>> > +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
>>
>> Idem, it should be disabled.
>>
>> > +CONFIG_RTE_LIBRTE_POWER=y
>>
>> Idem?
>>
>> > +CONFIG_RTE_LIBRTE_KNI=y
>>
>> Should be disabled.
>>
>> > +CONFIG_RTE_LIBRTE_VHOST=y
>>
>> Should be disabled.
>
>Any reason this should be disabled? It was changed to =Y in DPDK 2.1.
>
>It means updating scripts/build instructions to set =Y for OVS, no big
>deal but it might catch people out.
I do not see why it can not be disable, unless someone disagrees.
>
>
>Kevin.
>
>>
>> > --- a/config/common_bsdapp
>> > +++ b/config/common_bsdapp
>> > +# Compile Environment Abstraction Layer for linux, FreeBSD, OS X, ...
>> > +CONFIG_RTE_LIBRTE_EAL_BSDAPP=y
>>
>> Please keep the original comment:
>> Compile Environment Abstraction Layer for BSD
>>
>> > +# Compile Environment Abstraction Layer
>>
>> Why this comment before disabling UIO and VFIO?
>>
>> > --- a/config/common_linuxapp
>> > +++ b/config/common_linuxapp
>> > -##
>> > -## machine can define specific variables or action for a specific board
>> > -## RTE_MACHINE values are the directories in mk/machine/
>> > -##
>> > -#CONFIG_RTE_MACHINE="native"
>> > -#
>> > -##
>> > -## define the architecture we compile for.
>> > -## RTE_ARCH values are the directories in mk/arch/
>> > -##
>> > -#CONFIG_RTE_ARCH="x86_64"
>> > -#CONFIG_RTE_ARCH_X86_64=y
>> > -#CONFIG_RTE_ARCH_X86=y
>> > -#
>> > -##
>> > -## The compiler we use.
>> > -## RTE_TOOLCHAIN values are the directories in mk/toolchain/
>> > -##
>> > -#CONFIG_RTE_TOOLCHAIN="gcc"
>> > -#CONFIG_RTE_TOOLCHAIN_GCC=y
>>
>> Maybe we should keep these comments in common_base?
>> I would remove the values and uncomment CONFIG_RTE_MACHINE, CONFIG_RTE_ARCH
>> and CONFIG_RTE_TOOLCHAIN.
>>
>> > --- a/config/defconfig_x86_64-native-bsdapp-clang
>> > +++ b/config/defconfig_x86_64-native-bsdapp-clang
>> > @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>> > CONFIG_RTE_ARCH="x86_64"
>> > CONFIG_RTE_ARCH_X86_64=y
>> > CONFIG_RTE_ARCH_X86=y
>> > +CONFIG_RTE_ARCH_64=y
>> >
>> > CONFIG_RTE_TOOLCHAIN="clang"
>> > CONFIG_RTE_TOOLCHAIN_CLANG=y
>> > diff --git a/config/defconfig_x86_64-native-bsdapp-gcc
>> b/config/defconfig_x86_64-native-bsdapp-gcc
>> > index 5a6a4e8..4ea4433 100644
>> > --- a/config/defconfig_x86_64-native-bsdapp-gcc
>> > +++ b/config/defconfig_x86_64-native-bsdapp-gcc
>> > @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>> > CONFIG_RTE_ARCH="x86_64"
>> > CONFIG_RTE_ARCH_X86_64=y
>> > CONFIG_RTE_ARCH_X86=y
>> > +CONFIG_RTE_ARCH_64=y
>>
>> It should be a totally separate patch.
>> And there are other places where it is missing.
>
Regards,
Keith
next prev parent reply other threads:[~2016-03-04 14:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:53 Keith Wiles
2016-02-22 15:09 ` Trahe, Fiona
2016-02-22 16:02 ` Wiles, Keith
2016-02-22 16:44 ` Panu Matilainen
2016-02-24 13:58 ` Wiles, Keith
2016-02-24 14:19 ` Trahe, Fiona
2016-02-24 15:25 ` Wiles, Keith
2016-03-03 14:43 ` Wiles, Keith
2016-03-03 17:05 ` Thomas Monjalon
2016-03-03 18:37 ` Thomas Monjalon
2016-03-03 18:47 ` Wiles, Keith
2016-03-04 14:44 ` Wiles, Keith
2016-03-04 15:26 ` Thomas Monjalon
2016-03-04 9:28 ` Traynor, Kevin
2016-03-04 9:39 ` Panu Matilainen
2016-03-04 9:58 ` Traynor, Kevin
2016-03-04 10:28 ` Thomas Monjalon
2016-03-04 14:11 ` Wiles, Keith [this message]
2016-03-04 9:35 ` Panu Matilainen
2016-03-04 10:12 ` Panu Matilainen
2016-03-04 14:12 ` Wiles, Keith
2016-03-04 17:01 ` [dpdk-dev] [PATCH v2] " Keith Wiles
2016-03-04 17:26 ` Thomas Monjalon
2016-03-04 18:07 ` Wiles, Keith
2016-03-04 18:11 ` [dpdk-dev] [PATCH v3] " Keith Wiles
2016-03-04 22:43 ` Thomas Monjalon
2016-03-06 1:11 ` Ferruh Yigit
2016-03-06 1:21 ` [dpdk-dev] [PATCH] config: move Linux only config options from base to Linux config Ferruh Yigit
2016-03-06 9:35 ` [dpdk-dev] [PATCH v3] config: remove duplicate configuration information Thomas Monjalon
2016-03-07 12:41 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93BF5710-029E-4191-8A72-FFE82B409AC2@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.traynor@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).