From: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)" <jgrajcia@cisco.com>
To: David Marchand <david.marchand@redhat.com>,
"Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
Cc: dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave
Date: Wed, 30 Oct 2019 10:17:31 +0000 [thread overview]
Message-ID: <955be42a14bf484aae1afaf4157504f4@XCH-ALN-004.cisco.com> (raw)
In-Reply-To: <CAJFAV8xsGoW6ypY3dLq0QAwFLhtJkoaWexD-p8CW2QyWo_cUNQ@mail.gmail.com>
> > On 8/22/2019 9:18 AM, Jakub Grajciar wrote:
> > > Zero-copy slave support for memif PMD.
> > > Slave interface exposes DPDK memory to master interface. Only single
> > > file segments are supported (EAL option --single-file-segments).
>
> Do you really want this additional configuration in your driver or can't you
> enable/disable the functional
Performance with multi file segments is worse than non-zero copy, so there is no reason to implement.
> > > +/**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this API may change without prior notice
> > > + *
> > > + * Get the single_file_segments parameter value from memory
> configuration.
>
> I would prefer you describe what this actually means.
> We don't really care about the value itself.
Ack.
>
>
> > > + */
> > > +__rte_experimental
> > > +uint32_t
>
> And a boolean is enough, this is a flag.
Ack.
>
>
> > > +rte_mcfg_get_single_file_segments(void);
> > > +
> > > #ifdef __cplusplus
> > > }
> > > #endif
> > > diff --git a/lib/librte_eal/rte_eal_version.map
> > > b/lib/librte_eal/rte_eal_version.map
> > > index 7cbf82d37..c2b9d473f 100644
> > > --- a/lib/librte_eal/rte_eal_version.map
> > > +++ b/lib/librte_eal/rte_eal_version.map
> > > @@ -418,5 +418,6 @@ EXPERIMENTAL {
> > > rte_lcore_to_cpu_id;
> > > rte_mcfg_timer_lock;
> > > rte_mcfg_timer_unlock;
> > > + rte_mcfg_get_single_file_segments;
> >
> > This should be moved to 19.11 block in experimental
>
> +1
Ack.
>
>
> > cc'ed Dave for eal part,
> > @Dave, change looks straight forward but can you please check/comment?
>
> I don't like the name of this API, since it gives the impression it returns
> "segments"..
> But on the other hand, this is aligned with the mcfg field: people touching the
> internals have more chances to see there is an exported API.
Do you have any suggestions? How about rte_mcfg_get_single_file_segments_parameter()?
>
> Cc: Anatoly (but I think he is off for this week).
>
> Other than that I am ok with this change.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2019-10-30 10:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 8:22 [dpdk-dev] [PATCH v4] " Jakub Grajciar
2019-07-10 15:06 ` Ferruh Yigit
2019-07-23 12:35 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-08-22 8:18 ` [dpdk-dev] [PATCH v5] " Jakub Grajciar
2019-10-04 13:23 ` Ferruh Yigit
2019-10-15 16:59 ` Ferruh Yigit
2019-10-17 11:52 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-17 16:04 ` Ferruh Yigit
2019-10-17 16:45 ` Ferruh Yigit
2019-10-21 16:07 ` Ferruh Yigit
2019-10-25 16:44 ` Yigit, Ferruh
2019-10-29 14:28 ` David Marchand
2019-10-30 10:17 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) [this message]
2019-10-30 10:25 ` David Marchand
2019-11-04 11:03 ` [dpdk-dev] [PATCH v6] " Jakub Grajciar
2019-11-11 15:21 ` Ferruh Yigit
2019-11-11 15:24 ` Thomas Monjalon
2019-11-12 12:55 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-11-11 15:49 ` David Marchand
2019-11-15 16:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955be42a14bf484aae1afaf4157504f4@XCH-ALN-004.cisco.com \
--to=jgrajcia@cisco.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).